pfSense

system_routes action button titles

Merge pull request #2567 from phil-davis/patch-3

system_certmanager action button titles

system_camanager action button titles

Merge pull request #2566 from phil-davis/patch-1

system_gateway_groups action button titles

Apply current UI standard to DHCP Pools table

1) "Actions" column heading.
2) Make action buttons fa-pencil fa-trash
3) Put a title for each button, so that the "Are you sure you wish to..." popup works nicely.

Fixup text for delete rule confirmation popup

It is was asking "Are you sure you wish to delete?"
On any buttons that have a confirmation popup the title text needs to be something that works on the end of "Are you sure you wish to".

Update typo spotted by @phil-davis

Remove static routes to DNS servers when gateway is disabled. It should fix #4921

Remove href to prevent page scrolling on click

Test duplicated slice with fsck after cloning during an upgrade

Merge branch 'Auto_Suggest_Box_White_on_White' of https://github.com/NOYB/pfsense

• 'Auto_Suggest_Box_White_on_White' of https://github.com/NOYB/pfsense:
  Fixes 5804 - Auto Suggest Box White on White

Cosmetic changes - part deux
Calculate colspans in casenumber of columns change again
"bytes" => "B" to reduce column width

Cosetic update - Part 1

Fixed #5804

Merge pull request #2393 from schinken/radvd-lifetime

Add possibility to configure radvd valid lifetime

Show rule state details in firewall rules.

Inspired by pull request #1901 from marcelloc/hitcount_23_02.

State visualization and kill will be committed in a subsequent commit.

Merge pull request #2120 from NOYB/Services-DNS_Resolver-System_Domain_Local_Zone_Type

Fixes 5804 - Auto Suggest Box White on White

Match it with form input and form-control.

Fixed #5803

Status - System Logs - Move Raw Mode Row Count JQuery

Move row count JQuery to run only in raw mode.

Merge pull request #2555 from phil-davis/patch-2

Merge pull request #2558 from phil-davis/patch-7

Merge pull request #2560 from phil-davis/patch-5

Status IPsec info box

As well as internationalization of this info box, I have:
1) Made all of them the same text - it seemed odd that there were 2
different versions of text for the same thing.
2) Made it an info-level infoblock. It seemed odd to me that this was...

status_ntpd whitespace

Various lines were not on tab stops, some PHP end tags were on the end of lines and others on new lines... I found it a bit hard to read when tracking through a previous missing PHP start tag. Maybe this is better? or maybe I have gone too crazy re-formatting it?

Select an interface to track is mandatory

Merge pull request #2559 from phil-davis/gt16

Fixed #5824

Internationalization of various status*.php

RRD Graph custom options help text

Minor grammar only!

Remove need for escaped single quote

Merge pull request #2557 from phil-davis/patch-6

status_pkglogs fix dodgy div tag

This did not look right :)

Merge pull request #2556 from phil-davis/patch-5

Fix #4605

After base64 encoding username/password, properly escape characters =,+,/
before submitting auth details

status_ntpd missing start php

This seems to be the only missing bit here. I think it would only cause a noticeable UI problem if isset($gps_alt).

If you have a system with a real GPS that has altitude, then please test!

There is also a bunch of formatting issues in this file - things that are not on tab stops... After this real bug is fixed I will then make a PR to sort out the white-space.

Simpler solution still

Simplied fix for #5823

Fixed #5823

Internationalize status_graph_cpu

This one is a bit odd, so I have made a separate pull request. There seems to be no place in the menus that comes to this page - I had to manually enter the URL to get to it to test. I checked on 2.2.6 also, and there is no menu entry for it....

Fix parse error: syntax error, unexpected ')' in /usr/local/www/services_igmpproxy.php on line 109

Merge pull request #2550 from phil-davis/status_logs_help

Merge pull request #2553 from phil-davis/patch-5

Merge pull request #2552 from phil-davis/patch-2

Merge pull request #2551 from NOYB/Status_/_System_Logs_/_Firewall_/_Dynamic_View_-_Mode_Force_Comments

Merge pull request #2548 from phil-davis/diag-logs

Merge pull request #2547 from NOYB/Dev_Shell_-_Cmd_Tab_Completion

Merge pull request #2546 from phil-davis/gt15

Internationalize DHCPv6 lease status words

Internationalize the word dynamic also

Internationalize DHCP lease status words

Status / System Logs / Firewall / Dynamic View - Mode Force Comments

Add comments when forcing formatted/raw mode.

Sort status_logs.php key references

So they are easy for people to find in the future.

Handle individual status_logs help references

Fixup old diag_logs references

Note: The shortcuts for upnp were not showing. This was because
shortcuts.inc only includes *.inc files from /usr/local/www/shortcuts
So I have renamed pkg_upnp.php to pkg_upnp.inc
I notice that some time in the past it used to be pkg_upnp.inc because...

fixes 5818 - Dev Shell - Cmd Tab Completion

More internationalization of servicescode

Merge pull request #2545 from phil-davis/patch-2

Standardize print_apply_box usage

1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually....

Standardize gpsnoselect var name

It looks confusing that in the config there is ['noselect'] but the locally-used var in the GUI is gpsselect.
Reduce future confusion by replacing gpsselect -> gpsnoselect.
There is no actual bug here, just fixing naming consistency.

Meant to have show_recordings here. Ticket #5657

correct function name. Ticket #5657

Revised power setting fix

Fixed variable names for power save modes

Internationalize services_d*

Regenerate pot file

Remove .json when it's not necessary anymore

Use a different log for each package being installed/deleted, fixes #5814

Use a better name for pfSense-upgrade socket file

Disable save button on clicking 'save'. Prevents double-dipping

Remove glyphicon import (finally)

Various small styling changes

Merge pull request #2542 from phil-davis/gt12

Internationalization services_captiveportal code

Typo gettetx

Fixed #5335

Revise countdown message for internationalization

Make sure we install repo package when it's not installed

Remove dead code used for alternative firmware url

A couple more refinements for pfSsh.php while I'm here.

Fix validation of playback file passed to pfSsh.php. Fixes #5657

Fixed #5807

Further refinement to timeout message

Revise reload countdown for internaionalization

Merge pull request #2540 from NOYB/HTML_Compliance_-_Firewall_Rules_-_Separator

Merge pull request #2539 from NOYB/HTML_Compliance_-_Widget_-_Firewall_Logs

Status / System Logs / Firewall / Dynamic View - Efficiency Tweaks

Not very efficient to go through the entire table setting the class on existing entries that already have their class set. Just set the class on new entries when they are added to the table....

HTML Compliance - Firewall Rules - Separator

The font element is obsolete. Use CSS instead.
<font class="bg-danger">The Bad</font>

HTML Compliance - Widget - Firewall Logs

Attribute (that|triggered|this|action) not allowed on element a at this point.

Tidy print_info_box comments

Remove unnecessary checks. Code prevents var from being empty.

Wrap var in string with braces.

Move unbound local zone types array to function in unbound.inc.

Protect against breaking the system; check for valid unbound local zone type rather than just the setting existence.

Remove errant var set to self.

Break long line of local zone types list.

Fix up config setting for killing states on gateway failure. Enable this option where gw_down_kill_states is set. Flip setting accordingly during config upgrade to not use confusing 'kill_states' tag to not kill states. Ticket #5815

Added some some comments to hte print_info_box area so package developers will know what happeded

Completed #5787