pfSense

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Fix population of the wireless parent list. Fixes #5992

Re-commit change

Revert "Fixed #5983"

This reverts commit 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Merge pull request #2736 from phil-davis/patch-2

Merge pull request #2735 from NOYB/HTML_Compliance_-_Firewall_/_Schedules_/_Edit_-_Readonly_Attribute

Merge pull request #2732 from ExolonDX/branch_02

Merge pull request #2728 from phil-davis/form_button

Fixed #5983

Added the ability to move multiple firewall rules via a "movre to here" icon (anchor)

Icon missing from default pkg.php save button. Ticket #5965

Change to 4 spaces

Fix styling on "Create Phase 1" button. Ticket #5965

Anchot icon requires icon-pointer class

Translate button text

Merge pull request #2734 from NOYB/System_/_Routing_/_Gateways_/_Edit_-_Punctuation

Merge pull request #2733 from ExolonDX/branch_03

Merge pull request #2731 from ExolonDX/branch_01

Merge pull request #2730 from NOYB/HTML_Compliance_-_Status_Dashboard_-_System_Information_Widget

HTML Compliance - Firewall / Schedules / Edit - Readonly Attribute

Error: Bad value readonly for attribute type on element input.

Readonly is not a valid type attribute value.
If the intention here is to prevent the fields from being edited. Use the readonly attribute....

Use file-text-o instead of file-o for consistency. Ticket #5965

System / Routing / Gateways / Edit - Punctuation

Tidy up "interfaces_bridge_edit"

Change type of input to number

Tidy up "system_gateways_edit"

Tidy up missing semi-colon in non-breaking space

Tidy up "pkg_mgr_installed"

Remove stray closing SMALL tag

HTML Compliance - Status Dashboard - System Information Widget

Error: Stray end tag spa.
Error: End tag td seen, but there were open elements.
Error: Unclosed element span.

Use route_vpn_gateway for tap-type OpenVPN instances as well where specified. Remove old and wrongly copy/pasted comments while here. Ticket #5981

adjust nvd3 chart height and make rule more strict

Fix icon usage on the interfaces widget, the down icon was arrow-up. Add color to the status for clarity. Ticket #5965

Fix online user counts for CP/Vouchers. Fixes #5978

Resolve conflicts with master

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Some safety belts to avoid presenting PHP errors to the user. Ticket #5973

Ensure $a_cert is always an array. Fixes #5977

Tweaks/fixes for WoL, ticket #5965

Fixup Toggle All button, ticket #5965

Merge pull request #2725 from NewEraCracker/system_certmanager-fixes

Merge pull request #2727 from phil-davis/savebtn

Merge pull request #2726heper:patch-2 from phil-davis/patch-2

Fix $POST checks so they do not depend on string Save

This prevents problems when Save is translated to other languages.
Note: This is the only remaining place I could find with this issue.
There are other pieces of code that do:
```
if ($_POST['save'] == gettext("Save"))...

Use a more clear icon/wording on Diag > Tables button to flush the table. Ticket #5965

Use less confusing button text/colors/icons for Factory defaults/Halt/Reboot. Ticket #5965

Translate the default submit button text

Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text....

HTML Compliance - CARP Status Widget

Error: th start tag in table body.
Warning: A table row was 1 columns wide, which is less than the column count established by the first row (3).

Indent system_certmanager.php

The 'csr' code block is duplicated. This commit removes it

Fix QinQ member save action. Ticket #5965

Fix some Save button quirks. Ticket #5965

change to class for multiple update locations

Merge pull request #2722 from NOYB/Status_Monitoring_-_Settings_Panel_Collapsible

More icon and button inconsistencies. Should be the last batch. Ticket #5965

More icon/button inconsistencies. Ticket #5965

More icon/button inconsistencies. Ticket #5965

Make fa-save the default button icon for 'Save' on all forms. Ticket #5965

Advanced button consistency. Ticket #5965

Fix button icons in the package manager. Ticket #5965

More icon and button consistency fixes. Ticket #5965

Add the ability for packages to control their button icon and class. Ticket #5965

Revised disk space display to use progress bar

Make the Notification settings test buttons consistent with other buttons in the GUI. Ticket #5965

Merge pull request #2721 from phil-davis/patch-2

Status Monitoring - Settings Panel Collapsible

Make the status monitoring settings panel collapsible with page load state configurable in general setup associated panels show/hide.
Replace Update button with refresh icon on title bar.

Required by FreeBSD-Ports pull request #78 Status Monitoring - Settings Panel Collapsible.

Improve test for firewall rule advanced setting

You could make some advanced settings, save the firewall rule, then when editing again the advanced section would not be automatically open. That makes it hard for users to realise that a rule has some advanced setting(s)....

Display NAT advanced source settings if defined

On NAT Port Forward Edit, if any of the source port settings are different to the defaults then display the source fields, rather than just the Advanced button.
Otherwise when editing a NAT port forward with source address/port settings, it is not obvious to the user that there are existing source settings "hiding" under the Advanced button.

Add button on pkg needs fa-plus, too. Ticket #5965

Fix CP portal page controls (view, download, reset) for consistency. Ticket #5965

Fix some more stragglers for icon/button consistency. Ticket #5965

Fix icon consistency and some other formatting issues on the LDAP picker. Ticket #5965

Fix typo

Fix voucher regenerate button action.

Fixed 5971

Icon consistency in Repeatable blocks. Ticket #5965

Fix formatting on the UPnP page, fixes #5970

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

Correct reference for 6rd. Ticket #5967

Remove bonus comma

Fix alias import icon visibility, and change to a more relevant icon. Fixes #5963

Changed all selectoraction to"change" instead of "click"

Fixed #5962

Upon further review, use a more clear and related set of icons for CARP status, play-circle (master) and pause-circle (backup). Ticket #5965

Change shortcut bar status icon to bar-chart, the gear/cog purpose was unclear, looked too much like a settings icon. Ticket #5965

Change "internal" representation of CA on CA and CRL list to an icon, and the inuse indicator on CRLs to an icon. Ticket #5965

Add visual indication of negation on Outbound NAT list. Fix static port representation to use an icon with a helpful title. Ticket #5965

Give a visual indication when a port forward has the negation option active (no rdr). Ticket #5965

Correct the text and placement of the disable and nobinat options for 1:1 NAT rules. Fixes #5966

Slight change to CARP status icons, difference between master and backup status was not clear enough. Ticket #5965

Correct some icon usage inconsistencies. Fixes #5965

Clean up the CARP status widget. Fixes #5964

Move Save button on config history settings inside the panel with the other settings. Fixes #5961

Merge pull request #2717 from NOYB/System_/_User_Manager_/_Groups_/_Edit

Merge pull request #2716 from phil-davis/patch-6

Merge pull request #2715 from phil-davis/patch-5

Merge pull request #2714 from phil-davis/actions

Merge pull request #2713 from phil-davis/patch-3

System / User Manager / Groups / Edit

Error: th start tag in table body.

Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).

Change invalid use of $iface in interfaces.php

At this point $iface is an undefined var. So the last test of this "if" statement is useless.
That code fragment was introduced in commit https://github.com/pfsense/pfsense/commit/e4d40f41aafe00353c0069b457a0b1b0d6c20987...

Improve track6-prefix-id handling

1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max
2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range....

Add Actions column heading

to other places where it was missing, for UI consistency.

Add Actions column heading for CRL Manager

To be consistent with everywhere else that has a heading for the Actions column.

System / User Manager / Users / Edit

Warning: A table row was 4 columns wide and exceeded the column count established by the first row (3).

Error: Stray end tag td.

On second though, don't use this class on this particular tag in the WoL widget.