pfSense

Fix word case

Remove unused variable.

Partial update of license.php. Ticket #5903

Workaround to prevent the sortable library from being loaded on very large tables.

Fixed #5904

Add m0n0wall entry back and also use product_name on pfSense line

Merge pull request #2591 from k-paulius/patch-license

Merge pull request #2658 from NOYB/Available_Widgets_Icon_Missing

Merge pull request #2657 from NewEraCracker/status_logs_vpn-buffer-space-removal

Merge pull request #2654 from NOYB/Status_/_System_Logs_-_Associated_Panels_-_Remove_Icon_Text_Buffer_Space

Merge pull request #2653 from k-paulius/patch-12

Slightly reduce logo size. Looks a bit nicer and prevents navbar from wrapping into a second row when notification icon is displayed.

May as well fix this while here.

Replace style cursor:pointer with bootstrap class icon-pointer.

Fix #4675

Following bugs and improvements on DHCPv6 DDNS area, obtained from
PR #1638 from @Robert-Nelson:

- Use correct domain (ddnsdomain) instead of (domain)
- The option "deny client-updates" wasn't being set so forward entries
weren't being added. Allow user to chose between allow, deny or ignore...

Fix for but #5901

Move the widgets save out of index.php jquery and into head.inc php along with it's counterpart the available widgets icon.

status_logs_vpn.php - Remove icon text buffer space

Fix another occurrence similar to PR #2654

Status / System Logs - Associated Panels - Remove Icon Text Buffer Space

The space that was being inserted as a buffer between button icon and text is no longer necessary. Recently addressed in css.

carp_status is now status_carp

Align notification and logout icons to the right, to make them stand out from the menu items.

Expand advanced where advanced options are configured. Ticket #5900

Exclude assigned bridge interfaces from selection as part of bridge config. Ticket #5900

Fix interfaces_bridge_edit.php fields. Ticket #5900

Correct default if_bridge settings.

Fix mistyped word

Use p instead of br for better styling support.

This wording is also shown during system upgrade, so update it to be more accurate.

No need for this message to be in bold.

Move action alert box to the top of the page, just like on all other pages.

Convert button name to upper case.

Review alert wording. End sentence with period

Remove breaks and use content class to provide proper styling.

Change wording from stating what is going to happen to asking user if they want it to happen.

Change wording from stating what is going to happen to asking user if they want it to happen.

Do not generate empty tags if there is no link.

Prevent "Ignore denied clients" and "Failover Peer IP" from being combined in the DHCP server settings for IPv4. The daemon fails to start when configured in this way, it apparently only allows "allow" or "deny" in failover mode. Fixes #5898

Simplify the code with the use the newly introduced function to list CARP addresses.

Fix handling of promicuous checkbox on packet capture. Fixes #5896

Fix spacing issue with "Exclude ESP"

Merge pull request #2650 from NOYB/Firewall_/_Rules_-_Simplify_Order-Store_Loops

Merge branch 'patch-9' of https://github.com/k-paulius/pfsense

• 'patch-9' of https://github.com/k-paulius/pfsense:
  Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Restore infoblock div

Revise button icon spacing

• Converted alerts to callouts. * Split first message into paragraphs to make it more readable * Moved 2nd and 3rd messages above the applicable panels, instead of being below them; that's how it was in v2.x

Convert alert to callout

Replace alert with callout. Removed mention about greyed out icon - that is no longer applicable.

Add support for Bootstrap callouts

Use PHP CLI explicitly to run rc.conf_mount_r(w|o) from pfSense-upgrade, it fixes #5875

Headers don't need HTML entities

This commits fixes form submission on Services/UPnP redirecting to an URL with & on it.

Firewall / Rules - Simplify Order-Store Loops

Replace indexing for loops with more easily readable key/value foreach loops.
Make the order-store rules selection logic consistent with the display rules selection logic.

Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Remove Help -> Search Portal menu entry, it fixes #5894

Merge pull request #2645 from NewEraCracker/print_info_box-fix

Fix broken HTML in diag_gmirror.php

Bring all calls of print_info_box to same standard

The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.

Escape ampersands in links - part 2

Merge pull request #2641 from k-paulius/patch-7

Escape ampersands in links

For better HTML conformant with standards.

Merge pull request #2643 from NewEraCracker/html-fix

Move valign to style - part 2

Move valign to style

Make HTML conformant with standards

Escape '&' via htmlspecialchars.

Firewall / Rules - for/foreach Vars

Replace for $i var with foreach $filteri var.

Move add button outside the panel.

Only display the message if there are no entries in the table, do not display empty panel and table.

Perform HTML entity translations

Need to pass zone in the GET params so we don't get redirected to status_captiveportal.php

Rename form submit button, adjust message

Move result message to the top of the page.

Change form submit button text to 'Test'. Use alert box classes instead of text color to indicate success or failure.

Move result message to the top of the page.

Show page title because that's where page help icon is displayed.

Only display tab name in the breadcrumb if vouchers are enabled. Do not display zone name in the panel title because it is already displayed in the breadcrumb.

Fix when "No Captive Portal zones" message is displayed and do not display it inside the panel.

Code style fix.

Code style fix.

Fix DHCPv6 Server detection on DHCPv6 Relay page.

Fix DHCPv6 Relay detection on DHCPv6 Server page. It broke due to dhcrelay6 config format changes.

Merge pull request #2637 from k-paulius/patch-6

Add support for multiple span ports on bridge.

While here, fix and improve the error detection for the selected ports.

Inspired by pull request #2613 from heper/patch-1

Ticket #5871

Switch tabs places so that active tab is the first tab

Rename 'Backup/Restore' to 'Backup & Restore' so it does not clash with breadcrumb separator.

Rename NTP tab to Settings to be more user friendly.

Indicate in the breadcrumb if we are editing list item.

Rename 'DHCPv6 Server/RA' to 'DHCPv6 Server & RA' so it does not clash with breadcrumb separator.

Remove Zone: prefix before the zone name to make breadcrumb a bit shorter + it is obvious what it is

Update breadcrumb to match tab name

Show in the breadcrumb if we are modifying floating rule.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Use print_info_box() to generate alerts

Use print_info_box() to generate alerts

Review alert wording.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

No need to state that it is a warning

Use print_info_box() to generate alerts

Use print_info_box() to generate alerts

Indicate in the breadcrumb if we are editing list item.

Perform HTML entity translation where & is used

Indicate in the breadcrumb if we are editing list item.

Merge pull request #2632 from NOYB/Interfaces_-_DHCP_Advanced_Options_Tweaks

Do not echo printf return value

Previous implementation would print both the content and return value. Changing to sprintf while retaining the short opening echo tag, echoes the content as intended and keeps code in line with the style of the project.