pfSense

Captive Portal auth method is required

When creating a new Captive Portal Zone the user can fail to select any of the Authorization Method radio buttons. No default radio button is selected - that is probably good, as the user has to think and click to decide which authorization method they will use....

Revert change to css

Merge pull request #3424 from phil-davis/patch-8

Merge pull request #3438 from phil-davis/required-fields-shaper-name

Require Name field in Shaper

change opacity on disabled rows to fix #6448

Require at least one tag value in a QinQ entry

Use is_intrange() to validate QinQ tag range

Note: is_intrange() only tells us that the range is good and might be delimited by a "-" or a ":", so if we want to take apart the 2 parts of the range (like is done here) we have to also test the string to decide which separator to use....

Merge pull request #3435 from phil-davis/required-fields6

Introduce is_intrange() to validate a range of integers delimited by ':' or '-'

Merge pull request #3436 from NOYB/System_Update_Settings_-_GitSync_Options_master

Merge pull request #3434 from phil-davis/required-fields5

Merge pull request #3430 from phil-davis/required-fields3

Merge pull request #3419 from phil-davis/required-fields2

Merge pull request #3421 from phil-davis/patch-4

Required fields for firewall*.php

System Update Settings - GitSync Options

Add GitSync options selectors to post update GitSync.
Minimal, Diff, Show Files, Show Command, Dry Run

The GitSync options have utility for post update sync also.

Dependency: Will merge cleanly but for the options to be functional, https://github.com/pfsense/FreeBSD-ports/pull/263 is required.

Remaining required fields for Diag pages

More required fields for Interface pages

More required fields for NAT pages

QinQ Tag Value Validation

Tags must be in the range 1 to 4094
Flag the various input errors and only report them once each.

Use gettext on Username and Password

Merge branch 'master' into patch-4

Merge branch 'master' into patch-6

Required fields in Status pages

Merge pull request #3384 from PiBa-NL/traficgraphs-backgroundupdates

Merge pull request #3426 from jskyboo/master

Merge pull request #3414 from phil-davis/ipv6-compress

Merge pull request #3431 from phil-davis/if-ifg-alias-name-validation

Merge pull request #3432 from phil-davis/required-fields4

Merge pull request #3420 from phil-davis/patch-3

Merge pull request #3417 from phil-davis/patch-2

Merge pull request #3416 from phil-davis/patch-1

Merge pull request #3415 from phil-davis/required-fields1

Remove unused variable $cfglckkeyconsumers

Fixed #7155 by replacing toggle with jQuery

Fixed #6958

Fix comment

Fixed #7128

Merge pull request #3428 from phil-davis/patch-10

Merge branch 'master' into if-ifg-alias-name-validation

Merge branch 'master' into patch-4

Interface groups setHelp message

Mention that it is not allowed to end in a digit.

Merge pull request #3429 from phil-davis/patch-11

firewal_nat_edit function name typo

This unrelated fix is in a big diff listing of other stuff related to a proposed RADIUS enhancement https://github.com/pfsense/pfsense/pull/3407/files#diff-f080be89fa12ff3c28d7467b12985d09
The accidental typo should be fixed, rather than getting stuck in that other PR.

Fixed #6967

Required fields in Load Balancer pages

Interface description must be unique including case

Required fields in Interfaces pages

interfaces.php display correct descr in group name message

Use the description that the user attempted to enter, not the original (and probably valid) description.

Fix #7151 Misleading setHelp for Interface Group Name

Might as well use the same text as is given to the user in the error message already in this code.

Parse GPS initialization commands, extended status for GPSs other than SureGPS and make optional.
- Parse GPS initialization commands for explicitly configured GPS commands
- Add extended GPS status if GPGSV or GPGGA are explicitly configured
- Add config option to toggle extended status...

QinQ Edit fix row add delete

1) Make the row delete button actually work
2) Do not allow ranges that go backwards like 25-20 or just "-" or 1-sided ranges "-42" "42-"
3) Remember the POSTed stuff to redisplay to the user if there were input errors
4) Ranges or numbers entered could overlap - just save a list of the unique members. e.g. If the user enters 5-15 and 10-20

Interface Group Name should be required

Do not allow it to be blank. Do not bother with all the other checks on the group name if it is blank.
(At the moment I can enter an Interface Group with blank name)

Validate POSTed interface description

Copy-paste error from code that used $_REQUEST. This is more correct to use $_POST.

Interface description should be required

I was blanking out stuff to see what input error messages came about fields that are required. I was surprised that the Interface Description would save empty. The system did not immediately explode (I was playing with a bonus interface I had created in a VM) but I don't think it is desirable to have interfaces with no description....

6RD Border Relay input error message

This field is labelled "6RD Border Relay" on the main UI. It confused me for a moment when I got this message "6RD Border Gateway must be an IPv4 address." since there was no field with that label in the 6RD section of the UI....

Required fields in NAT pages

Add required fields to firewall_aliases_import

Display input error when no aliases to import

Currently if you put nothing in the "Aliases to import" box and press Save then the page just reloads - nothing saves and there is no message about the problem. It should tell you to that "Aliases to import" is required.

Required fields in diagnostics

Force compress for where_is_ipaddr_configured check_localip

Force compress for where_is_ipaddr_configured

Always force compress when calling Net_IPv6

Handle cases when help is the first priv a user has

Add a parameter to install_cron_job to stop it from performing its own write_config. Adjust base system calls to match. Ticket #7146

Packages may still need the old behavior but need tested individually. Once all function calls are confirmed to work without the write, the write_config parameter and call can be removed from this function for good.

Merge pull request #3409 from phil-davis/interfaces-required-fields

Merge pull request #3405 from NOYB/Internationalization

Fix #7086: Copy files over from /var before umount it and move to MFS

Example of setting required items

Refinement to #7083
Provides setRequired() Javascript function to facilitate making an input required or not dynamically

Internationalization (getttext)

Please also backport to 2.3

Make sure all ZFS volumes are mounted during boot and only mount /var and /tmp when MFS is disabled. Fixes #7086

Merge pull request #3403 from phil-davis/no-empty-menu

Allow external links to show in menus as they will never match privileges and they are not items that need to be restricted.

Add "required field" highlighting

Merge pull request #3378 from phil-davis/patch-2

fields with <required/> set now pre-pend an asterisk to the field title, thereby causing it to be displayed as a required field (currently an underline)

Fixed #7083

When composing an element with a form.class or via XML, prepend a '*' to the title to indicate a required field. This will cause the "element-required" class to be added to the label. pfSense.css contains the style associated with that class. (Currently a custom underline)....

Do not show empty menus

Merge pull request #3402 from phil-davis/patch-6

Merge pull request #3400 from phil-davis/patch-4

Merge pull request #3398 from phil-davis/is_carp_master

Merge pull request #3397 from phil-davis/patch-3

Merge pull request #3396 from phil-davis/patch-1

Merge pull request #3390 from NOYB/Status_/_Interfaces_-_Relinquish_DHCP_Lease

Fix #7141 Add a priv for UPNP

so users can grant access to Services->UPNP
Note: Status->UPNP already has a priv and it works.

Fix #7139 Accessing help about this page

from a user that does not have admin or all page privilege.

Fix #7136 Start OpenVPN on ordinary VIP

Fix copy-paste of ipsec.widget.php file name

Noticed while looking in widget code, might as well fix it.

Fix #7134 Interface Stats widget ifdescrs not defined

When doing testing I had the Interfaces widget open as well as Interface Statistics. $ifdescrs was already populated as an array by the Interfaces widget, so Interface Statistics had (accidentally) gained the benefit....

Protect against forech errors if this function does not return an array. Fixes #7134

Status / Interfaces - Relinquish DHCP Lease

Send gratuitous DHCP release message to server.

Dependency:
To fully relinquish the DHCP lease, the "RELEASE" reason needs to be added to the /usr/local/sbin/pfSense-dhclient-script.
s/EXPIRE|FAIL)/EXPIRE|FAIL|RELEASE)/...

Use friendly description for RA interface name. Fixes #7133

Status / Interfaces - Match Var Names

Match Form Input and Function Parameter Names with associated Var Name.

Use "ifdescr" as form input name instead of "if" since "ifsescr" is the var being passed.
Use "ifdescr" as showDefBtn function var instead of "ifval" since "ifsescr" is the var being passed....

Regenerate pot

Add filter to SMART status widget

The confirmation checkboxes on diag_resetstate.php should not be checked by default.

Merge pull request #3392 from phil-davis/openvpn-widget

Merge pull request #3393 from doktornotor/patch-2