pfSense

Add quotes around variable usage to prevent word splitting

Always set interface-automatic in unbound config. Fix #13393

PHP8 updates for resolver host editing

Fix PHP syntax in prefixes.php

Fix array_get_path() not returning $default for null-like values. #13446

In array_get_path(), a $default provided that is not null is intended to invoke
alternate behavior where if the path exists and is empty, $default should be
returned. This requires not identical compare as opposed to a not equal compare,...

Fix DDNS GW check PHP error

We need to get the status value from the returned array, not use the
array itself.

Revert "Workaround new pkg(8) behavior causing files with "NULL" in the path to be..."

This reverts commit 8b7ab58088f15bec9f9d5cede5fdcd8e3b9fe10e

PHP8 fixes for service status widget. Fixes #13506

Workaround new pkg(8) behavior causing files with "NULL" in the path to be skipped on install. Fixes #13394.

qinq: use if_vlan rather than netgraph

if_vlan now supports QinQ, so use that rather than netgraph. This is
expected to perform better, removes a subsystem dependency and
simplifies the php code as well.

Note that this is not possible on stable/12.

Remove unused argument from interface_qinq_configure()

$fd is always NULL, so there's no point in having branches for it.

Correct config_path_enabled path in system_generate_nginx_config. #13446

Path corrections to system.inc. Issue #13446

• Corrected single quote strings wwith variable expansion
• Corrected 2-deep paths that were incorrectly pattern replaced to
  array_get_path('foo','bar' instead of array_get_path('foo/bar')

Correct edns config path in system_resolvconf_generate. Issue #13446

Make *_get_path() return $default for empty values. Issue #13446.

When $default is non-null and the path resolves to an empty element, return
$default instead of the value. This allows callers to intentionally ignore empty
values by specifying $default and simplifies the expressions needed to determine...

Fix for system.inc. For #13446

Properly quote variables

No functional change intended

Fix missing ikeid in created ipsec p1. Issue #13446.

When a new or duped p1 is submitted, $p1ent['ikeid'] is an empty string. Prior
to php 8.0, comparing ($p1ent['ikeid'] == 0) for the empty string would yield
true, allowing the code to properly create and assign a new ikeid by calling...

Replace direct config accesses in system.inc. Issue #13446.

Correct service enabled detection

Fix PHP8 issues in rc.openvpn and rc.carp*

Fix services installation only installing the last service of a pkg. Issue #13446.

The original re-fetched the services list from the config at every iteration
over the package's services list when adding services during installation. After
moving to a get/set model for the config, this discarded service added at each...

Introduce config_init_path for config_* family completeness. For #13446

Allow user to select PKCS#12 encryption. Fixes #13257

Convert P12 export to OpenSSL. Fixes #13257

PHP native method of creating PKCS#12 archives does not support using specific algorithms for encryption, so use the openssl binary instead.

Use AES-256 and SHA256 when encrypting the PKCS#12 data and private key.

Fixes some PHP bugs. For #13446

Fix primary console handling for EFI. Fixes #13080

Tested and working for both BIOS and EFI systems.

Skip empty ca/cert/crl tags.

Update external http links

Fix formatting in pkg-utils.inc output

Fix array/config path functions to handle key 0 correctly. Issue #13446

Fix various PHP issues in vpn.inc

Also rewrite the method used to get DNS servers. It's still not perfect
but the old code had several potential problems like sending invalid DNS
servers to clients.

Skip empty DHCP static map entries.

Fix some config access bugs in pkg.php for PHP81. Fixes #13446

Replace all direct $config accesses in pkg-utils.inc. Issue #13446

Replace direct $config accesses in interfaces_vlan_edit.php. Issue #13446

Correct Namecheap parsing failure. Fixes #12816

Better fix that converts the content encoding in case it really is in
the stated encoding, plus a more robust method of dropping the XML
definition entirely in case the first attempt fails.

Skip empty services when installing packages.

Replace all direct $config accesses in interfaces.inc. #13446

Make array/config path funcs handle empty path elements. #13446

Introduce array_init_path, refactor init_config_arr, and fix potential race. For #13446

Cert-related PHP 8.x changes.

Update status_carp.php PHP81 for #13446

Update interfaces_qinq_edit.php PHP81 for #13466

Update interfaces_vlan_edit.php PHP81 for #13466

Fix interfaces_groups_edit.php PHP81 for #13466

More PHP81 fixes for certs.inc

Update is_openvpn_*_ca family for PHP81 for #13446

Fixes some PHP81 related config access issues related to interfaces and interface assignments for #13446

System Identification fixes

add missing '$'

Replace all direct $config accesses in services.inc. Issue #13446

Hide stderr output when the mmcsd0 device does not exist

Test to make sure we have a ZFS partition before trying to run zpool commands

Merge pull request #4612 from zeroflow/master

Rename DHCP status from online/offline to active / idle/offline

Fix checking openvpn client or server config exists. Issue #13446

Fix state limit

Captive portal PHP 8.1 fixes Issue #13446

Correctly count pf eth rule counters. Fix #13418

CP stats fclose fix.

Don't attempt to close unless the open succeeded.

service-utils PHP8.1 fixes. Issue #13446

Fix PHP error building if list. Issue #13446

dhclient pid path fix. Issue #13217

Reconfigure bridges with OpenVPN QinQ interfaces on boot. Fixes #13225

Update pfSense-dark.css

Darken disabled input fields in dark theme. Fix #13390

Add option to list ACB restores in reverse order. Feature #11266

Use certificate trust store when verifying alias URLs. Fix #13367

Remove unnecessary link tag. Fixes #7996

Avoid creating empty ciscoavpair rules files. Fix #13243

Restart gateway monitor on interface re-assign. Issue #12920

Fix syslog remote enable check. Issue #13446

Skip empty gateways on interfaces.php Issue #13446

PHP 8.1 fixups in syslog.inc. Issue #13446

Fix PHP errors. Issue #13446

• Fix error from empty syslog tag in config
• Fix error from empty menu tag in config

Fix missing sprintf format type. Issue #13446

Correct anchors passed to pfSense_pf_cp functions. Fix #13418
Anchors for each client IP address include the CIDR size

Fix PHP error on services_dnsmasq.php. Issue #13446

Fix PHP error on services_unbound.php. Issue #13446

Fix gateway group error from PHP 8.1. Issue #13446

Clean up warnings and errors in pfsense-utils.inc. #13446

• Remove a number of unreferenced variables
• Fix type of output capture variables for exec() calls from string to array
• WakeOnLan() * Fix type warnings calling socket_last_error for a false value socket...

Replace all direct $config accesses in rc.start_packages. #13446

Replace all direct $config accesses in util.inc. #13446

Replace direct $config accesses in pfsense-utils.inc. #13446

Some direct accesses remain due their tight coupling to the management of the
configuration as a whole or are deferred due to their complexity:

• update_alias_names_upon_change()
• reload_interfaces_sync()...

Replace direct accesses to $config in rc.update_urltables. #13446

Correct warnings in authgui.inc. #13446

• Unused variables $user_settings, $g in display_error_form()
• Unused variable $nifty_background in display_login_form()
• Unused variable $cssfile in display_login_form()
  This variable has been deprecated by $logincssfile since e79ff1ee2c0

Replace all direct accesses to $config in authgui.inc. #13446

Correct typo on include of config.lib. #13446

Replace remaining direct accesses to $config in filter.inc. #13446

Remove IPv6 validation for RADIUS auth. Fixes #4154

Rework formatting

Add icons
remove red text for offline
remove bold/italic for both

Add formatting to online status in status_dhcp[v6]_leases.php for better readability. Implements #10345

Adds color & formatting to host online status
online = bold + green
offline = italic + red

Replace another config access in authgui.inc

I ran into this one on a fresh install (amd64/bhyve), CE, on main.

Make array/config_set_path() create intermediary paths

Restore scope to address sent to Net_IPv6::compress now that it is fixed

Replace direct config accessin openvpn.inc

Fix missing format specifier in input field help

Replace direct config accesses in status_graph.php, status_ntpd.php

Correct format specifier in input help