pfSense

Tweaks/fixes for WoL, ticket #5965

Fixup Toggle All button, ticket #5965

Merge pull request #2725 from NewEraCracker/system_certmanager-fixes

Merge pull request #2727 from phil-davis/savebtn

Merge pull request #2726heper:patch-2 from phil-davis/patch-2

Fix $POST checks so they do not depend on string Save

This prevents problems when Save is translated to other languages.
Note: This is the only remaining place I could find with this issue.
There are other pieces of code that do:
```
if ($_POST['save'] == gettext("Save"))...

Use a more clear icon/wording on Diag > Tables button to flush the table. Ticket #5965

Use less confusing button text/colors/icons for Factory defaults/Halt/Reboot. Ticket #5965

Translate the default submit button text

Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text....

HTML Compliance - CARP Status Widget

Error: th start tag in table body.
Warning: A table row was 1 columns wide, which is less than the column count established by the first row (3).

Respect globals_override.inc

Indent system_certmanager.php

The 'csr' code block is duplicated. This commit removes it

Don't exit if the system is booting, should always be unnecessary. related to Ticket #5952

Fix QinQ member save action. Ticket #5965

Fix some Save button quirks. Ticket #5965

change to class for multiple update locations

Merge pull request #2722 from NOYB/Status_Monitoring_-_Settings_Panel_Collapsible

Doesn't seem to be any reason rc.newwanip should skip things while the system is booting. Ticket #5952

More icon and button inconsistencies. Should be the last batch. Ticket #5965

More icon/button inconsistencies. Ticket #5965

More icon/button inconsistencies. Ticket #5965

Make fa-save the default button icon for 'Save' on all forms. Ticket #5965

Advanced button consistency. Ticket #5965

Fix button icons in the package manager. Ticket #5965

More icon and button consistency fixes. Ticket #5965

Add the ability for packages to control their button icon and class. Ticket #5965

Revised disk space display to use progress bar

Make the Notification settings test buttons consistent with other buttons in the GUI. Ticket #5965

Merge pull request #2721 from phil-davis/patch-2

Status Monitoring - Settings Panel Collapsible

Make the status monitoring settings panel collapsible with page load state configurable in general setup associated panels show/hide.
Replace Update button with refresh icon on title bar.

Required by FreeBSD-Ports pull request #78 Status Monitoring - Settings Panel Collapsible.

Improve test for firewall rule advanced setting

You could make some advanced settings, save the firewall rule, then when editing again the advanced section would not be automatically open. That makes it hard for users to realise that a rule has some advanced setting(s)....

Display NAT advanced source settings if defined

On NAT Port Forward Edit, if any of the source port settings are different to the defaults then display the source fields, rather than just the Advanced button.
Otherwise when editing a NAT port forward with source address/port settings, it is not obvious to the user that there are existing source settings "hiding" under the Advanced button.

Add button on pkg needs fa-plus, too. Ticket #5965

Fix CP portal page controls (view, download, reset) for consistency. Ticket #5965

Fix some more stragglers for icon/button consistency. Ticket #5965

Fix icon consistency and some other formatting issues on the LDAP picker. Ticket #5965

Fix typo

Fix voucher regenerate button action.

Fixed 5971

Icon consistency in Repeatable blocks. Ticket #5965

Fix formatting on the UPnP page, fixes #5970

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

log dhcpleases and dhcpleases6 to dhcpd.log. Ticket #5968

Correct reference for 6rd. Ticket #5967

Remove bonus comma

Fix alias import icon visibility, and change to a more relevant icon. Fixes #5963

Changed all selectoraction to"change" instead of "click"

Fixed #5962

Upon further review, use a more clear and related set of icons for CARP status, play-circle (master) and pause-circle (backup). Ticket #5965

Change shortcut bar status icon to bar-chart, the gear/cog purpose was unclear, looked too much like a settings icon. Ticket #5965

Change "internal" representation of CA on CA and CRL list to an icon, and the inuse indicator on CRLs to an icon. Ticket #5965

Add visual indication of negation on Outbound NAT list. Fix static port representation to use an icon with a helpful title. Ticket #5965

Give a visual indication when a port forward has the negation option active (no rdr). Ticket #5965

Correct the text and placement of the disable and nobinat options for 1:1 NAT rules. Fixes #5966

Slight change to CARP status icons, difference between master and backup status was not clear enough. Ticket #5965

Correct some icon usage inconsistencies. Fixes #5965

Clean up the CARP status widget. Fixes #5964

Move Save button on config history settings inside the panel with the other settings. Fixes #5961

Merge pull request #2717 from NOYB/System_/_User_Manager_/_Groups_/_Edit

Merge pull request #2716 from phil-davis/patch-6

Merge pull request #2715 from phil-davis/patch-5

Merge pull request #2714 from phil-davis/actions

Merge pull request #2713 from phil-davis/patch-3

System / User Manager / Groups / Edit

Error: th start tag in table body.

Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).

Change invalid use of $iface in interfaces.php

At this point $iface is an undefined var. So the last test of this "if" statement is useless.
That code fragment was introduced in commit https://github.com/pfsense/pfsense/commit/e4d40f41aafe00353c0069b457a0b1b0d6c20987...

Improve track6-prefix-id handling

1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max
2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range....

Add Actions column heading

to other places where it was missing, for UI consistency.

Add Actions column heading for CRL Manager

To be consistent with everywhere else that has a heading for the Actions column.

System / User Manager / Users / Edit

Warning: A table row was 4 columns wide and exceeded the column count established by the first row (3).

Error: Stray end tag td.

On second though, don't use this class on this particular tag in the WoL widget.

Fix up the formatting of the Wake on LAN widget and change the code style so it isn't a bunch of echos. Fixes #5960

Fix load balancer status widget uptime percentage display. Fixes #5959

Destroy reference after foreach

As recommended at https://secure.php.net/manual/en/control-structures.foreach.php

HTML Compliance - Login Form

Error: Duplicate attribute class.
<div class=alert alert-warning class=hidden id=no_cookies>Your browser must support cookies to login.</div>
Consolidate multiple class attributes.

Error: Attribute autocorrect not allowed on element input at this point....

When listing the network interfaces, print the link state and not the administrative state.

If you are assigning interfaces, remove the existing configuration from old interfaces if any.

This fixes the need for a reboot after changing interface assignment in console.

Merge pull request #2708 from phil-davis/patch-3

Limit widget column to dashboardcolumns

Stops widgets from "going missing" when the user reduces the dashboard columns in System, General Setup.
If the user just lowers dashboard columns to see what happens, then increases it again, the actual column settings are preserved in the config, so the widgets go back where they were. That seems a good thing....

Correct wording of prefer_ipv4 help text

System / User Manager / Groups / Edit / Add Privileges

Not certain that the list needs to be sorted here. Looks like it is already in order. If it does then a valid callback function will need to be accessible.

Error: Non-space characters found without seeing a doctype first. Expected e.g. <!DOCTYPE html>....

fix whitespace

Remove duplicated text/javascript

Add track6 DHCP6 IPs back to interface when applying changes. Ticket #5945

After recreating the VLAN interface, run interface_configure on it if it's assigned and enabled. Ticket #5951

clean up description

Remove help text wrongly copy/pasted from elsewhere.

Update nginx gzip_types. Remove text/html since it's redundant, and add a few others. Particularly useful, json, since status_monitoring.php uses it. Reduces load time on slow connections to about 1/4th of what it is without gzip on json. Ticket #5498

fix dark theme css

Always set ignore_acquire_ts = yes. No need for that in any of our use cases, and it fixes problems like Ticket #4719.

Merge pull request #2705 from NOYB/HTML_Compliance_-_Diagnostics_/_States_/_States

Merge pull request #2703 from phil-davis/patch-2

Re-generate pfSense.pot

HTML Compliance - Diagnostics / States / States

Bad character - after <. Probable cause: Unescaped <. Try escaping it as <.

Merge remote-tracking branch 'upstream/master'

Adjust default parameters to match changes in dpinger

A PD-obtained subnet is always a /64 on the interface, so should be shown as such here in DHCPv6 server. Ticket #3029

Revise explanation and validation of dpinger parameters.

pkg-utils typo in comment

Move NTP access restrictions to their own tab and add the ability to craft custom restrictions for arbitrary networks. Fixes #4463