pfSense

services_captiveportal text changes

No need to set LANG env var here

Whitesapce change

Remove bogus radio button

Fixed #5617
Added ID and style to routing table

Merge pull request #2248 from NOYB/HTML_Compliance_-_Log_Widget

Merge pull request #2247 from NOYB/HTML_Compliance_-_Services_Status_Widget

Merge pull request #2246 from NOYB/HTML_Compliance_-_Interfaces_Widget

Merge pull request #2245 from NOYB/HTML_Compliance_-_System_-_General_Setup

Merge pull request #2244 from NOYB/Consolidate_conv_log_filter_RegEx_Patterns

Merge pull request #2243 from NOYB/Remove_PPTPS

HTML Compliance - Log Widget

The for attribute of the label element must refer to a non-hidden form control.
Added id tag to form control.

HTML Compliance - Services Status Widget

Attribute height not allowed on element select at this point.

The for attribute of the label element must refer to a non-hidden form control.
'<label for="inputPassword3" class="col-sm-3 control-label">Hidden services</label>'...

HTML Compliance - Interfaces Widget

Replace status indicator icon alt tag with title tag.
Add space between td tag and attributes.

HTML Compliance - System - General Setup

Remove placeholder from dns gateway selector.
Close container div tag.

Consolidate conv_log_filter RegEx Patterns

Consolidate common regex patterns.
Use pattern globally in parse functions.

Remove PPTPS from conv_log_filter

Merge pull request #2242 from phil-davis/r011

util.inc syntax error and code style

Line 578 of the previous commit had a bonus ")".
Code style also fixed up.

Merge pull request #2151 from stilez/patch-11

Merge pull request #2152 from stilez/patch-12

Fixed #5617
Table columns corrected

Merge pull request #2241 from BBcan177/patch-3

Add breadcrumb to pkg.php

Fix handling of 0-byte files uploaded to the CP file manager.

Show package dependencies if they exist (on both available package list and installed package list)

Silent accept deinstall and pre-install on rc.packages

Remove /etc/gettytab

Remove unused empty /etc/printcap file

Changed sop icon to fa-stop-circle-o

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Font Awesome updated to v4.5

Remove unhelpful help text

Retire verify_digital_signature() and pubkey.pem

Remove /etc/protocols

Merge pull request #2240 from phil-davis/r010

Code style System Advanced

Obsolete /etc/fbtab

Remove /etc/fbtab

Remove static copy of /etc/services

Code style System Advanced

Merge pull request #2239 from phil-davis/patch-2

Update system_advanced_firewall.php

A few little code style bits
Make the State Timeouts section actually appear (add the section to the form)
The State Timeouts section was trying to do groups of fields, which spread themselves horizontally. That did not fit across a reasonable screen nicely, specially for the 6 different TCP timeouts. So the groups thing is removed and each field is its own input in the section, all vertically below each other....

Merge pull request #2238 from NOYB/Form_Action_Attribute_HTMLSpecialChars

Applying htmlspecialchars on form action attribute causes ampersands to multiply, and also breaks multi-parameter query strings that are delimited with ampersands.

Fixed #5626

Fixed #5626

Revised system to hide the automatically generated "Toggle all" button when not required.
Original system broke with PR to change radio button names.

Merge pull request #2237 from phil-davis/r009

Merge pull request #2236 from phil-davis/patch-2

Merge pull request #2235 from phil-davis/r008

Merge pull request #2234 from phil-davis/r007

Merge pull request #2225 from NOYB/HTML_Compliance_-_Status_-_System_Logs_-_Firewall

Remove placeholder from form select (raw mode filter form).

HTML 5 complaince changes

Code style pkg

pkg_edit curlies

This looks wrong - with the way the curlies were, the custom_php_after_form_command stuff was inside the ($pkg['note'] != "") block.
It looks like these should be 2 independent if statement blocks.

Code style l

Code style g-i

Merge pull request #2233 from phil-davis/patch-4

Adv DHCP Require Options text

Merge pull request #2232 from NOYB/Status_-_System_Logs_-_Sort_Header

Merge pull request #2231 from phil-davis/r006

Merge pull request #2229 from NOYB/Status_-_System_Logs_-_Firewall_-_Sort_Header

Merge pull request #2228 from phil-davis/patch-3

Merge pull request #2227 from phil-davis/patch-2

Conditionally indent the action icon so it doesn't look so out of place in the wider column resulting to accommodate the sort button/icon.

The rule entires still need to wrap.

Status - System Logs - Sort Header

Fix header to not wrap the sort button/icon to the next row.
Add sort capability to the "raw" table.

Remove placeholder from form select (raw mode filter form).

Code style status*

Status - System Logs - Firewall - Sort Header

Fix header to not wrap the sort button/icon to the next row.
Add sort capability to the "raw" table.

globals.inc comment typos

status_gateways remove unused counter

$counter is incremented but never initialized or used
Code style formatting also done around here.

Merge pull request #2226 from NOYB/HTML_Compliance_-_Status_-_System_Logs_-_VPN

Moved global defines to globals.inc

HTML Compliance - Status - System Logs - VPN

Permitted content of p tag is phrasing content.
Form is not a member of phrasing content.

Add gettext() calls to title elements

Correct <th> widths

Remove duplicate defines

Fix vertical alignment of fa icons within buttons

HTML Compliance - Status - System Logs - Firewall

Remove placeholder value from actpass and actblock checkboxes.
Remove alt attribute from i tags.
Replace href i tags with a tags.
Combine a duplicate class section.

Parse package title, splitting into an array delineated by '/'.
So if the package title is "Services/Magic" the $pgtitle will be array("Services", "Magic") and the breadcrumb display will be as expected.

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

Merge pull request #2161 from heper/patch-1

Merge pull request #2211 from NOYB/Status-System_Logs-Firewall-Manage_Log

Move function to fix none existent call.

Status - System Logs - Firewall - Manage Log

Use the same methods of obtaining log file etc. and mimic much of the code that is common with status_logs.php.
(future: factor out common code into shared functions to remove duplication.)

position confirm button better

Merge pull request #2224 from phil-davis/r005

Coe style firewall *

Merge pull request #2223 from phil-davis/patch-4

Text with max-src-conn-rate and max-src-conn-rates fields

I fixed up the text to read the best I could think of.
Actually in 2.2.* these 2 fields were horizontally across the page - so maybe someone can reformat this to look more like on 2.2.* ?

Merge pull request #2218 from NOYB/HTML_Compliance_-_Dashboard

Merge pull request #2217 from NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF

Merge pull request #2216 from NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID

Remove debug

Merge pull request #2215 from NOYB/HTML_Compliance_-_Form_Action_Attribute

Merge pull request #2212 from NOYB/Sys_Log_RegEx_Var_Name_Tweak

Fixed #5638