Bug #13687
closed
Cannot add limiters named ``new``
Added by Kristof Provost almost 4 years ago. Updated about 1 year ago.
100%
Description
When I create a limiter named 'new' via the Traffic Shaper page (firewall_shaper_vinterface.php) with the name 'new' it becomes impossible to create more limiters.
The 'new' limiter is created correctly, and I can add queues to it, but following the 'New Limiter' link (to firewall_shaper_vinterface.php?pipe=new&action=add") shows the new queue page, not the new limiter page.
Files
| new limiter Screenshot from 2022-12-30 17-42-41.png (160 KB) new limiter Screenshot from 2022-12-30 17-42-41.png | Chris W, 12/30/2022 06:44 PM | ||
| new limiter-queue Screenshot from 2022-12-30 17-41-16.png (165 KB) new limiter-queue Screenshot from 2022-12-30 17-41-16.png | Chris W, 12/30/2022 06:44 PM | ||
| clipboard-202309061545-5t690.png (73.4 KB) clipboard-202309061545-5t690.png | Lev Prokofev, 09/06/2023 11:45 AM | ||
| clipboard-202406221846-blbfy.png (43.9 KB) clipboard-202406221846-blbfy.png | dylan mendez, 06/23/2024 12:46 AM | ||
| clipboard-202412281056-zh2wn.png (33 KB) clipboard-202412281056-zh2wn.png | Jordan G, 12/28/2024 04:56 PM |
Updated by Kris Phillips almost 4 years ago
Actions
#1
Confirmed this bug on 23.01. Additionally, if you create a limiter named "new" and then create a queue, if you go and delete the queue it will delete the parent limiter as well.
Updated by Kris Phillips over 3 years ago
Actions
#2
No longer able to reproduce this bug in the Dec 10th builds of 23.01. It appears this may be fixed.
Updated by Chris W over 3 years ago
Actions
#3
- File new limiter-queue Screenshot from 2022-12-30 17-41-16.png new limiter-queue Screenshot from 2022-12-30 17-41-16.png added
- File new limiter Screenshot from 2022-12-30 17-42-41.png new limiter Screenshot from 2022-12-30 17-42-41.png added
Seeing this on build:
23.01-BETA (arm64)
built on Wed Dec 28 03:05:04 UTC 2022
FreeBSD 14.0-CURRENT
I create and save a new limiter named "new". I then use the green New Limiter button to add another, and it give the new queue page. However, if I then created and saved new queue, then deleted that queue, the parent limiter remained.
Updated by Lev Prokofev almost 3 years ago
Actions
#4
Still the issue on the dev build
23.09-DEVELOPMENT (amd64) built on Tue Sep 05 05:55:55 UTC 2023 FreeBSD 14.0-ALPHA2
Updated by Marcos M about 2 years ago
Actions
#5
- Priority changed from Normal to Low
Updated by dylan mendez about 2 years ago
Actions
#6
I can replicate this on CE 2.7.2 and 24.03-RELEASE
Updated by Marcos M over 1 year ago
Actions
#7
- Project changed from pfSense Plus to pfSense
- Subject changed from firewall_shaper_vinterface.php cannot deal with a limiter named 'new' to Cannot add limiters named ``new``
- Category changed from Traffic Shaper (Limiters) to Traffic Shaper (Limiters)
- Status changed from New to In Progress
- Assignee set to Marcos M
- Target version set to 2.8.0
- Affected Plus Version deleted (
23.01) - Plus Target Version set to 25.03
Updated by Marcos M over 1 year ago
Actions
#8
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
Fixed with commit:2b324392cddc24906f1d4dc203089de8d6065439.
Updated by Jordan G over 1 year ago
Actions
#9
with above patch applied, it seems to correct the issue with the green '+ New Limiter' opening a new queue page instead of the new limiter page fields but it does not allow enabling of a limiter named 'new'. Checking enable, saving, applying and then opening the limiter again, no longer shows enabled checked.
Updated by Kris Phillips over 1 year ago
Actions
#10
Tested this on 25.03-DEVELOPMENT builds from today and I was able to enable both a limiter with the name "new" and "new2" at the same time. Also, created a queue below a Limiter called "new3" and all three were able to be enabled at the same time.
Updated by Marcos M over 1 year ago
Actions
#11
- Status changed from Feedback to Resolved
Updated by Jim Pingle about 1 year ago
Actions
#12
- Plus Target Version changed from 25.03 to 25.07
Also available in: Atom