Bug #6864
closed
Error checking rejects IPv6 addresses with upper case A-F.
Added by Steve Wheeler about 8 years ago.
Updated almost 8 years ago.
Affected Architecture:
All
Description
Recent browser changes mean this is rejected before the form is submitted and the error tool tip shown is unhelpful.
Either allowing upper case characters and converting them to lower case to meet the standard or displaying an error that allow the user to make that change would solve this.
Pull request: https://github.com/pfsense/pfsense/pull/3198
That makes the "Please match the requested format:" text more helpful.
It would also be nice to automagically convert to lowercase as the characters are typed or pasted into the field.
While I think it is cool to convert the characters as you type, the GUI has to accept upper case letters as well.
Once the IPv6 address is sanitized, all the IPv6 address in pfSense must use/print only lower case letters.
- Assignee set to Luiz Souza
Take a look at Phil's patch. If it needs rework kick back to either he or I.
Note: The pull request generated discussion about whether users should have the option to record IPv6 addresses with their choice of upper or lower case A-F,a-f, and store it in the config as the user has entered it. Then the back-end code would convert to lower case on the fly when making use of the addresses to drive the system.
Regardless of that, the existing behaviour is requiring that lower case be entered. The pull request simply automates this process and gives some help text to give the user more clue about what to enter. So the PR does not change existing underlying behaviour.
If someone wants to discuss the overall policy of stored format of IPv6 addresses in the config, then fine. But the PR is not about that.
- Status changed from New to Feedback
- % Done changed from 0 to 100
This appears to have broken the use of Aliases that have names using capital letters. See #6918
- Status changed from Feedback to New
- Assignee changed from Luiz Souza to Anonymous
See #6918
A new function has been provided to force IPv6 to lower case on save. This is being added to GUI pages as required
- Status changed from New to Assigned
Force IPv6 to lowercase via addrtolower() has been added to:
firewall_aliases_edit.php
firewall_rules_edit.php
More to come
interfaces.php also has addrtolower()
- Status changed from Assigned to Resolved
- Target version changed from 2.4.0 to 2.3.3
Also available in: Atom
PDF