Bug #6864
closed
Error checking rejects IPv6 addresses with upper case A-F.
100%
Description
Recent browser changes mean this is rejected before the form is submitted and the error tool tip shown is unhelpful.
Either allowing upper case characters and converting them to lower case to meet the standard or displaying an error that allow the user to make that change would solve this.
Updated by Phillip Davis about 8 years ago
Pull request: https://github.com/pfsense/pfsense/pull/3198
That makes the "Please match the requested format:" text more helpful.
It would also be nice to automagically convert to lowercase as the characters are typed or pasted into the field.
Updated by Luiz Souza about 8 years ago
While I think it is cool to convert the characters as you type, the GUI has to accept upper case letters as well.
Once the IPv6 address is sanitized, all the IPv6 address in pfSense must use/print only lower case letters.
Updated by Phillip Davis about 8 years ago
This one also automatically converts the input to lowercase as the user leaves the IP Address field, or presses a button somewhere else (like Save):
https://github.com/pfsense/pfsense/pull/3199
Updated by Jim Thompson about 8 years ago
- Assignee set to Luiz Souza
Take a look at Phil's patch. If it needs rework kick back to either he or I.
Updated by Phillip Davis about 8 years ago
Note: The pull request generated discussion about whether users should have the option to record IPv6 addresses with their choice of upper or lower case A-F,a-f, and store it in the config as the user has entered it. Then the back-end code would convert to lower case on the fly when making use of the addresses to drive the system.
Regardless of that, the existing behaviour is requiring that lower case be entered. The pull request simply automates this process and gives some help text to give the user more clue about what to enter. So the PR does not change existing underlying behaviour.
If someone wants to discuss the overall policy of stored format of IPv6 addresses in the config, then fine. But the PR is not about that.
Updated by Phillip Davis about 8 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 100
Applied in changeset d461ff40e364fc0ecc003b9f673cbad7c6a08f2f.
Updated by Jim Pingle about 8 years ago
This appears to have broken the use of Aliases that have names using capital letters. See #6918
Updated by Renato Botelho about 8 years ago
- Assignee changed from Luiz Souza to Anonymous
Updated by Anonymous about 8 years ago
See #6918
A new function has been provided to force IPv6 to lower case on save. This is being added to GUI pages as required
Updated by Anonymous about 8 years ago
- Status changed from New to Assigned
Force IPv6 to lowercase via addrtolower() has been added to:
firewall_aliases_edit.php
firewall_rules_edit.php
More to come
Updated by Phillip Davis almost 8 years ago
interfaces.php also has addrtolower()
Updated by Anonymous almost 8 years ago
- Status changed from Assigned to Resolved
Updated by Jim Pingle almost 8 years ago
- Target version changed from 2.4.0 to 2.3.3