pfSense

Remove artifacts from latin1 to utf8 conversions

String replacement:

s/Ermal L.../Ermal Luçi/g

Keep verify_all_package_servers() and check_package_server_ssl() around until GUI is finished

xmlrpc is not being used anymore

Keep get_pkg_id() around since a couple of packages are using them

Escape entire command to avoid breaking parameters

ASSUME_ALWAYS_YES is boolean

Drop verify_all_package_servers() verify_package_server() check_package_server_ssl() package_server_ssl_failure_message() and package_server_mismatch_message()

Drop pkg_fetch_config_file() and pkg_fetch_additional_files()

Remove package_skip_tests(), it won't be necessary anymore with pkg

Add a note to implement pkg_reinstall_all later

Rework delete_package_xml() for pkg migration

Fix delete_package for pkg

Modify install_package and install_package_xml to work with new pkg flow

Implement pkg_install()

Remove unused function get_pbi_binaries()

Remove unused function pkg_fetch_recursive()

Do not try to install package since it's already installed at this point

Adjust uninstall_package() for pkg

Remove unnecessary function get_pkg_depends()

Rework sync_package, remove unused parameters, remove sync_depends, sanitize returns

Remove global variables declared but not used

Return a blank array on get_pkg_info for now, will be implemented later when I touch GUI

Remove unused function expand_to_bytes() get_pkg_db() and get_pkg_interfaces_select_source()

Remove unused function does_package_depend()

Remove unecessary function force_remove_package()

Drop is_freebsd_pkg_installed() in favour of is_pkg_installed()

Remove unused function walk_depends()

Remove unused function squash_from_bytes()

Remove unused functions get_pkg_sizes() and get_package_install_size()

Rename get_pkg_id() to get_package_id() and get_pkg_internal_name() to get_package_internal_name(). Try to use more standard parameter names and simplify logic while here

Rename remove_freebsd_package() to pkg_delete() and introduce pkg_remove_prefix() pkg_call() and is_pkg_installed()

Cleanup old and unecessary directory creation

Remove use of obsolete packages tag 'modify_system'

Do not try to add package tabs info to config

Remove broken code that was supposed to add packages tabs entries to
config.xml. Since tag['name'] doesn't exist, it only adds the first item
of first installed package, and in the end this is not used at all since...

Remove obsolete logging code which is duplicated in system_syslogd_start()

Code style for pkg-utils

Rather than set the g['booting'] on globals provide a function to test for that doing the right checks

Fix misspelling

Fix syntax

Log in system log the result of install_package to be able to troubleshoot later on.

Force installation even here.

Make this code do proper checks in all cases

Do not use regex to check filetype to avoid being wrong since . is a regex metachar. It fixes #3817

Move the fetching of a package's config file and additional files to separate functions, and then have the "xml" package button perform these so that it is not only a redundant copy of the "pkg" reinstall button. This can help ensure a package files are in a known-good state before other actions are performed, in case the deinstall would fail or behave erratically due to other files being missing.

use HTTPS for files.pfsense.org for update_bogons and priv_url in pkg-utils

Also check and verify the package server's SSL certificate if using HTTPS. Issue 484
Our current XMLRPC client version doesn't have support on its own to validate this in a way we can use to test in a usable for printing an error message. For now, a cURL query to the XMLRPC URL is used in its place.

More refinements to the unofficial package repository warning ( Issue #484 ) -- Now also shows on Dashboard and installed package list. Cleaned up some code and shuffled things around to avoid unnecessary repetition.

Detect if an unofficial package repository is in use and warn the user. Part of issue #484 (more to go)

Add local/www to the list of directories that needs to be symlink'd to reduce PBI differences between 2.1 and 2.2

Create some symlinks inside pbi dir to reduce differences between 2.1 and 2.2 and avoid the need to change a lot of PBI scripts

Silent pbi_info

Reduce possible noise

Small cleanup

Fix PBI installation when target lies on different directorie

Missed pbi_prefix here

Fix PBI symlink creation and deletion under /usr/local following .pbiopt files, also drop setup_library_paths() since it's not necessary anymore

Get rid of embedded platform. Its time to GC this

replaced uppercase html tags with lowercase
js files saved as UTF-8 / LF
language="JavaScript" deprecated, replaced with type="text/javascript"

Merge branch 'master-br' of https://github.com/ayvis/pfsense into ayvis-master-br

standardize URLs

xhtml Compliance
replaced <br>, <br/> and </br> with <br />

Do not do any operations on system libraries. Nowdays pbis are used and those do not break things by definition

Grab exec result just to be careful

Abort installation when pbi_add fails

Declare $config global so we can test the pkg_nochecksig option

Add support for signed PBI, help ticket #3365:

- Add an option to allow user to accept unsigned packages
- The only missing part is public key, that needs to be added to
/var/db/pbi/keys/pfSense.ssl

escapeshellarg() is not required here

Revert "Set PATH before call pbi related binaries"

This was pushed by mistake

This reverts commit 4c9bda43f5bcfd5ba9812c84199bbe4f1f158960.

Fix some wrong escapeshellarg() calls

Add escapeshellarg() calls on exec parameters. While I'm here, replace some exec() calls by php functions like symlink, copy, unlink, mkdir

Set PATH before call pbi related binaries

Remove arch from fall back url since it's a single dir now

Merge pull request #888 from PiBa-NL/pkg-utils-append-log

pkg-utils do not clear first part of installation log.

pkg-utils do not clear first part of installation log.

Fix FreeBSD version detection for 10.x

Rework the usage of the shell i/o during stop_packages(), fixes the "Syntax error: bad fd number" for the remaining people who still saw it on shutdown

Ticket #3139 try to detect if the popen is closed from an error

Fix interface selections on UPnP to show the customized descriptions entered by the user. While here, add an external interface selection knob. Fixes #3141

Conflicts:

etc/inc/pkg-utils.inc

Be a lot more verbose in the logs during package reinstallation.

Add dynamic category tabs for better listing all available packages

Add version check to package install

Support different package internal name

Allow the package external name (e.g. Ipguard-dev or squid3) to be different from the internal name (ipguard or squid). In particular, this allows package start and stop code to know what the associated package service name and/or *.sh start/stop script name is when the external package name is different.

Change rcfileprefix to a constant

Tidy package cleanup output

Add a "done." and newline after "Cleaning up..."
Then when output is going to the serial console the next line will start cleanly and %age figures will not write over the top of "Clean".

Silence tar command to not garble console

Try to keep existing files rather than unlinking/replacing when restoring the package libraries during a package removal. Needs some testing, but for NanoBSD it fixes #1049

Don't conf_mount_rw every time packages are listed

Every time System:Packages is selected, the code does a conf_mount_rw, checks for existence of some dirs, then does conf_mount_ro. This makes navigating the package install GUI slow on nanobsd, and it is not needed....

make sure this grep parameter is quoted

Setup library paths to include /usr/pbi/*/lib as a last resort to make sure things can find libraries. We may eventually replace this with a better method as this can lead to conflicts, but for now it will allow packages to find their proper libraries.

Restore this code that was accidentally reverted

Remove null character at end of file

Fix trailing whitespace

Don't fall back to fetching PBIs from FreeBSD, they have none.

Move the stop_packages code to a function, and call the function from the shell script, and call the function directly for a reboot. Fixes #2402 and ticket #1564

remove_freebsd_package: check that a symlink exists and is currently pointing into the pbidir of the current package, then unlink it. This avoids possibly deleting real files, or deleting a symlink that points into some other package.
pkg_fetch_recursive: remove a bonus "$" in the symlink target specification. This was causing symlinks from /usr/local/bin to not be generated validly....

Remove an extra "-" left there by accident.

Handle mixed-case package names like squidGuard.
Check that conf files in PBI folders exist before unlink.
Pass correct package names 1 at a time from uninstalll_package to delete_package.
log_error if the PBI package name can't be found in remove_freebsd_package - this means that the PBI files will not get cleaned up. Usually this is caused because the system has been rebooted since the package was installed and the PBI db in /var/db/pbi has gone (e.g. on nanobsd /var is created from scratch at boot)

Fix case where package names are substrings of each other. e.g. "squid" and "squid_radius_auth". Look for "squid-", which will match the full PBI package name for squid but will not match "squid_radius_auth". Bug #2301

The function split() is replaced by the function explode(). Starting with PHP 5.3 this is deprecated and with version 6 gone.
Replacing it surpresses all the warnings

Trim filename before use to clear away any unnecessary whitespace. Fixes client export package install (and probably others)