Check if an item is an array before treating it as such in the upgrade code.
Add proper checks in auth code for testing if the section has been set in the config. Also do the same in the ugprade code
In upgrade code for server load balancing, set redirect_mode. Also in the backend code, assume redirect_mode as the default if it's not set.
Fix off-by-one in OpenVPN "local" to "ipaddr" conversion.
Add LB monitor types to config during upgrade, or they will be missing from boxes upgraded from 1.2.3.
Upgrade sync username to latest config version.
Rather make use of $global variable for RRD path.
Remove out-dated RRD file as it will cause broken images to appear on RRD graphs page.
When converting 1.2.3 LB pools to 2.0 gateway groups, strip invalid characters from the group names and update any rules referencing the old name. Fixes #1515
Fix PPTP server radius settings upgrade from 1.2.3. Fixes #1292
Remove rndtest sysctl since the kernel module is not anymore part of our kernels. Leftover noticed by: Jim
Fix PPPoE upgrade, the <pppoe> tag is considered an array these days and the upgrade code wasn't treating it properly, accessing it directly instead of using the first entry ([0]). Fixes #1439 - PPPoE credentials upgrade properly now.
CRL is read in as an array now, so even in the imported config it will appear to be an array even though it can only have one value. Fixes #1358
Check for "aes 256" as IPsec encryption type, not just rijndael.
Add some upgrade code for IPsec mobile clients. Passes php -l but needs more testing.
Keep a table of gateways we added for static routes to prevent us from making multiple entries to the same IP address
Only change protocol if it's set and not empty.
Add upgrade code to ensure rule protocols are all lower case.
Fix admins group permission setting when upgrading from 1.2.3.
Correct IPsec carp interface upgrade code, off by one
Use full path to pw
Add missing _relayd group, and when upgrading from 1.2.3, add _relayd group and user.
Correct the vlan upgrade code to continue when we fixed up the interface
Correct the config path to the vip array
Attempted fix that should convert the old carp[$i] naming to vip[$vhid]
Make sure we iterate by the vlan number lest we end up with a empty variable? Hopefully fix new vlan name not being assigned to interfaces section
Correct the gateway group member name to the correct GW_". strtoupper($if) uppercase. This fixes outbound load balancer pools upgraded from 1.2.3not working
Do not rely on php new foreach by reference and use the old method of chaning array members by using full path. This fixes nat 1:1 upgrades.
Add the cron job a different way. There have been a couple reports of losing CAs during the config upgrade and this was the only added function at the time.
Bump config version, add upgrade code to setup cron job for URL table update script.
Ticket #491. Correct username/password name fields so upgrade works correctly.
Forgot to up the array count.
Add kern.ipc.maxsockbuf to upgrade config and remove extra whitespace.
Instead of replacing the whole array just add the new vlanif member to the config. Should fix issues reported in http://forum.pfsense.org/index.php/topic,28202.15.html
nuke trailing carriage returns
Ticket #491. Do not actually check for enable to exist but for host since enable might be unset explicitly by the user. This should re-enable configs to work.
Store upgraded monitor IPs in gateway items, not accidentally as bogus interfaces. This was causing some configs to upgrade and then get stuck in a reassignment loop after the next reboot.
Make the RRD path if it doesn't yet exist at this point.
Remove hw.bce.tso_enable item it is loader.conf only per jimp
Some fixes for the upgrade code for captive portal users.
Remove the old field even if empty in rename_field.
Remove trailing carriage return
Do some is_array() testing before renaming fields, otherwise empty variables can be accidentally created.
Mark this entry as an array before treating it as such otherwise php complains.
Check to see if it is not an array first - as per jim-p on IRC.
Fix crl upgrade code.
Add upgrade code for importing CRLs. Ticket #555
Rename 'name' to 'descr' for CA, Certificates, and CRLs, to gain CDATA protection and standardize field names. Ticket #320.
Generalize this function and use it in more places to reduce duplicated code.
Convert fullname field on users to descr, so it gains CDATA protection.
desc to descr in Load Balancer config, so they gain CDATA protection and standardize field names. Ticket #320.
Change the description field on sysctl tunables to be 'descr' and not 'desc' so they will gain CDATA protection. Ticket #320
Use proper matching because the command might contain nice in it.
Do not run anymore the cron job for monitoring check_reload_status since it has a monitoring process that does this through kqueue.
We want to upgrade all of interfaces/gateways.
Better initialize this.
Add upgrade code for NAT 1:1 rules and bump config version.
Base64 encode passowrd fields for safer operations. Suggested-by: Efonne(IRC)
Upgrade user data too for new pppoe world.
Correct function name. Pointy-hat: jimp@
Upgrade code to merge user certificates with normal certificates.
Upgrade code for pppoe.
Moving certs and ca out from under system. Provide upgrade code to move existing certs.
Ticket #482. This solves point 3) which converts the custom 'local IP' directive to the 2.0 format.
Ticket #769. Convert assigned openvpn interfaces by using custom options to 2.0 style assigned openvpn interfaces. This upgrade removes the 'dev tun#' from cutom options and upgrades the assigned interface name to new style.
Make dhcrelay GUI be simple and easy to use by collapsing the interface tabs to a multiselect control. Remove proxydhcp option because it is broken and is not trivial to make it usable(if user request for it a reconsideration will be made). Allow multiple server ips on the server input box separated by commas. Also on the interface list do not show interfaces without an ip because dhcrelay will not be happy with them. Upgrade code is also included in this commit.
Disable TSO and LRO in upgraded configs.
Do not use a monitor address from a load balancer pool as the monitor IP for a connection. This can lead to incorrect configurations. Some 1.2configurations use load balancer pools as a subtitute for a gateway since that option was not available then.
Invert the is_array() check as this incorrectly unsets the gateway array leaving the system unreachable
Follow the restored username as the logged in user when upgrading a config. Otherwise you can get access errors if you need to do an interface reassignment.
Only output these messages when booting.
Change this find to a chdir/glob.
Fix the RFC dns updates config upgrade. It would blow up on an incomplete/invalid config.
Fixes #480. Correctly upgrade config for monitorip. When a gateway exists save there the monitorip instead of the interface.
Include rrd.inc if dump_rrd_to_xml() is not found to be included to avoid Fatal error: Call to undefined function dump_rrd_to_xml() in /etc/inc/upgrade_config.inc on line 1752
Fix up upgrade function for new PPPs implementation.
Fix up for new ptpid scheme and iface name scheme.
Fix all issues that Ermal found.
Interfaces.php problems.1- When creating a pppoe ptpid on the config is empty(<<ptpid/>).2- after switching from pppoe to pptp in the config there remainspppoe-reset-type which is not that much of a bug but needs to be...
Merge branch 'master' of http://gitweb.pfsense.org/pfsense/mainline into mlppp
Do not set max_execution time here.
Fix upgrade code for disable bit on OpenVPN CSC entries.
Update upgrade_config to remove 'defaultgw' from <ppp> config sections
Fix many things related to PPP connections.
Fixed tab array numbering in interfaces_* files. Enabled multilink over PPtP connections.Fixed handling of bandwidth, mtu, mru settings. Removed unnecessary curly brackets fromsingle line if conditionals, and more . . .
PPPoE config upgrade code and bump config version in globals.inc
Fix OpenVPN upgrade code to properly handle the disable option. Fixes item 1a (and probably 1b) in #482 and should be the rest of the fix for #449.
Move RRD quality databases to reflect the gateway name instead of the interface name. This should prevent a flurry of duplicate butunused RRD files on 2.0 where we use the gateway names for the RRD file. Fix ticket #354
Prevent empry dyndns array items on config upgrade ticket #491
Unbreak the switch statement, pointy hat to me
Correct the function name so that it upgrades properly
Make sure to upgrade deprecated themes to pfsense_ng.The switch() should make it easy to add other deprecated themes here.
Do not put ip address on teh name since pfctl does not like an ip as part of macro name.
Ticket #408. Provide code to upgrade static routes.
Fix upgrade code for port forwards with "Interface address" set on external address. Ticket #561
Fix the empty array check, a empty load balancer tag has a value of 1, not 0.
Do not trip with configuration upgrades on a empty load balancer tag.
Ticket #491. Fix upgrade code. Since dyndns is considered and array item it failed with previous code. Use index of 0 since 1.2.x does not have multiple entries.
Add upgrade code for values of "Interface address" and "any" for the external address of port forwards. Ticket #561
Improve NAT Port Forwarding
Fix OpenVPN upgrade code for lzo compression. Resolves #280, mentioned also in Ticket #482.
Fix apparent typo in IPsec upgrade code which broke the user_fqdn identity type.