Code style and comments
No functional change - just making style consistent
Fix typo, LT2P->L2TP
Move to Apache License 2.0
Review license / copyright on all files (1st round)
Leave an empty file for URL Table aliases that return an empty file, and include it in the ruleset regardless so it doesn't generate any filter errors. Ticket #6181
Protect get_dir from causing PHP errors
https://forum.pfsense.org/index.php?topic=114570.0
Merge pull request #3018 from phil-davis/usersettings
Update include() to include_once()
For safety, use include_once() when including various "side" files.There are a couple of instances of include("guiconfig,inc") that Ichanges to use require_once() to be consistent with everywhere else.The remaining cases of include() are just (hundreds of) head.inc and...
Move iso_3166-1_list_en.xml to /usr/local/share/pfSense
Feature #6388 custom GUI preference settings per user
Merge pull request #2988 from stilez/patch-28
Add a check to see if the file exists before running filesize on it, to avoid PHP error.
Move terminal config from cons25 to xterm, same used by FreeBSD
Change serial terminal type to vt100, same FreeBSD uses
missing "("
optional arg for old behaviour
Simplify convert_seconds_to_hms() and show days for large numbers of hours
1) Function can be simplified and all "if" statements removed, using intdiv (or casting result as int for PHP < 7) and % for calcs and sprintf for padding.2) Input validity check before trying to convert format...
Fix the autologin on serial console for ARM.
Change serial console to '3wire' and vt100.
Fixes the console on ARM.
Fix this missed one.
Firewall / Aliases / Edit - New URL Table Alias Type
Make the code cleaner and easier to follow by using the same alias type designations as config.
Need to pass alias type to process_alias_urltable() function when creating a new url table alias because it is not yet set/available from config. So the alias_get_type() function can't be successfully used yet.
Alias Tables RAM Disk Store
If ramdisk is enabled keep a copy of the alias tables to restore at boot time. Otherwise unpredictable behavior may occur due to some aliases not being available when the firewall rules load.
Because alias tables are typically somewhat static, the following strategies are employed to keep write cycles to a minimum for SSD and flash drive type devices friendliness....
Don't try to put the file contents in place if file is empty. Ticket #5982
Diagnostics / Tables - URL Table Aliases
Handle URL table aliases similar to bogons tables. Suppress record remove buttons.Update (download) only the selected URL table alias instead of all of them.Retain full line comments in downloaded URL table files so we can view and use them....
Ticket #3029
Fix DHCPv6 GUI to work with PD length != 64
Teach merge_ipv6_delegated_prefix() to deal with other PD sizes
Import patch from @Robert-Nelson to enable DHCPv6 Server/RA tointerfaces configured to track DHCP-PD
This patch only works for PD with length 64
Internationalize etc inc i through s
Sync RCC detection with RELENG_2_2
Simplify and correct the comments in get_carp_interface_status().
This seems to have negatively impacted LAGG/VLAN configs. Revert "Only set IFCAPS where they're not already set correctly. Ticket #5887"
This reverts commit 7f283fab1b18bb575537bb8498b16a6b1b6d0251.
Fix the returned string when no status is found for this CARP.
No functional change.
Only set IFCAPS where they're not already set correctly. Ticket #5887
If URL table file size is 0, force update. Ticket #5848
add an option to only validate URL tables, so stray files aren't left behind when input validation fails. Ticket #5848
Parse URL Table alias downloads with parse_aliases_file to ensure only valid contents. Ticket #5848
Remove process_alias_unzip, which never worked because of variable typo (at a minimum) and wasn't documented as an available feature so people don't expect to be able to use it.
Return false if download fails in process_alias_urltable so input validation based upon it works. Ticket #5848
Match this to max_input_vars for large aliases
Correct variable in error log
Don't try to process aliases whose downloads have failed in update_alias_url_data(). Ticket #5848
Sync up download_file_with_progress_bar with download_file. The former is no longer used in the base system, but still in some packages.
Review of CARP uniqid changes.
It turns out that current CARP implementation is not much different from an IP alias.
This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...
Return false in download_file rather than the failed status code when a download fails. Return would always evaluate to true previously though other parts of the code expect a false value when a download fails. related to Ticket #5848
Remove attributions of return code not being used at all
Fix #5690:
- Remove parameters from set_language()- Add a global variable for default language- add env var for LANG, otherwise it won't work
Update license on files from /etc/inc
HTML Compliance - System / Advanced / Firewall and NAT
Bad value 200000↩ for attribute placeholder on element input: Line feed not allowed.<input class="form-control" name="maximumtableentries" id="maximumtableentries" type="text" placeholder="200000↩">...
No need to set LANG env var here
Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used
Remove dead code, we only have UTF-8 today
Update pfsense-utils.inc
When installing packages, an extra line break is added by the "\r" ... echo "\r{$status}";The $status string typically contain a trailing "\n" as required. This allows to print a message in two steps.
Writing configuration... done....
Code style and white space in etc
Fixed #5532
Mistake in "pfsense-utils.inc"
Sorry, missed a semi-colon!
Type up SCRIPT tags
Fix get_carp_interface_status() to work with uniqid notation and also, verify the CARP vhid and not only the interface (when you have more than one CARP IP on the same interface). Ticket #4858
Make is_ipaddr_configured() work with CARP.
Check against the correct variable. Ticket #4858
netstat is not being used here
Use new host_uuid option name when changing User-Agent
Remove unused function http_post()
pfsense-utils.inc - use full paths to executables
Change update_status to only print on console
Cleanup unused code:
- Remove xmlrpcbaseurl from globals- Remove xmlrpcpath from globals- Remove embeddedbootupslice from globals- Remove call_pfsense_method()- Remove check_firmware_version()- Remove get_active_xml_rpc_base_url()- Remove zeromq.inc...
Use product_name global variable in more places
White space and minor bits in etc
Cleaner version of https://github.com/pfsense/pfsense/pull/1846
Retire PPTP server, fixes #4226:
- Remove PPTP server and all related code- Bump config version 12.2- Write upgrade config code to remove pptpd section and also cleanup firewall and NAT rules using PPTP interface or src/des
Merge pull request #1848 from phil-davis/bootstrap-review
Merge branch 'master' into bootstrap
Integrate bootstrap etc/inc with master
This applies the little changes in etc/inc master to the bootstrapbranch so that etc/inc in bootstrap will now just have the realdifferences that are due to real bootstrap changes.
Merge pull request #1826 from phil-davis/v10-bigger-than-v9
Obsolete use of /etc/nano_use_vga.txt, Use enableserial_force flag instead
Redmine #4925 Fix version comparison to know 10 is bigger than 9
This rtrim of ".0" is stripping any "0" from the end of the passed-inversion strings. That makes "2.3.10" become "2.3.1" which then removesany chance of the following nice comparison logic working....
Move main pfSense content to src/