pfSense

Code style and comments

No functional change - just making style consistent

Merge pull request #3099 from NewEraCracker/patch-3

Fix typo leading to syntax error

Protect package_reinstall_all()

If one restores a config.xml without packages, there will be a warning about invalid argument supplied for foreach(). This commit fixes the problem.

Ticket #3734: Retire growl.class

Ticket #3734: Convert growl related code to use pear-Net_Growl port

Pass along send_smtp_message() return, otherwise message will not be shown when testing SMTP settings

Ticket #3734:

- Added timeout parameter for SMTP configuration
- Removed STARTTLS option, it's enabled automatically by pear-Mail when
server supports it

Ticket #3734: Retire smtp.inc, sasl.inc and *sasl_client.inc in favor of pear-Mail port

Ticket #3734: Convert notify_via_smtp() to use pear-Mail

Ticket #3734: Retire PEAR.inc and use PEAR.php from ports

Ticket #3734: Replace etc/inc/IPv6.inc by pear-Net_IPv6 port

Remove copy of pear-Crypt_CHAP from repo and use ports

Text typo

Noted by Daryl Morse in comment on Redmine bug 6637.

Verify if interface is active gw for gw group before update dynamic DNS

Merge pull request #3082 from philipsoeberg/fix-redundant-http-user-agent-string

Merge pull request #3086 from jlduran/ignore-bootp-queries

Merge pull request #3089 from NOYB/NAT_Delete_Associated_Firewall_Separators

Merge pull request #3088 from phil-davis/widgetconfig

Update firewall rules separators when NAT associated rule is deleted.

Bug: https://redmine.pfsense.org/issues/6676

Fix typo, LT2P->L2TP

Save widget settings per user

For users that have "custom settings" enabled, save the "tool" settings
of their widgets on a per-user basis.
User that do not have "custom settings" enabled will continue to use and
save widget settings to/from the system-wide settings.

Merge pull request #3077 from dhoffend/ticket-6505-fix

Remove '-x' flag from dhcpwithoutra launch of dhcp6c

This is the equivalent fix for the RELENG_2_3 branch to pull request #3078

Merge pull request #3062 from phil-davis/patch-1

Some small improvements to OpenVPN server handling when using CARP VIPs in Gateway Groups. Might help with issue #6607

services_dhcp: Ignore BOOTP queries

BOOTP leases do not have a maximum lease time by default, this could
potentially lead to a DHCP address pool exhaustion.

This commit adds an option to ignore BOOTP queries.

Redmine #4351

Fix a redundant HTTP "User-Agent" string.

CURLOPT_USERAGENT expect the value to the user-agent string, not the entire key-value pair.
Before this fix, HTTP header "User-Agent: User-Agent: phpDynDNS/0.7" was sent for DDNS updates.
NGINX configuration at GratisDNS will not accept a user-agent formatted in the above way....

Increase filtering tail limit for logging, fixes #6652

Whitespace fixes

dpinger: fixed check for pidfile length #6505

openvpn_add_dhcpopts already sets redirect-gateway, don't add it a second time. Ticket #6633

Formatting tidy of interfaces.inc

After #3055

Set HTTP_PROXY to empty as recommended at https://httpoxy.org/#fix-now

Allow section header to be omitted by specifying "NOTITLE" as the section title.

Fixed #6437

Allow AES-GCM for P1 where using IKEv2. Ticket #5990

Merge pull request #3061 from thoughtpolice/cloudflarev6

Merge pull request #3055 from marjohn56/master

dyndns: add IPv6 support for CloudFlare

Signed-off-by: Austin Seipp <aseipp@pobox.com>

Move to Apache License 2.0

Make a function to resync all OpenVPN CSCs and use it when saving an OpenVPN server. Fixes #6139

Review license / copyright on all files (final round)

Set dhcp-cache-threshold to 0 to avoid a bug in dhcpd 4.3.x where it omits client-hostname where the cache threshold is reached. Ticket #6589

Bring back the "set iface route default" used in 2.2.6 and earlier versions, which works around the root problem in Ticket #6495

Review license / copyright on all files (1st round)

Merge pull request #3057 from wokis/master

Added and modified functions to send correct Radius attributes to the Radius authenticator.

Merge pull request #3020 from shieldwed/Allow_comma_in_DHCP_option_string

Merge pull request #2847 from jazzl0ver/patch-1

Merge pull request #2966 from scipiojr/master

Merge pull request #3007 from stilez/patch-34

Merge pull request #2905 from Chrisc-c-c/LAGG-MTU

Add upgrade code to clean up the old GRE/GIF flags that are no longer used. Ticket #6586 and Ticket #6587

Align GIF link options with those currently supported by the base OS. Ticket #6587

Remove GRE link flag options from GUI/backend. Keep link1 as it was also used to add an explicit static route, though the GUI previous GUI option name wasn't related to that at all. Updated GUI description to match reality. Ticket #6586

Merge pull request #3032 from NewEraCracker/patch-pppoe-rules

Properly follow style guidelines.

DHCP6 init before RA

Some ISP BNG's require that a dhcp6c init is sent before RA. The
additions to interfaces.php adds a new option flag 'dhcp6withoutra',
this flag is set or unset in the WAN DHCP6 section 'Do not wait for a
RA'.

The interfaces.inc file handles this flag and either launches dhcp6c on...

Include ignored DHCP server(s) config option even when advanced DHCP config is enabled

Remove workaround for Ticket #4754 in 2.4 since 32 bit is dead.

Add config option for AdvDefaultLifetime, clean up descriptions on other. Ticket #6533

Add configuration for Min and MaxRtrAdvInterval. Ticket #6533

Merge pull request #3037 from NOYB/Check_IP_Services

Exclude non-qualified hostnames from hosts file. Ticket #6064

Omit non-qualified hostnames from unbound's local-data. Ticket #6064

Verify a valid IPv6 subnet is going to be used before including in radvd's config. Ticket #6581

Missing closing quote

Create /var/run/dmesg.boot symlink for vm-bhyve (Feature #6573)

See https://redmine.pfsense.org/issues/6573

Add missing -R parameter to pkg call

Leave an empty file for URL Table aliases that return an empty file, and include it in the ruleset regardless so it doesn't generate any filter errors. Ticket #6181

Protect get_dir from causing PHP errors

https://forum.pfsense.org/index.php?topic=114570.0

spdns.de renamed to spdyn.de

Forgot to update the select description and values

spdns.de renamed to spdyn.de

The service renamed there addresses

Check IP Services

Configurable check IP services.
Used by Dynamic DNS services to check IP addresses.
Configure as many check IP services as desired. The first (highest in the list) that is enabled will be used as the default.
A future possibility could be to add an option to the Dynamic DNS entires to use a specific check IP service....

Fix firewall rules for PPPoE server

1) PPPoE Clients are located within 'Remote Address Range' (sa) and not Server Address (ip), see lines 1194 and 1195. 2) Interfaces for floating rules were not being correctly added due to a bug on interface detection caused by PPPoE differences....

Merge pull request #2764 from NewEraCracker/redmine-6011

Merge pull request #2994 from stilez/patch-31

Merge pull request #3018 from phil-davis/usersettings

Handle more invalid IPv6 formats

Merge pull request #2934 from k-paulius/patch-14

Merge pull request #2944 from stilez/patch-23

Merge pull request #3024 from phil-davis/include_once

Shorten gwifip if whole socket path exceeds 100 chars

dpinger stopps with an error when the socketname exceeds over
(around) 100 characters. The dpinger will not start and not deliver
monitoring results to the WebUI.

These long socket names can get created when using link-local addresses...

Use a different delimiter for dpinger socket names

Currently underscores are used to seperate gwifip, monitorip, etc, but
underscors are also used in vlan subinterfaces like em0_vlan10 and
therefore can't be used because the interface scope is appended to IPv6...

Set pipe_slot_limit to the maximum configured qlimit value. Move the set_sysctl out if the block where it only gets run if dummynet isn't already loaded. Ticket #6553

Clean up limiter text. Remove old commented out bit.

Fix matching of chars in IPv6 address segments

The existing regex here is wrong, it matches 0 or more of the hex digits but then there can be other rubbish in the string, in fact anything at all! It matches "az", "z", "qwerty" and so on. So the "return false" inside this "if" never happens....

Update include() to include_once()

For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and...

Merge pull request #3022 from phil-davis/require_once

Run generate-privdefs.php to update priv.defs.inc

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

simplify DHCP_Config_Option_Split, no loop needed for returning option array

bring back subnetv4_expand function used by pfblockerng

Merge pull request #3013 from dennypage/master

Include interface scope on IPv6 static routes to link local gateway IPs. Ticket #6506

Revert "adding privileges and separating DNS Resolver overrides from general settings"

This reverts commit fc76a1e390c8ce9579df31457c74d1d0e572b78d.

Move iso_3166-1_list_en.xml to /usr/local/share/pfSense

Move athctrl.sh to /usr/local/sbin

Feature #6388 custom GUI preference settings per user