pfSense

FW rule GW status popup improvements. Fixes #14327

• Fix status check to account for current gw status/substatus strings
• Include Tier for gateway groups
• Sort groups by tier and then name
• Fix interface name printout
• Optimize interface name and gw address display to avoid multiple...

Update copyright years to include 2023

Don't load CSRF timeout from config. Fixes #13757

This allows us to reorder includes so that authgui.inc can load auth.inc first, which fixes several auth mechanisms that rely on this order for GUI pages.

Revert "Correct includes/load order in guiconfig.inc. Fixes #13757"

This reverts commit 2a24c162e0a8e69d176c54b5a7be09b23cb233f8.

Correct includes/load order in guiconfig.inc. Fixes #13757

The recent change here ended up loading some things out of order.

Rector direct global g accesses

Spelling fixes. Fix #13357

• Incorrect input validation for `dhcp6c` `keyinfo expire` `forever` keyword in `interfaces.inc`.
• Incorrect input validation for associated rule's `Source Port` in `firewall_rules_edit.php`.
• Incorrect `voucher*.` file lock reference in `status_captiveportal_voucher_rolls.php`....

Add config and config lib requires to guionfig.inc

Fix warnings in guiconfig.inc, unexpanded string in get_config_path call

Replace config array accesses in guiconfig.inc

Encode alias URL before display. Fixes #13060

Update the Copyright year of the files owned by Rubicon/Netgate.

Gateway/Group link fix on the firewall rules page. Issue #12555

Gateway / Gateway group edit on the firewall rules page. Implements #12555

Cache gw status for rules. Fixes #12174

Don't fetch a new gateway status for every rule. Fetch it once and use
it for the entire page load.

Revise firewall_nat_edit for MVC

Update the Copyright year.

A subsequent commit will deal with .po's.

Nested alias IDN fix. Issue #10968

Gateway group popover fix. Issue #10948

Revised fix 10945 to include gateway popup

Fixed #10945
By adding the HTML elements used in pfSense popovers to the default sanitizer whitelist

Improve gateways popup. Implements #885

Show gateway/group IPs on mouseover. Implements #885

Alias IDN hostnames support. Issue #7255

Merge pull request #4116 from Augustin-FL/ldap

Update SSL refs to SSL/TLS. Fixes #10172

Add a few more common ports to list. Fixes #10166

This is 2020. Issue #9245

Merge pull request #4098 from vktg/delzombiealiases

Add option to disallow unauthenticated LDAP binds

Update guiconfig.inc

Create custom CSRF Error page. Implements #9799

• Use formatting consistent with other GUI pages
• Warns the user about potential dangers of submitting form data

Move log-related functions to their own file. Issue #8350

Also add a simple shell program that will dump all log entries for a given
log + all rotated/compressed logs in order.

Add log compression type option. Issue #9711

Change logging to plain text, deprecate clog. Issue #8350

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Use only sshguard table for blocking ssh/gui attacks. Issue #9223

Add validation and encoding to various firewall advanced values. Issue #9294

Update copyright notices to 2019. Happy New Year

Unify and improve crash report checking. Fixes #8915

Fix #7694: Replace sshlockout_pf by sshguard

Fix extra braces

Fixed #8838

PHP7 - Resolve count() warning

Correct pconfig_to_address() so its logic matches the input validation used for checking port numbers. Fixes #8410

Fix case where $_POST['if'] == 0 in sprint_info_box()

fix log link

Update the Copyright notice for pfSense.

Prevent Clickjacking in CSRF error page

Fixed an issue where it was showing the escaped apostrophes on all info boxes. This will fix the issue of the javascript getting terminated in the ipsec status page in french. and not print it to the user

Fixed #8043 It didn't like one of the french characters being saved in the config so it would rollback the config and not allow you to enable mobile clients. Added an html entities to replace it with safe characters. Also added some escapes when it tried to print certain words using a ['] and terminating a string in javascript for the ipsec_status page. This is a possibly a potential problem for multiple pages in French.

Fixed #7889
Increase max number of characters allowed in a tab array to 256 to prevent automatic conversion to pull-down

Allow customize of dashboard widget names

Merge pull request #3698 from phil-davis/patch-5

Do input validation on the actual array passed in

I was tearing my hair out for a while. If do_input_validation() is passed some array of keys/values that has been assembled elsewhere (not $_POST, $_GET or $_REQUEST superglobals) then it does not work. The code here, for at least the last 7 years, has actually been checking the array keys in the "hard-coded" superglobals. That is a bit surprising, since the array to be checked is passed in as $postdata parameter.

Refactor get_configured_interface_with_descr remove unused parameter

Merge pull request #3598 from PiBa-NL/phpsessionmanager

load package add-on tabs into config to avoid parsing all installed package xml's, fix tabgroup filter

Redmine #7381 Disable detail in alias popup

phpsessionmanager, this helps starting and committing the php session preventing other requests from being blocked longer than required.

Redmine #7301 Put dot after the word break

Signed-off-by: Phil Davis <phil.davis@inf.org>

Redmine #7301 Provide word-break opportunity for dynamic DNS host names

Signed-off-by: Phil Davis <phil.davis@inf.org>

Do POST for long tab array dropdown

GET/POST conversion firewall_rules
guiconfig.php display_top_tabs supports "usepost" as an optional 4th argument

user/local/www inc file gettext improvements

Code with multiple %s in usr/local/www

Standardize rules reloading message

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Add protocol selection to Radius server configuration

It should fix #7111

Submitted by @ubawurinna at https://github.com/pfsense/pfsense/pull/2687

Merge pull request #3343 from phil-davis/retval1

Breadcrumb links

Breadcrumb links support

Remove unusued $heading in genhtmltitle()

It came into use in https://github.com/pfsense/pfsense/commit/45eebe10a93fa1e2399c6cdf133ad88dc21ee6e7 but genhtmltitle() has changed since then and no longer uses $heading

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Be more forthcoming with errors about ALTQ interfaces in relevant areas of the GUI. In particular, note when there are no capable interfaces assigned. Implements #7032

Added STARTTLS to LDAP Auth Server Config

Declare $config as a global in guiconfig.inc csrf_startup() function, to properly respect the timeouts. Ticket #6803

Move copyright from ESF to Netgate

Move to Apache License 2.0

Review license / copyright on all files (final round)

Update include() to include_once()

For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and...

Make rule_columns_with_alias end params optional

Stops PHP warnings like reported in forum https://forum.pfsense.org/index.php?topic=111768.0

Add alias display to target host and target port columns

Fixes corrupted display when special chars appear in the alias

guiconfig monitor filter reload message

More icon and button inconsistencies. Should be the last batch. Ticket #5965

print_callout class setting

The last test here looks not good having just a single equals sign - if the interpreter evaluates this then $class will always get set to 'info'.
In practice it should work OK, because the evaluation of boolean conditions left to right should stop when any of the other tests to the left evaluates false. So $class will only be set to 'info' if it is not already 'default' 'danger' or 'warning'....

Merge branch 'patch-9' of https://github.com/k-paulius/pfsense

• 'patch-9' of https://github.com/k-paulius/pfsense:
  Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Add support for Bootstrap callouts

Stop generating page-header instead of hiding it. With breadcrumbs introduces it no longer serves any useful purpose.

Review alert wording.

Fix RADIUS spelling. It is written in all caps.

Tidy print_info_box comments

Added some some comments to hte print_info_box area so package developers will know what happeded

Remove print_info_box_np

Put the real code into print_info_box, adding just a $btntext parameter
to the existing 3 params of print_info_box.
Change the remaining print_info_box_np() calls to use print_info_box()

Note: The previous code also had a "bug" - the "apply" button said...

Restore code from bad merge

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Replaced jQuery to $ in same files

Move set_language() call back to guiconfig.inc since it's causing trouble on console

Be more flexible on detecting the need for the Apply button

This is the quick fix part (1) for https://redmine.pfsense.org/issues/5794