pfSense

Merge pull request #3862 from marjohn56/pfsense

Update the Copyright notice for pfSense.

Revert "Fix a bug in interfaces.php that will cause a failure on first 'Save' of 'OPT1' with some hardware configurations."

This reverts commit 373513a56140215c93282252186a938b7cefcf47.

Merge pull request #3797 from IknowJoseph/patch-1

Fix a bug in interfaces.php that will cause a failure on first 'Save' of 'OPT1' with some hardware configurations.

Set VLAN Priority on dhcp6c packets

Check the correct variable.

All the IPv6 verification code block was being ignored before this commit.

Ticket #8024

Change the VLAN inteface names to use the 'dotted' format of FreeBSD, which is shorter and helps to keep the interface name smaller than the limit (16).

This fixes the 4 digit VLAN issues when the NIC name is 6 bytes long.

Ticket #294

Update interfaces.php

Updated as per style guidelines (??) I'm new here, please say if still not right!

Update interfaces.php

Updated description of "System / Advanced / Firewall & NAT settings"

Merge pull request #3761 from marjohn56/master

dhcp6c Advanced Config prefix interface

Currently, when using dhcp6c advanced configuration the prefix interface is WAN, this is not very useful!

The changes here allow the user to select the interface that the PD will be applied on..

Correct typo's as per Jim's request

Add Option to use static IPV6 over v4 parent ( PPPoE

A new option when setting a v6 static on the WAN to allow the connection to use the V4 interfaces i.e. PPPoE

Fix some other outdated links

Fix #7493 only check interface IP if static

Merge pull request #3700 from phil-davis/ifgwadd

Merge pull request #3695 from phil-davis/refactor_if_list_functions

Add new IPv6 gateway to correct selectbox

Reload new gateway params after input errors

Validate gateway and interface together

Refactor IPv4 gateway add so field names are consistent with the IPv6 code

Fix IPv6 gateway add

Fix #7452 save new IPv6 gateway

This is also needed, just like for IPv4 in commit https://github.com/pfsense/pfsense/commit/f3278171b199062279225631903685e608285d3a

Refactor get_configured_interface_with_descr remove unused parameter

Fix #7452 save new gateway

Adds ability to ignore DHCP offers from multiple servers
- Forum thread: https://forum.pfsense.org/index.php?topic=124046.msg705100#msg705100
- related dhclient source:
https://github.com/pfsense/FreeBSD-src/blob/devel/sbin/dhclient/clparse.c#L945

changed files:...

Merge pull request #3515 from marjohn56/master

WAN flap loss of IPv6

Some hardware is taking too long to set ACCEPT_RTADV on the Interface,
this results in RTSOLD exiting and this not sending RS to start the
process. Apart from adding a delay to the start of RTSOLD which did
improve but not totally fix the issue the other change is to prevent the...

GET/POST conversion - services part 1

Revisions to GET/POST conversion limiting POSTs to save, apply, and delete functions - Interfaces

setHelp formatting for interfaces.php

There was a fair bit of it, so I have put this in its own pull request.
1) Gets HTML out of the strings that go for translation.
2) Line 3365 - the words here about "hexadecimal" now go in the text directly in the setHelp so the translators will get access to them....

Redmine #7173 Do not allow pkg_ for If, IfGroup, Alias

Merge pull request #3430 from phil-davis/required-fields3

More required fields for Interface pages

Merge branch 'master' into patch-4

Merge pull request #3431 from phil-davis/if-ifg-alias-name-validation

Merge pull request #3420 from phil-davis/patch-3

Merge branch 'master' into if-ifg-alias-name-validation

Merge branch 'master' into patch-4

Interface description must be unique including case

Required fields in Interfaces pages

interfaces.php display correct descr in group name message

Use the description that the user attempted to enter, not the original (and probably valid) description.

Validate POSTed interface description

Copy-paste error from code that used $_REQUEST. This is more correct to use $_POST.

Interface description should be required

I was blanking out stuff to see what input error messages came about fields that are required. I was surprised that the Interface Description would save empty. The system did not immediately explode (I was playing with a bonus interface I had created in a VM) but I don't think it is desirable to have interfaces with no description....

6RD Border Relay input error message

This field is labelled "6RD Border Relay" on the main UI. It confused me for a moment when I got this message "6RD Border Gateway must be an IPv4 address." since there was no field with that label in the 6RD section of the UI....

Example of setting required items

Merge pull request #3343 from phil-davis/retval1

Remove direct calls to /sbin/ifconfig destroy by pfSense_interface_destroy()

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Merge pull request #3266 from PiBa-NL/IPv6-prefixdelegation-size59

PPTP Remote IP is host or V4

Now that Form_IpAddress() supports a range of types of input, this can be specified as HOSTV4.

This should be a regular input form since it is no longer using an IP address class input type.

Change type of L2TP/PPTP WAN remote address to 'text' as it supports hostnames now, and the 'V4' type rejects them. Fixes #6899

Disable DHCP server on interfaces with subnet >= 31. Fixes #6930

dhcp6c no release

Script changes to allow no-release option of dhcp6c. These changes to be
used in conjunction with pfSense/FreeBSD-ports/net/dhcp6c recent change
from PR #231

IPv6, allow DHCP6 client to use a prefix size of /59

Merge pull request #3213 from PiBa-NL/interfaces-gateway-message

Merge pull request #3226 from phil-davis/patch-3

Added addrtolower() to interface pages

Specify the IP address family in interfaces.php

Where it is known what sort of IP address is required, we can specify it in the call to Form_IpAddress. That will make the hover text reflect what is really required as input, and make the client-side regex pattern also match only the allowed chars.

interfaces, show error message if adding duplicate gateway

Remove all calls to conf_mount_r* functions

Move copyright from ESF to Netgate

Fix wording of the "Reject leases from" option for a DHCP interface.

Merge pull request #3055 from marjohn56/master

Move to Apache License 2.0

Review license / copyright on all files (final round)

DHCP6 init before RA

Some ISP BNG's require that a dhcp6c init is sent before RA. The
additions to interfaces.php adds a new option flag 'dhcp6withoutra',
this flag is set or unset in the WAN DHCP6 section 'Do not wait for a
RA'.

The interfaces.inc file handles this flag and either launches dhcp6c on...

Change group labels s/MAC controls/MAC Address/

Fix undefined constant

Notice: Use of undefined constant min - assumed 'min'
Notice: Use of undefined constant max - assumed 'max'

jQuery datepicker added to interfaces.php and interfaces_ppps_edit.php for setting custom expirey date

Fix redundant phrasing.

Fixed #6331

Miscellaneous Textual Correction - Interfaces

Interfaces - Punctuation

Correct input type to 'text' for RADIUS shared secret used by wireless hostap interfaces. Fixes #6067

Further text refinements for PR 2790

Merge pull request #2790 from NOYB/Interfaces_-_Word_Smithing

Remove "we" personalizations.

Interfaces - Section Title - Reserved Networks

More accurate section title.

Remove errant line.

Interfaces - Word Smithing

Word smithing to remove a bunch of personalization ("You").

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Merge pull request #2737 from NOYB/HTML_Compliance_-_Interfaces

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

HTML Compliance - Interfaces

Error: Duplicate ID btnadvppp.
<a class=btn btn-default btn-info href=interfaces_ppps_edit.php id=btnadvppp>

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

More icon/button inconsistencies. Ticket #5965

More icon and button consistency fixes. Ticket #5965

Fix some more stragglers for icon/button consistency. Ticket #5965

Correct reference for 6rd. Ticket #5967

Merge pull request #2716 from phil-davis/patch-6

Change invalid use of $iface in interfaces.php

At this point $iface is an undefined var. So the last test of this "if" statement is useless.
That code fragment was introduced in commit https://github.com/pfsense/pfsense/commit/e4d40f41aafe00353c0069b457a0b1b0d6c20987...

Improve track6-prefix-id handling

1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max
2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range....

Add track6 DHCP6 IPs back to interface when applying changes. Ticket #5945

Fix DHCPv6 server check to allow track6. Ticket #3029

Properly check the parent's MTU when changing a VLAN MTU.

Review alert wording.

Interfaces - DHCP Advanced Options Checkbox Vars

Correct the Enable Checkbox Var Names