pfSense

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)

Do not allow deleting your own user name

Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain....

function name hms -> dhms

to match edit to util.inc
(cherry picked from commit c57e936a6596550619f7261e85b633ca5016cbf2)

Add "delete entry" for ARP table

Useful function in some circumstances - seems no reason not to have it.

Uses IP rather than hostname since not all ARP entries have hostnames.

Probably should also have "delete all" but not done that.
(cherry picked from commit 6ea0d41e3c094a0977e7f0d022ec74276280b8ff)

Fix NTP PPS. It had 'None' option available on 2.2.x.

(cherry picked from commit ceabd66d57f7199602d3a23cb8a60080bcfa67ea)

Fix "Unable to remove NTP GPS from configuration"

https://forum.pfsense.org/index.php?topic=112771.msg627573
(cherry picked from commit 55de528cbb177b4a1f40554ad1a567198bbeebb3)

redundant check - is_numericint() tests for >= 0
(cherry picked from commit f208e9690e2ec4089cf3d3fe5f5f03fed5a36e6f)

fix logic and replace hard coded value by global

backups should be a numeric int.
text hint for number of backups can now refer to the global value for this platform (and explains how to get that default, by leaving blank)
(cherry picked from commit 16b17c15f9fc29e9480431b5bc7bebe2bd4b6230)

Give settings section a more helpful/standard title to match other GUI settings tabs
(cherry picked from commit ca55edc39342865816feef390616be8b770c889b)

Self correcting - poor english
(cherry picked from commit b56769c30a23af9f575ee4a5f056558ef8322f95)

Accuracy

Large keys are not "slower to use" in many cases, since they are only used to validate or set up a session. An ongoing session usually transfers to a symmetric algorithm once established, and the user won't notice the short extra delay in session startup....

missed a comment I added and shouldn't have - removed
(cherry picked from commit 7c684f3b95f641134496bc1210cfb2d814468767)

Update OpenVPN Wizard to include missing key sizes

...and add some useful info to guide the user.
(cherry picked from commit 49810252681df9bd553e2221c885ceffaa2c4c7f)

Added option to System > General Setup > webConfigurator to change the title of the Help menu in the navbar to either the system hostname or fqdn.

(cherry picked from commit 1d12996755ee6fb9b9e163d292bdba160a926e64)

Make QinQ interfaces work again

(cherry picked from commit 1322ee22354f1a6e184819fb7009a2996b63de97)

Allow IGMP Proxy logging verbosity to be selected via system log settings (PR 2901)

(cherry picked from commit 2bd0585e30e5ec8fc3b79ca3f579bf9a7c1bcbc8)

adding privileges and separating DNS Resolver overrides from general settings

(cherry picked from commit fc76a1e390c8ce9579df31457c74d1d0e572b78d)

Fixed #6504 by making table sortable

(cherry picked from commit 55f67b5abd9b809807e328477779d97120908273)

jQuery datepicker added to interfaces.php and interfaces_ppps_edit.php for setting custom expirey date

(cherry picked from commit d85d82b7686d5899948e6ec4b1587e74937820cf)

Fixed #6516 by replacing HTML5 datepicker with jQuery widget

(cherry picked from commit 53c38ff16c1eb8743e69d506f69167c88cf34910)

fix rowhelper select_source empty combo

while using $config['installedpackage']{['...'] as source

update d3.js

update nvd3 files

Fixed #6514 by requiring string starts with letter ot underscore

(cherry picked from commit f0a053846d6cde2724c47b5553e1395cfd21445c)

Fixed #6498 by providing new address type argument to Form_IpAddress(). In this case it is specified as "V6".

(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)

Fix typo

Fix redundant phrasing.

Remove tab_array from interfaces_groups_edit.php to be consistent with other *_edit files

Correct value for 9600. Ticket #6416

Fix #6468 Do not allow edit of day and times

in rows of time ranges for a schedule.
The code was always intended that the user uses the calendar pad and start hour/minute stop hour/minute drop-down fields to enter days and time range. If an existing day-time-range is wrong, then the workflow is to delete the row and then enter the correct day-time-range using the calendar pad and start hour/minute stop hour/minute drop-down fields....

Validate submitted groups when editing a user. Ticket #6475

Add input validation to system_groupmanager.php to prevent invalid members from being submitted. Ticket #6475

Fix #6463 Dest net alias matching on page load

Do not set destination field to use customarray
Note: dstbeginport_cust does not exist on this page, so I got removed it here also to avoid future confusion.

Fix #6460 Interface mismatch apply changes button

Rework pkg_mgr_install.php:

- Stop using id parameter for additional packages, keep using it only
for firmware upgrades
- Created to control variables $completed and $confirmed to check all
the stages and make it easy to understand what is happening
- Stop using $pkgid and use $pkgname instead...

Fix variable name s/POST/_POST/ and also parameter name s/complete/completed/

Fix indent

Improve readability

Improve readability

Simplify mode parameter validation

Remove redundant check since pkgcancel is never set

Validate mode parameter and use sanitized variable on other places

Fix save and reset buttons on status_lb_pool.php. Ticket #6254

Fix #6440 RADIUS issued IPs

This is a checkbox - the state in the config is stored as set or not set.
This should fix the reported issue. I don;t have a system right now to test, but the bug seems obvious.

Allow - and _ in sysctl values. Ticket #6438

Don't override type so changing it is possible. Ticket #6439

Allow - in TFTP Server field. Ticket #6433

Comment typos

I can't resist fixing them when I see them.

Mask a few more sensitive bits of data in the status.php config.

Link to correct schedule from firewall_rules.php. Ticket #6428

Firewall / Aliases / Edit - New URL Table Alias Type

Need to pass alias type to process_alias_urltable() function when creating a new url table alias because it is not yet set/available from config. So the alias_get_type() function can't be successfully used yet....

Fixed #6401

(cherry picked from commit fe68a6a2b28c897cb3a8f8fda452c25f649556f1)

Handle mode correctly with Auto IKE. Ticket #6360

Firewall / Rules / Edit - URL (IP) Alias

Make alias type URL (IP) available for selection in firewall rules.

Changed element type from date to text. Date inputs are not yet handled consistently accross different browsers :(

(cherry picked from commit d78dbc34299652c637c77684b7848191c510f9f0)

Miscellaneous Textual Correction - System / Advanced / Networking

Use apostrophe instead of quote.

(cherry picked from commit d3706c81f7f77d21635c335d19e6626a4f7b568b)

Fix #6381 ipv6nat_ipaddr
(cherry picked from commit f489cfdbd4705578ee290b9df5bafe86efddbca8)

Fix quoting in diag_routes.php, see ticket #6371

Better fix for escaping in ticket #6371

Revert "Status / Services - Status Indicator"

This reverts commit 5260817282c47a208be6daf683db0157544b2d08.

Status / Interfaces - DNS Servers

The DNS servers are not necessarily ISP provided.

(cherry picked from commit 78869d5e82f149ad5bfb1e1d97d958d0bf1d0d54)

Status / Services - Status Indicator

Use font awesome icons instead of text.
Universal recognition eliminates need of text translation.

(cherry picked from commit e7161dc3b62b306b57c8d094f93c2ec08c9e0af2)

Add the function gettext

(cherry picked from commit 8d0b16a11c6a2a61fe51507a9b43b3bcad3aab80)

Fix Captive Portal's MACs icons

Standardize pass/block icons with the rest of the system

(cherry picked from commit 96abde901f0c4e81d4cac0acd2361267e6ef1b0c)

Fix closing `tbody` tag in Captive Portal's MACs

(cherry picked from commit 22b50541377ec212d71e0686a0b6a20149b23a7c)

Fixed #6872 Restored missing proxy port setting

Reduce maximum length of string to gettext()

This limit is set at 4096 on PHP 5.6: http://lxr.php.net/xref/PHP_5_6/ext/gettext/gettext.c#139

Bug report on forum: https://forum.pfsense.org/index.php?topic=110088.0

(cherry picked from commit 95f46512d9410b38b23d7778cec0bf8610e448cf)

Fix up diag_smart e-mail handling, and the backend config code was broken/making false assumption about the config file as well. Fixes #6371

Initialize output var in firewall_shaper_queues

To clear any previous use of the var elsewhere in included files.
Forum: https://forum.pfsense.org/index.php?topic=111852.0
(cherry picked from commit 49701df38e6c5b70526c2d436fcb4cfbb1310ae4)

Miscellaneous Textual Corrections - System / Advanced / Firewall & NAT

Section panel header title.

(cherry picked from commit 5414794c12fbcd6455a48f81428e0457a9cf0c95)

Make limiters info box work same as By Interface

The info box displayed on Firewall->Shaper, By Interface come down the bottom with and info icon and can be shown/hidden by the user.
The similar info box on Firewall->Shaper, Limiters sits in the main body with no info icon and cannot be shown/hidden, but can be dismissed....

Miscellaneous Textual Corrections - System / Advanced / Networking

(cherry picked from commit 542d14be063e0a90b9182ee3dac9dc3fdb52d04d)

Miscellaneous Textual Corrections - System / User Manager / Settings

(cherry picked from commit 850211423b3486353b2419b02211213196d8c36e)

Miscellanous Textual Corrections - Add missing dots, normalize case

(cherry picked from commit cb6c20a997eeb77b3529e157cd512fabb4ff69f0)

Sanitize notice output here as well. Ticket #6154

Correct force updates when chosen. Ticket #6359

Make rule_columns_with_alias end params optional

Stops PHP warnings like reported in forum https://forum.pfsense.org/index.php?topic=111768.0

Miscellaneous Textual Corrections - System Advanced

Miscellaneous Textual Corrections - Services NTP PPS

Fixed #6349

Add alias display to target host and target port columns

(cherry picked from commit 474e70a2d178de50060c6e5f1114bb5b6963a6b6)

Add a safebelt to makesure $cpzone is always in lowercase. Ticket #6278

Do not call pkg_update() here since pkg_switch_repo() aldready does it

Miscellanous Textual Corrections - Add missing dots to phrases

(cherry picked from commit e4c7d45fc7a294817325354e13f4d5bc4987739e)

Miscellaneous Textual Corrections - Services / Dynamic DNS

(cherry picked from commit 1c4e2ed053a04f7768a21129171a27e6804dbb0c)

Hide CIDR for alias types that do not use it

Suggested/discussed in forum
https://forum.pfsense.org/index.php?topic=111593.0

hideMask only modify input-group on first parent

Otherwise when unhiding (e.g. for Network type alias), input-group gets
added to every div up the DM hierarchy and the layout gets messed up.

Spaces->tabs

(cherry picked from commit e1caefc74fba6cbbb680288c1f8d930e4f0ad474)

Fix tab highlighting when editing mobile IPsec P1. Fixes #6341

Adding missing spaces between punctuation

(cherry picked from commit 0e63fe1f372584a03a6c84aeb6268fde8de75b3a)

Miscellaneous Textual Corrections - Services Load Balancer

(cherry picked from commit f3817766671915583074465aa725152c7a293568)

theme Compact-RED, added a few more tweaks to look a bit more aligned.

(cherry picked from commit ec18e589f123595c34cf8e1a84313394bb909250)

Add Compact-RED theme and update system.php to sort available themes by pfSense, then BETA, then user supplied themes.

(cherry picked from commit 6a5c6661960e1cd39e3caf66a3caaeb2678d27b1)

Miscellaneous Textual Corrections - Services DNS Resolver

(cherry picked from commit 0cb4d4a63585f500329616be6ee2bbb2274975c6)

Miscellaneous Textual Corrections - Services DNS Forwarder

(cherry picked from commit 3d7aaa1a3fac45271bfa50190496be6d70d7f296)

status_queues.php, default packet_s to 0 if it falls through to that point. Ticket #6329

Experimentally fixed #6327

(cherry picked from commit 54fc9503ff550d04d1253c41c1fd49da1b64c07e)

Miscellaneous Textual Correction - Firewall / Shaper

(cherry picked from commit c3ebf3470402080bbddb709325611e7120eb3c0f)

Miscellaneous Textual Correction - Firewall / Rules

(cherry picked from commit 1fd8a5520602803108ef8bbb56b8ffd6493f2a00)

Fixed #6331

(cherry picked from commit 7e653b50c4a25b045121c026cd09ac4e567c0c42)