pfSense

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

Merge pull request #2999 from phil-davis/patch-6

Validate submitted groups when editing a user. Ticket #6475

Add input validation to system_groupmanager.php to prevent invalid members from being submitted. Ticket #6475

Merge pull request #2998 from phil-davis/patch-5

Fix #6460 Interface mismatch apply changes button

Rework pkg_mgr_install.php:

- Stop using id parameter for additional packages, keep using it only
for firmware upgrades
- Created to control variables $completed and $confirmed to check all
the stages and make it easy to understand what is happening
- Stop using $pkgid and use $pkgname instead...

Fix variable name s/POST/_POST/ and also parameter name s/complete/completed/

Fix indent

Improve readability

Improve readability

Simplify mode parameter validation

Remove redundant check since pkgcancel is never set

Validate mode parameter and use sanitized variable on other places

Fix #6468 Do not allow edit of day and times

in rows of time ranges for a schedule.
The code was always intended that the user uses the calendar pad and start hour/minute stop hour/minute drop-down fields to enter days and time range. If an existing day-time-range is wrong, then the workflow is to delete the row and then enter the correct day-time-range using the calendar pad and start hour/minute stop hour/minute drop-down fields....

Fix #6463 Dest net alias matching on page load

Do not set destination field to use customarray
Note: dstbeginport_cust does not exist on this page, so I got removed it here also to avoid future confusion.

Fix save and reset buttons on status_lb_pool.php. Ticket #6254

Fix #6440 RADIUS issued IPs

This is a checkbox - the state in the config is stored as set or not set.
This should fix the reported issue. I don;t have a system right now to test, but the bug seems obvious.

Allow - and _ in sysctl values. Ticket #6438

Don't override type so changing it is possible. Ticket #6439

Allow - in TFTP Server field. Ticket #6433

Merge pull request #2990 from phil-davis/colmn

Mask a few more sensitive bits of data in the status.php config.

Comment typos

I can't resist fixing them when I see them.

Link to correct schedule from firewall_rules.php. Ticket #6428

Merge pull request #2983 from NOYB/Firewall_/_Aliases_/_Edit_-_New_URL_Table_Alias_Type

Fixed #6401

Handle mode correctly with Auto IKE. Ticket #6360

Firewall / Rules / Edit - URL (IP) Alias

Make alias type URL (IP) available for selection in firewall rules.

Firewall / Aliases / Edit - New URL Table Alias Type

Need to pass alias type to process_alias_urltable() function when creating a new url table alias because it is not yet set/available from config. So the alias_get_type() function can't be successfully used yet.

Changed element type from date to text. Date inputs are not yet handled consistently accross different browsers :(

Merge pull request #2978 from NOYB/Miscellaneous_Textual_Correction_-_System_/_Advanced_/_Networking

Fix #6381 ipv6nat_ipaddr
(cherry picked from commit f489cfdbd4705578ee290b9df5bafe86efddbca8)

Miscellaneous Textual Correction - System / Advanced / Networking

Use apostrophe instead of quote.

Fix quoting in diag_routes.php, see ticket #6371

Better fix for escaping in ticket #6371

Revert "Status / Services - Status Indicator"

This reverts commit e7161dc3b62b306b57c8d094f93c2ec08c9e0af2.

Merge pull request #2970 from NOYB/Status_/_Interfaces_-_DNS_Servers

Merge pull request #2972 from NOYB/Status_/_Services_-_Status_Indicator

Merge pull request #2969 from marianamorim/add_function_gettext

Merge pull request #2973 from jlduran/pass-block-icons-cp

Fix closing `tbody` tag in Captive Portal's MACs

Fix Captive Portal's MACs icons

Standardize pass/block icons with the rest of the system

Fixed #6872 Restored missing proxy port setting

(cherry picked from commit 6b43692408912de3375b34cc1982ff73f52762a5)

Status / Services - Status Indicator

Use font awesome icons instead of text.
Universal recognition eliminates need of text translation.

Fix up diag_smart e-mail handling, and the backend config code was broken/making false assumption about the config file as well. Fixes #6371

Status / Interfaces - DNS Servers

The DNS servers are not necessarily ISP provided.

Add the function gettext

Merge pull request #2968 from NewEraCracker/patch-gettext-maxlen

Reduce maximum length of string to gettext()

This limit is set at 4096 on PHP 5.6: http://lxr.php.net/xref/PHP_5_6/ext/gettext/gettext.c#139

Bug report on forum: https://forum.pfsense.org/index.php?topic=110088.0

Initialize output var in firewall_shaper_queues

To clear any previous use of the var elsewhere in included files.
Forum: https://forum.pfsense.org/index.php?topic=111852.0

Merge pull request #2965 from NOYB/Miscellaneous_Textual_Corrections_-_System_/_Advanced_/_Firewall_&_NAT

Merge pull request #2964 from phil-davis/patch-3

Merge pull request #2961 from NOYB/Miscellaneous_Textual_Corrections_-_System_/_Advanced_/_Networking

Merge pull request #2960 from NOYB/Miscellaneous_Textual_Corrections_-_System_/_User_Manager_/_Settings

Merge pull request #2954 from NewEraCracker/textual-corrections

Sanitize notice output here as well. Ticket #6154

Correct force updates when chosen. Ticket #6359

Miscellaneous Textual Corrections - System / Advanced / Firewall & NAT

Section panel header title.

Make limiters info box work same as By Interface

The info box displayed on Firewall->Shaper, By Interface come down the bottom with and info icon and can be shown/hidden by the user.
The similar info box on Firewall->Shaper, Limiters sits in the main body with no info icon and cannot be shown/hidden, but can be dismissed....

Miscellaneous Textual Corrections - System / Advanced / Networking

Miscellaneous Textual Corrections - System / User Manager / Settings

Make rule_columns_with_alias end params optional

Stops PHP warnings like reported in forum https://forum.pfsense.org/index.php?topic=111768.0

Merge pull request #2957 from NOYB/Miscellaneous_Textual_Corrections_-_System_Advanced

Merge pull request #2956 from NOYB/Miscellaneous_Textual_Corrections_-_Services_NTP_PPS

Fixed #6349

(cherry picked from commit c032a89a890a350540df12a9d2e41b9c7d8efda5)

Miscellaneous Textual Corrections - System Advanced

Add alias display to target host and target port columns

Add a safebelt to makesure $cpzone is always in lowercase. Ticket #6278

Miscellaneous Textual Corrections - Services NTP PPS

Miscellanous Textual Corrections - Add missing dots, normalize case

Do not call pkg_update() here since pkg_switch_repo() aldready does it

Merge pull request #2953 from NewEraCracker/textual-corrections

Merge branch 'master' of git.pfmechanics.com:pfsense/pfsense

Merge pull request #2950 from NOYB/Miscellaneous_Textual_Corrections_-_Services_Dynamic_DNS

Miscellanous Textual Corrections - Add missing dots to phrases

Hide CIDR for alias types that do not use it

Suggested/discussed in forum
https://forum.pfsense.org/index.php?topic=111593.0

hideMask only modify input-group on first parent

Otherwise when unhiding (e.g. for Network type alias), input-group gets
added to every div up the DM hierarchy and the layout gets messed up.

Spaces->tabs

Added hideMask() function

Miscellaneous Textual Corrections - Services / Dynamic DNS

Fix tab highlighting when editing mobile IPsec P1. Fixes #6341

Merge pull request #2949 from NewEraCracker/textual-corrections

Adding missing spaces between punctuation

Miscellaneous Textual Corrections - Services Load Balancer

theme Compact-RED, added a few more tweaks to look a bit more aligned.

Add Compact-RED theme and update system.php to sort available themes by pfSense, then BETA, then user supplied themes.

Merge pull request #2946 from NOYB/Miscellaneous_Textual_Corrections_-_Services_DNS_Resolver

Miscellaneous Textual Corrections - Services DNS Resolver

Miscellaneous Textual Corrections - Services DNS Forwarder

status_queues.php, default packet_s to 0 if it falls through to that point. Ticket #6329

Experimentally fixed #6327

Merge pull request #2941 from NOYB/Miscellaneous_Textual_Correction_-_Firewall_/_Shaper

Merge pull request #2939 from NOYB/Miscellaneous_Textual_Correction_-_Firewall_/_Rules

Miscellaneous Textual Correction - Firewall / Shaper

Fixed #6331

Workaound fixes #6320

Don't divide by 0. Ticket #6329

Miscellaneous Textual Correction - Firewall / Rules

Change the default output of pkg.php lists to be encoded before display. Preserve the old behavior as an option in case a package needs it (I didn't see any current ones that appeared to rely on the behavior, however)