pfSense

Experimental: Fixed #5693
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password

Fixes issue where limiter mask does not save (from forum)

Change alert box color to success

Merge pull request #2321 from ch1c4um/Fix_dns_resolver

HTML Compliance - System / Package Manager / Available Packages

Bad value #search-panel .panel-body for attribute href on element a: Illegal character in fragment: space is not allowed.
<a data-toggle="collapse" href="#search-panel .panel-body" name="search-panel">...

Fixed #5697

Merge pull request #2327 from NOYB/HTML_Compliance_-_System_/_Package_Manager_/_Available_Packages

Merge pull request #2326 from NOYB/HTML_Compliance_-_System_/_Certicate_/_CAs

Alternative to PR 2324 - Remove unneeded div

HTML Compliance - System / Package Manager / Available Packages

Stray tbody, table, and div tag ends when list empty.
Close php tag.

HTML Compliance - System / Certicate / CAs

Close div tag
Close php tag

Update pkg_edit.php

• Incorrect variable name in pkg_edit

clarify text, might not apply to "NIC" (lagg, VLANs, etc.)

Fixed #5691

HTML Compliance - System / Advanced / Firewall and NAT

Bad value 200000↩ for attribute placeholder on element input: Line feed not allowed.
<input class="form-control" name="maximumtableentries" id="maximumtableentries" type="text" placeholder="200000↩">...

Merge branch 'master' of git.pfmechanics.com:pfsense/pfsense

fix part of #5604

Added support for <width> on inouts and aliases.

Add title to add row buttone

Fixed #5668

Add pkg key fingerprint for packages from beta.pfsense.org

Fixed bug to disable dns resolver service

Take this conditional out, it wasn't enough, and we have a script example for how to handle this properly now while respecting CSRF

Merge pull request #2319 from NOYB/HTML_Compliance_-_System_/_Advanced_/_Admin_Access

Merge pull request #2318 from phil-davis/patch-2

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

This would require some minor adjustments to the wizards xml , for it to make sense everywhere.

HTML Compliance - System / Advanced / Admin Access

Close div tag
Close php tag

LAGG edit fixes

1) $_POST['members'] is an array, but $pconfig['members'] should be a comma-separated list. So the general copy "$pconfig = $_POST;" needs to be followed by setting up 'members' in particular.
2) $members_array is never used - so throw it away....

Add trash can icon to rowhelper delete buttons

Remove name collision in $width attribute

Accommodate <width> XML tag in rowhelper input fields

Move width:auto style to textarea handler in pkg_edit.php

Merge pull request #2316 from phil-davis/patch-3

Merge pull request #2295 from NOYB/HTML_Compliance_-_Form_Input_-_Placeholder

Merge pull request #2311 from heper/patch-1

Adds support for <width> XML tag in rowhelper selects

HTML Compliance - Form Select 3rd try

This is a combined version of:
https://github.com/pfsense/pfsense/pull/2310
https://github.com/pfsense/pfsense/pull/2315

Default textarea width to 60 cols.
Use setCols() to override

Adds style="width: auto;" attribute to textareas to allow the "cols" attribute to take effect. Required bu pkg_edit.php and by wizards

Reverts change to Form_Selector which was breaking selectors with blank options

Modify CSS to allow caller to specify width

Bug #5527

Bug #5527

Update system_gateway_groups_edit.php

Bug #5527

Bug #5527

Bug #5527

bug #5527

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php

Fix help text on delete row when selector is used in a PHP table

Test for #5676

Fixed #5678

Fix row add/delete issues intorduced by PR https://github.com/pfsense/pfsense/commit/f35ce6d20e6fd1e3b66b5935c70532d7e5fa741f/

Only disable CSRF on diag_backup.php for the download action where it might be scripted. Other actions need its protection.

Encode hostname before printing; remove some related dead code.

Add "BETA" badge to ne UI feature

adding active tab to breadcrumb

closely review L186 - L188

Encode gateway attributes before printing

Merge pull request #2301 from NOYB/Staus_-_System_-_Logs_-_Write_Config_Only

Merge pull request #2298 from NOYB/WebGUI_Left_Column_Labels_Hyper

HTML Compliance - Form Group - Label For

The for attribute of the label element must refer to a non-hidden form control.

Merge pull request #2306 from ExolonDX/branch_06

Merge pull request #2305 from ExolonDX/branch_04

Merge pull request #2308 from phil-davis/patch-5

Merge pull request #2302 from ExolonDX/branch_03

Merge pull request #2300 from ExolonDX/branch_02

Merge pull request #2299 from ExolonDX/branch_01

Merge pull request #2294 from NOYB/HTML_Compliance_-_Form_Select

fix text

Only enable Restore Configuration if a file is selected

If the user clicks "Choose File" and then cancels the file selection dialog, disable the "Restore Configuration" button.

Update wake_on_lan.widget.php

Remove unused TD tag

Tidy up columns in "ipsec"

status_ipsec.php
- remove unused column

vpn_ipsec.php
- reduce COLPSAN to seven

Tidy up widgets

ipsec.widget.php
- add missing TR tags to THEAD

wake_on_lan.widget.php
- remove stray double quotes

Replace FONT tag with SPAN

Replace FONT tag with SPAN tags and Bootstrap CLASS statement
Escape double quotes correctly in "system_usermanager_settings_test.php"

Staus - System - Logs - Firewall - Write Config Only

If no logging changes have been made, only write the config file.

Staus - System - Logs - Write Config Only

If no logging changes have been made, only write the config file.

Use Bootstraps text alignment classes

As per "http://getbootstrap.com/css/#type-alignment", use CLASS
statement instead in inline STYLE statement (much tidier)

Remove $closehead variable

Remove unused variable $closehead

WebGUI Left Column Labels Hyper

Touch Screen Usability Annoyance
https://forum.pfsense.org/index.php?topic=104135.0

Clicking the labels in the left column selects/activates the first item. This is the perfectly natural place for scrolling with thumb.

No big problem really for input fields, but check boxes and buttons are inadvertently selected/toggled resulting in unintended configuration changes....

Fixed #5659

HTML Compliance - Form Input - Placeholder

Attribute placeholder not allowed on element select at this point.
Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url.

HTML Compliance - Form Select

Element option without attribute label must not be empty.

Fixed #5636

Merge pull request #2292 from phil-davis/patch-2

Merge pull request #2291 from phil-davis/snmax

Merge pull request #2289 from NOYB/HTML_Compliance_-_Wake_On_LAN_Widget

Merge pull request #2288 from NOYB/Status_-_System_Logs_-_Manage_Log_-_Input_Validation

Fixed #5653
Removed bogus code that forced system information to be first in the list
Added JS to always add system_information to col 1

Fix static DHCP address validation

1) Use gen_subnetv4 and gen_subnetv4_max rather than doing the guts of the calculation inline. (The ~gen_subnet_mask_long($ifcfgsn) thing was the cause of the problem)
2) Add validation checks to stop people using the network address or broadcast address as a statically allocated DHCP address....

Fix gen_subnetv4_max

and use it in services_dhcp rather than trying to do the similar
calculation in-line.
Should fix redmine #5654 and probably a bunch of other things that use
gen_subnet_max

Validate IP passthrough bandwidth values within sane range. Ticket #5655

Validate CP MAC passthrough bandwidth. Ticket #5655

HTML Compliance - Wake On LAN Widget

Align attribute not supported on td tag in HTML5 use css instead.
Center tag not supported in HTML5 use css instead.

Add max value to qty field.

Status - System Logs - Manage Log - Input Validation

Add input validation at form level in browser.
Keep PHP server side validation so as not to rely solely on the browser.

Merge pull request #2287 from NOYB/Interfaces_-_DHCP_Config_File_Override