pfSense

JavaScript Polyfill - String Includes Method

A place for JavaScript polyfills.

JavaScript string includes method polyfill. A new method that has not yet found it's way into many browser implementations.
Documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/includes...

shorten ipsec widget refresh time

Fixed #5918 ipsec widget row color on dark theme

point css files to the new location

add color to icons

Make pkg_mgr_installed.php use an ajax call to avoid GUI timeout when rpeo is unreachable

accidently re-added a file in last commit

Merge pull request #2753 from phil-davis/patch-5

Merge pull request #2752 from phil-davis/patch-4

Redmine #5994 services_ntpd_gps standardize advanced button

organize assets and put 3rd party into vendor folder

Simplified styling

Revised modal styling

Fix up the "Show Phase 2 Entries" button for IPsec. Ticket #5965

Converted LDAP container picker to modal

match text to buttons

replace undo with times icon for closing

Style revisions

LDAP test pop-up replaced with Bootstrap styled modal

Status / Dashboard - Conceal save icon when not dirty.

Redmine #5994 interfaces_ppps_edit standardize advanced button

Redmine #5994 interfaces_bridge_edit standardize advanced button

Merge pull request #2749 from phil-davis/patch-5

Merge pull request #2748 from phil-davis/patch-3

servise_dhcp include btnadvopts in section

Before this change, $section is added to $form before btnadvopts is put into $section. The previous code looked to me like btnadvopts would end up in a $section object that got overwritten by the new Form_Section at line 1165....

Redmine #5994 services_ntpd standardize advanced buttons

services_ntpd_gps fix handling of initcmd

1) When reading the (encoded) initcmd string into Form_Textarea(), decode it.
Previously the encoded value was displaying in the text area and when the user presses save, that encode string is itself encoded again in the config and thus stuffs things up....

Merge pull request #2746 from phil-davis/patch-3

services_ntpd fix leaptext array key name

Use leaptext everywhere - some references were to leaptext and some to leaptxt, so it didn't work.

HTML Compliance - Firewall / Aliases / Bulk Import

Error: Element ul not allowed as child of element span in this context. (Suppressing further errors from this subtree.)

add btn-warning color to dark theme

update btn-primary color on dark theme

remove troubleshooting code

update colors and rules on dark theme

update btn-info color on dark theme

Comment typos - firewall_rules

Fixed #5953 Dashboard widget alignment issues

Highlight moved rows to confirm move

Add color to the CARP status icons so they are more visually distinct. Ticket #5965

remove beta marking for dashboard columns feature

fix primary button text color

Fixed #5998 menu bar formatting with 10 digit alerts

Merge pull request #2742 from phil-davis/patch-6

Merge pull request #2741 from phil-davis/patch-5

Merge pull request #2740 from phil-davis/patch-4

Redmine #5994 Standardize gateways edit advanced button

Merge pull request #2739 from phil-davis/patch-3

Merge pull request #2737 from NOYB/HTML_Compliance_-_Interfaces

Redmine #5972 Display Advanced settings on page load

If there are non-default advanced settings, then the relevant fields are displayed on page load.
Advanced button behavior is standardized as described in redmine #5994

Redmine #5994 Make DHCP static edit advanced buttons

Make the advanced buttons consistent.

Redmine #5994 Make DHCP advanced buttons work consistently

This is the first UI page to be changed so that the Advanced buttons work as specified in Redmine #5994
If this seems like a reasonable way to do it, then I will make similar code for the other UI pages with Advanced buttons.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

HTML Compliance - Interfaces

Error: Duplicate ID btnadvppp.
<a class=btn btn-default btn-info href=interfaces_ppps_edit.php id=btnadvppp>

Fix population of the wireless parent list. Fixes #5992

Re-commit change

Revert "Fixed #5983"

This reverts commit 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Merge pull request #2736 from phil-davis/patch-2

Merge pull request #2735 from NOYB/HTML_Compliance_-_Firewall_/_Schedules_/_Edit_-_Readonly_Attribute

Merge pull request #2732 from ExolonDX/branch_02

Merge pull request #2728 from phil-davis/form_button

Fixed #5983

Added the ability to move multiple firewall rules via a "movre to here" icon (anchor)

Icon missing from default pkg.php save button. Ticket #5965

Change to 4 spaces

Fix styling on "Create Phase 1" button. Ticket #5965

Anchot icon requires icon-pointer class

Translate button text

Merge pull request #2734 from NOYB/System_/_Routing_/_Gateways_/_Edit_-_Punctuation

Merge pull request #2733 from ExolonDX/branch_03

Merge pull request #2731 from ExolonDX/branch_01

Merge pull request #2730 from NOYB/HTML_Compliance_-_Status_Dashboard_-_System_Information_Widget

HTML Compliance - Firewall / Schedules / Edit - Readonly Attribute

Error: Bad value readonly for attribute type on element input.

Readonly is not a valid type attribute value.
If the intention here is to prevent the fields from being edited. Use the readonly attribute....

Use file-text-o instead of file-o for consistency. Ticket #5965

System / Routing / Gateways / Edit - Punctuation

Tidy up "interfaces_bridge_edit"

Change type of input to number

Tidy up "system_gateways_edit"

Tidy up missing semi-colon in non-breaking space

Tidy up "pkg_mgr_installed"

Remove stray closing SMALL tag

HTML Compliance - Status Dashboard - System Information Widget

Error: Stray end tag spa.
Error: End tag td seen, but there were open elements.
Error: Unclosed element span.

Use route_vpn_gateway for tap-type OpenVPN instances as well where specified. Remove old and wrongly copy/pasted comments while here. Ticket #5981

adjust nvd3 chart height and make rule more strict

Fix icon usage on the interfaces widget, the down icon was arrow-up. Add color to the status for clarity. Ticket #5965

Fix online user counts for CP/Vouchers. Fixes #5978

Resolve conflicts with master

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Some safety belts to avoid presenting PHP errors to the user. Ticket #5973

Ensure $a_cert is always an array. Fixes #5977

Tweaks/fixes for WoL, ticket #5965

Fixup Toggle All button, ticket #5965

Merge pull request #2725 from NewEraCracker/system_certmanager-fixes

Merge pull request #2727 from phil-davis/savebtn

Merge pull request #2726heper:patch-2 from phil-davis/patch-2

Fix $POST checks so they do not depend on string Save

This prevents problems when Save is translated to other languages.
Note: This is the only remaining place I could find with this issue.
There are other pieces of code that do:
```
if ($_POST['save'] == gettext("Save"))...

Use a more clear icon/wording on Diag > Tables button to flush the table. Ticket #5965

Use less confusing button text/colors/icons for Factory defaults/Halt/Reboot. Ticket #5965

Translate the default submit button text

Note: This will cause a problem for some code that does comparisons expecting this text to be exactly the string 'Save'. If the user has selected a different language then the button text will be translated and thus will be some different text....

HTML Compliance - CARP Status Widget

Error: th start tag in table body.
Warning: A table row was 1 columns wide, which is less than the column count established by the first row (3).

Indent system_certmanager.php

The 'csr' code block is duplicated. This commit removes it

Fix QinQ member save action. Ticket #5965

Fix some Save button quirks. Ticket #5965

change to class for multiple update locations