pfSense

Addresses #5159 by removing hide/show/disable/enable functions to included file

Fixed #5193 clean up user prompts

Introduce read_global_var:

- Add a new script, read_global_var, that returns the value of any item
contained in global array $g
- Replace all grep and sed magic from shell scripts

Preparation #5159 (Javascript refactoring)
javascript/pfSenseHelpers.js created and populated with common hide/show/disable/enable functions
file included via foot.inc
Those functions removed from firewall_nat_edit.php to test

Improved styling of page title prevents spurious underline

Page title now hyperlink to page

Fixed 5225

Fixed 5225
Programmer had mangled element name in if($_POST) section

Introduce read_xml_tag.sh

Create /usr/local/sbin/read_xml_tag.sh, that will read a xml tag from
config file using xmllint. Replace all direct read using cat, grep, sed,
... by this script

Remove /usr/share/zoneinfo.tgz and use FreeBSD stock zoneinfo. It fixes #4726

Cert fields should be used for EAP-RADIUS as well.

Removed bogus array_merge()

Fixed bogus array_merge in localid_type selector

Fixed incorrect encryption bits selectors
Hide Remote network if mobile

Fix detection of mobile IPsec P1 when editing.

Use product_name global variable in more places

Fixed #5127
Don't "foreach($config['menus'])" if there are no menus defined

Corrected page title (which was using incorect PHP format)

Corrected logo hyperlink
Changed Jumbotron font to white so you can actually read the text

pkg 1.6.x upgrade command called with -q is now respecting it

Suppress progreess bar until package system revision is complete

Wizard system completed and tested agains all wizard files
Progress bar added to show progess through wizard steps

Do a service reload of dyndns when changing gateways in case something has
changed. Ticket #5214

Bootstrap conversion mostly complete.
Tested with setupwizard.xml and looks good. Couple more thankgs to check so don't test yet please.

Do not run pkg update between first and second step of upgrade process

Remove old references to undefined variable firmwarelock

Call exit after detect another instance is already running, otherwise it would end up deleting pid file

Detect when pkg must be upgraded and do it early, followed by a pkg update to make sure metadata is updated

Fixed #5209

Fixed #5206
Completes conversion of the pkg* files

Fixed #5212

Fil;e conversion complete. Tested against multiple packages

Ensure this only contains a partial name, not a path, before attempting to craft a full name and read the file. Fixes #5203.

add 'interface' column to lease_counter table

Cleanup cache and stale packages after install/delete

Add missing ;;

Initial conversion of the file. Most functions completed and tested, but more testing remains

Fix logic to set EVENT_PIPE

Add -h, to show help

Define EVENT_PIPE using a parameter, -p

Print return code when _GUI_CALL is not empty, used by GUI to check rc of a process that runs in bg

Replace direct calls to exit by _exit

Set environment var EVENT_PIPE, used by pkg to write out progress in json format

Rename functions and variables to improve readability, no functional changes

Use compare_version() for kernel_pkg checks

Add pfSense-upgrade parameters -i/-r to install or remove packages

Change usage() to use regular echo() and print to stderr

Relocate global variables definitions, no functional changes

Relocate main block and leave all functions in the beggining

Check if update needs to run inside update()

Update repository metadata hourly

Fixed #5189

Ticket #5204 a clean up pass of the jquery sections

Clarify the use of noshuntlaninterfaces and autoexcludelanaddress

The existing code here looks like it should be working correctly. Maybe it would help future maintainers if the field name used for gathering the data value in the UI and $POSTing it is changed to autoexcludelanaddress. Then the code reads a bit more easily where the logic value of noshuntlaninterfaces and autoexcludelanaddress is swapped back and forth.

Reset the value of a package field before this test in case it has no default. Fixes #5199

Fixed #5192
Element names corrected

Updated tables to responsive format
Added table style classes
Changed array keys to descriptive names
Updated indenting/style

Merge pull request #1932 from heper/patch-2

Comment typo fix

Fixed #5146
Bootstrap conversion complete and unit tested

service_dhcp_edit.php fixes from code inspection

To save you some time in testing and fixing, here are the bugs I noticed by code inspection.

File converted but not yet checked/tested

Add -u option to pfSense-upgrade

- New u option, to run pkg update
Move upgrade action code to upgrade()
- Rename first_step to upgrade_first_step
- Rename second_step to upgrade_second_step
- Do not call update when upgrade is called

Verify if pkg is (un)locked before (un)lock it

Disable trap on _exit()

Declare logfile earlier

Make usega() more informative

Teach _exit() to return 1st parameter, replace exit calls by _exit and move trap to start of main block

Track pfSense-upgrade pidfile to avoid running 2 instances simultaneosly

dhcp_lease_counter for master

https://redmine.pfsense.org/issues/5186

Fixed #5189

Abort when 'pkg update' fails

Fixed #5165

Fixed #5188

Remove link to package revision history

Fix package name

Reintroduce part of 5779ade6707ba530517da239d9ec3fc751d17d83 lost during bootstrap merge

Re-apply changes did to convert pkg_mgr.php to use pkg that got lost during merge

Fixed #5187
Added multipart encoding to form

Fixed #5184

Ticket #5182 add hide functionality

Ticket #5182 add hide functionality

Fixed #5183 by converting to PHP table library

Ticket #5182 change show/hide functionality

Unfinished (but better) versions of hte pkg pages and utilities

Merge pull request #1929 from phil-davis/patch-4

Don't allow configuring IPv6 link local addresses on an interface. Ticket #4062

Fix pptp_remote0 var name

I missed one of these in all the manual integration.
Commit https://github.com/pfsense/pfsense/commit/66fd7b47679187ddcfaf5852a55b2af15394f341 had this error.

fix typo

services_ntpd.php - style fixes, fix typo

interfaces_gif_edit.php: improve input validation, show input errors

vpn_l2tp.php clean up text

interfaces_bridge_edit.php - input validation improvements, style fixes

interfaces_gre_edit.php - fix display of input errors, improve input
validation.

Fixed #5155

Fixed #5108

Merge pull request #1902 from dachande/feature/certmanager_san_wildcard_hostname

Redmine #4568 Preserve MLPPP settings when saving interface settings

This is a resubmit of https://github.com/pfsense/pfsense/pull/1900 after integrating to the current master.

Fixed #5178
Removed errant "break"

remove unused bootstrap theme file