pfSense

Fix all unterminated character class for pattern

Fixed #5723

Fix a bunch of text issues on DNS resolver advanced options

Added new method setRequired() (shortcut for setAttribute("required", true) )

Validate pppoe_subnet before use it in calculation. Ticket #5720

Change number of PPPoE users range to 1-255 and add an extra POST validation

Fix field name validation

Replace n_l2tp_units field by a drop-down from 1 to 255 and add a post validation just to be sure. Ticket #5720

Fix success message color

Fixed #5738

Merge pull request #2358 from NOYB/HTML_Compliance_-_Firewall_/_Rules_/_WAN

HTML Compliance - Firewall / Rules / WAN

Attribute name not allowed on element table at this point.
<table name="ruletable" class="table table-hover table-striped table-condensed">

Unclosed element div.
End tag for body seen, but there were unclosed elements.

Status logs common changes for nginx

Fixed #5633

Merge pull request #2353 from NOYB/HTML_Compliance_-_Firewall_/_NAT_/_Outbound_/_Edit

Add some more Bootsrap panels

"firewall_aliases.php"
- add gettext to the H2 tag
- remove debug code

"sevices_igmpproxy.php"
"services_pppoe.php"
"vpn_ipsec_keys.php"
"status_gateways.php"
"status_gateway_groups.php"
"statis_services.php"
"diag_arp.php"...

add dark beta theme

back out design changes for now

Remove errant bracket from character class.

Merge branch 'Status_-_System_Logs_-_Consolidation' of https://github.com/NOYB/pfsense

• 'Status_-_System_Logs_-_Consolidation' of https://github.com/NOYB/pfsense:
  Redmine #5731 Error when setting various system log settings from factory default config...

HTML Compliance - Form Button - HRef

The name attribute is obsolete. Consider putting an id attribute on the nearest container instead.
The <a> name attribute is not supported in HTML5. Use the id attribute instead.

Merge pull request #2343 from phil-davis/patch-3

clean up lighttpd

clean up lighttpd

Keeping the disable logging option. Revert "clean up lighttpd bits"

This reverts commit 9de0332dec955ec513b74be9361de72d12aa7245.

clean up lighttpd bits

HTML Compliance - Firewall / NAT / Outbound / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="source" id="source" type="text" pattern="[0-9, a-z, A-Z and .">
<input class="form-control" name="destination" id="destination" type="text" value="" pattern="[0-9, a-z, A-Z and .">...

Fix interface list

Improve error message when the user forget to "Apply"

Redmine #5731 Error when setting various system log settings from factory default config

From PR #2350 By Phil Davis

HTML Compliance - Status - System Logs - Firewall Summary View

The align attribute on the div element is obsolete. Use CSS instead.
Replace with bootstrap class="text-center".

Fixup AJAX stuff so dynamic updating works.

Move getGETPOSTsettingvalue function to be more centrally located in guiconfig.inc.

Rename functions per Phil suggestions.

s/miscellaneous_common_code/status_logs_common_code/
s/build_if_list/status_logs_build_if_list/

As for getGETPOSTsettingvalue I'm open to it going anywhere that makes sense. Would be nice not to need too many additional inc's to get it though. Anything in guiconfig.inc or filter_logs.inc hierarchy shouldn't require anything additional.

Remove commented out test code.

Can' t do that here. Remove space between php tags.

Status - System Logs - Consolidate - Firewall Summary View

Update summary view log selection method to same method as firewall and system logs.

Status - System Logs - Consolidate - Firewall Dynamic View

Add advanced filtering to firewall dynamic view.
Add manage log to dynamic view.
Update dynamic view view log selection method to same method as firewall and system logs.

Status - System Logs - Consolidate - Common Functions

Factor common code section into to functions and place in include file.

getGETPOSTsettingvalue
 miscellaneous_common_code
 tab_array_logs_common

log_filter_form_system_submit
 filter_form_system

log_filter_form_firewall_submit...

Merge pull request #2352 from phil-davis/status_graph

Fixed #5733

Add back display description option for status_graph

The code that provides the data for this is already in
bandwidth_by_ip.php in both 2.2.* and master 2.3.
The description option is in the Display dropdown list in 2.2.*, but it
got missed in the bootstrap conversion and integration process....

Correct "noWrap" in text areas. (Function is not actually used by anyone, but it might as well work just in case.

Merge pull request #2351 from NOYB/HTML_Compliance_-_Firewall_/_NAT/_1_1_/_Edit

Redmine #5731 Error when setting various system log settings from factory default config

Forum https://forum.pfsense.org/index.php?topic=104762.0

HTML Compliance - Firewall / NAT/ 1:1 / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="src" id="src" type="text" pattern="[0-9, a-z, A-Z and .">
<input class="form-control" name="dst" id="dst" type="text" pattern="[0-9, a-z, A-Z and .">

Redmine #5728 Fix delete row button in Firewall Schedule Edit

The calls to delete_row() were going off to some other delete_row() function and not doing what was needed.
Give delete_row() here a unique name and it all works again.

Merge pull request #2347 from NOYB/HTML_Compliance_-_Firewall_/_NAT_/_Port_Forward_/_Edit

Merge pull request #2346 from NOYB/HTML_Compliance_-_Firewall_/_Aliases_/_Edit

Merge pull request #2345 from NOYB/HTML_Compliance_-_Services_Status_Widget

HTML Compliance - Firewall / NAT / Port Forward / Edit

Attribute min/max not allowed on element input at this point.
<input class="form-control" name="srcbeginport_cust" id="srcbeginport_cust" type="text" value="any" min="1" max="65536">
<input class="form-control" name="srcendport_cust" id="srcendport_cust" type="text" value="any" min="1" max="65536">...

Fix reading of server list on page load

Fixed #5724

HTML Compliance - Firewall / Aliases / Edit

Bad value [0-9, a-z, A-Z and . for attribute pattern on element input: Unterminated character class
<input class="form-control" name="address0" id="address0" type="text" value="" pattern="[0-9, a-z, A-Z and ." placeholder="Address">

HTML Compliance - Services Status Widget

Element option without attribute label must not be empty.
<option selected></option>

Fix redmine #5722 DHCP validation for master

Merge pull request #2341 from NOYB/HTML_Compliance_-_Interfaces_/_VLAN

Merge pull request #2339 from BBcan177/patch-2

HTML Compliance - Interfaces / VLAN

A table row was 5 columns wide and exceeded the column count established by the first row (4).

pkg_mgr_installed - Fix disablepackagehistory

• Improve if/else/endif

pkg_mgr - Fix disablepackagehistory

• Version title should always print
• $g['disablepackagehistory'] only disables the changelog hyperlink

Fixed #5717

Merge pull request #2325 from stilez/patch-7

Merge pull request #2337 from BBcan177/patch-1

Update pkg_mgr.php

Update syntax to 4 space indent

Add password confirmation and change to Form_* framework

Update pkg_mgr.php

• Note - There are two lines previously commented out at Lines! (L127-128)

• Mods to if/else/elseif/endif statements for consistency.
• Change package dependency href link icon from "paper-clip" to "globe".
• Put package dependency links into a < ul > for a cleaner output when dependencies span over two lines....

Merge pull request #2335 from NOYB/HTML_Compliance_-_Interfaces_/_Assign_network_ports

Merge pull request #2334 from BBcan177/patch-2

Fix typo password confirm

https://forum.pfsense.org/index.php?topic=104629.0

HTML Compliance - Interfaces / Assign network ports

A table row was 3 columns wide and exceeded the column count established by the first row (2).

Update pkg_mgr_installed.php

• Mods to if/else/elseif/endif statements for consistency.
• Change font red to span class.
• Change package dependency href link icon from "paper-clip" to "globe".
• Remove redundant <i> in package dependency href link
• Put package dependency links into a <ul> for a cleaner output when dependencies span over two lines....

Add output validation here too. Ticket #5351

complete breadcrumbs for each tab

No need to restart dpinger to get new rrd data, it's not like apinger that send data to rrd

Fixed #5694

Final updates in support of hidden passwords

Merge pull request #2333 from NOYB/HTML_Compliance_-_System_/_User_Manager_/_Users

Correction to #5710

Fixed #5710

HTML Compliance - System / User Manager / Users

A table row was 6 columns wide and exceeded the column count established by the first row (5).
End tag div seen, but there were open elements.
Unclosed element form.
Close php tag.

Fixed saving password when the ols password needs to be retained

Merge pull request #2331 from BBcan177/patch-1

FInished password hiding logic by ensuring $_POST['password'] != DMYPWD before updating

Added new addPassword method and password == password_confirm validation where required.

Add href for package dependencies (pkg_mgr_installed)

• Case typo
• Change package dependency text to href link(s).

Merge pull request #2330 from ExolonDX/master

Don't display dummy password if configured pwd is empty

Experimental: Fixed #5693
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password

Update "firewall_aliases.php"

Add Bootstrap panels to "firewall_aliases.php"

Fixes issue where limiter mask does not save (from forum)

Change alert box color to success

Merge pull request #2321 from ch1c4um/Fix_dns_resolver

HTML Compliance - System / Package Manager / Available Packages

Bad value #search-panel .panel-body for attribute href on element a: Illegal character in fragment: space is not allowed.
<a data-toggle="collapse" href="#search-panel .panel-body" name="search-panel">...

Fixed #5697

Merge pull request #2327 from NOYB/HTML_Compliance_-_System_/_Package_Manager_/_Available_Packages

Merge pull request #2326 from NOYB/HTML_Compliance_-_System_/_Certicate_/_CAs

Alternative to PR 2324 - Remove unneeded div

HTML Compliance - System / Package Manager / Available Packages

Stray tbody, table, and div tag ends when list empty.
Close php tag.

HTML Compliance - System / Certicate / CAs

Close div tag
Close php tag

Redundant logic tests in a range check

The logic here is redundant. It tests IP1<START || IP2<START || IP1>END || IP2>END. Then it tests if IP1<IP2 unsigned.

If the latter test succeeds (ie test that first) then IP1>=START must imply IP2>=START and IP2<=END must imply IP1<=END. In other words we only need to test:...