pfSense

Fixed blank space caused by hidden input

Remove additional_files_needed entries

Only specify auth-user-pass for TLS mode. Ticket #5941

Merge pull request #2693 from NOYB/Diagnostics_/_Tables_-_URL_Table_Aliases

Merge pull request #2692 from NOYB/HTML_Compliance_-_Services_Status_Widget

Fix unbound.inc so zero value for *_num_tcp is honored

In the Unbound documentation, it is noted that setting "outgoing-num-tcp" to "0" disables TCP queries. In testing I noticed that although I could select & save a value of "0" in the Unbound Advanced Config, the actual value written to /var/unbound/unbound.conf was still the default "10". Apparently in PHP, a value of "0" still tests "false" for !empty(). Changing the test to isset() seems to fix the issue.

Diagnostics / Tables - URL Table Aliases

Handle URL table aliases similar to bogons tables. Suppress record remove buttons.
Update (download) only the selected URL table alias instead of all of them.
Retain full line comments in downloaded URL table files so we can view and use them....

HTML Compliance - Services Status Widget

The for attribute of the label element must refer to a non-hidden form control.
There is no corresponding target of this for attribute. Removing.

Update license page. Ticket #5903

Update license page. Ticket #5903

ICMPv6 Firewall Log Display - Fixes 5933

ICMPv6 logging was not being displayed in firewall log.

Don't unnecessarily exclude IPv6 addresses here. See ticket #5931

Allow ":" in the route destination network, otherwise an IPv6 address cannot be entered.

Merge pull request #2688 from NOYB/Don't_Leave_Ancestor(s)_Selected

Remove callsto updateWidget since widget status is now saved explicitly via the save icon in hte breadcrumbbar.

Don't Leave Ancestor(s) Selected

Fix OpenVPN ifconfig. Ticket #5930

Show correct direction for in states

Remove unnecessary includes. Remove an always true if().

No functional changes.

Makes interface_bring_down() remove all the CARP and IP aliases from interface.

Ticket #5913

Fixes the PPP interface list. List all physical interfaces + VLANs and not the assigned ports.

Ticket #5925

It is not necessary check for CARP interfaces.

Hide additional bootp options when it's disabled, fixes #5914

Fix indent

Remove old rc.dhclient_cron that hasn't been used in many years

Add a space between the gateway name and IP

Move the DHCPv6 apply action into a function. Capture the apply and save actions separately and only perform the required task. Fixes #5910

Do not offer the "CA" type when creating a certificate. CAs should only be made on the CAs tab. Fixes #5924

Fix a typo.

Add the upgrade code for OpenBGPd and Quagga OSPF packages.

Ticket #5884

Correct ALTQ interface test for ix interfaces, fixes #5923

Fix the rc.carpmaster and rc.carpbackup scripts.

Now, they look for main CARP IP and IP aliases running on supplied vhid.

Remove unnecessary code. CARP isn't a interface anymore, radvd cannot run on CARP IPs.

Make link_interface_to_vips() also return the IP aliases on the specified vhid.

Fix indent

Use high level functions

Use high level functions

Check the end of range to make sure it's inside subnet too

Use high level functions

Simplify logic and use high level functions

Merge pull request #2409 from stilez/patch-13

Deletes Even if Say Cancel - Fixes 5907

Touch Action CSS
Bootstrap is applying this to the .btn class. But that doesn't cover everything for us nor does it make possible to double tap firewall rules (table rows & cells) to edit.

"W3C added a new value for touch-action to the pointer events specification: manipulation."...

Merge pull request #2681 from NOYB/Status_/_System_Logs_-_Manage_Log_Form_Submission_Access

Print help text when passed as "description" for a select_source.

Merge pull request #2682 from NewEraCracker/array-initialization-fix

Firewall / Rules - Copy/Edit - Interface Change - Separators Update

Correct separators update position when changing interface during a copy or edit.

Initialize variables correctly

1) gmirror.inc: there are two calls to exec(), those calls expect the 2nd parameter to be an array, this commit initializes the variables correctly. 2) system.php: variable dnslist is used as an array without prior type initialization. This is one of the causes for apparent PR #2680 problems (which led to its reversal). Note: After this commit is merged PR #2680 may be safely reapplied for more tough code.

Revert PR 2680

Merge branch 'master' of github.com:dennypage/pfsense

• 'master' of github.com:dennypage/pfsense:
  Add stddev information to the quality graphs.
  Update config version to trigger upgrade of rrd files
  Add standard deviation to quality rrd files

Status / System Logs - Manage Log Form Submission Access

If the user does not have access to status logs settings page, then don't accept a manage log form submission.

Fixes the handling of MTU with VLANs and PPPoE.

Ticket #5857

Makes get_real_interface() work with VLAN too.

This makes get_parent_interface() safe to use with VLANs.

Properly check the parent's MTU when changing a VLAN MTU.

Fixes the editing of PPP entries.

Fixes the PHP warnings, hide/unhide of selected interface(s) fields, improve the MTU check.

If exist, print the friendly interface name next to device name.

Fixed #5914
COntrol panels via jQuery for more control

Merge pull request #2678 from TheUbuntuGuy/master

Merge pull request #2670 from NOYB/HTML_Compliance_-_Diagnostics_/_Configuration_History

Merge pull request #2680 from phil-davis/patch-1

Fix #5916 Do not complain about duplicated blank DNS server entries

Reported by redmine https://redmine.pfsense.org/issues/5916

Write_Config Function Notes Update

Add write_config_only input arg to write_config function notes.

Fix regression on general setup page preventing save with blank DNS servers

Introduced in f700dc9

Merge pull request #2677 from NOYB/Title_Bar_Shortcuts_Privileges

Merge pull request #2676 from NOYB/Status_/_System_Logs_-_Manage_Logs_Panel_Error

Status / System Logs - Manage Logs Panel Access

If the user does not have access to status logs settings page, then exclude the manage log panel from the page.

Title Bar Shortcuts Privileges

Only display title bar shortcuts the user has privileges for.
Confusing and inconvenient being sent to the home page when clicking on those. Then have to browse back to where you were.

Don't allow an IP to be configured multiple times as a DNS server. Ticket #5915

Skip configuring dhcpdv6 when the interface doesn't have a valid subnet (like track6 where PD hasn't been obtained). Ticket #3029

Only enable DHCPv6 server for track6 interfaces where it's enabled. Ticket #3029

Status / System Logs - Manage Logs Panel Error

Change test to use the correct variable. Otherwise it will never be true and form will not be kept open when there is input error.

Allow disabling of radvd with track6 interfaces. Ticket #3029

Add config upgrade code to enable and configure DHCPv6 server and radvd where track6 is in use, as they were automatically configured previously. Add same config to default config.xml to retain existing behavior there. Ticket #3029

replaced original copyright message from 2005 / Espen Johansen

clean up text

DHCPv6 clean ups for PD. Ticket #3029

Merge branch 'master' of https://github.com/pfsense/pfsense

Simplify check for which interfaces can have RAs, and show track6 interfaces without having to enable DHCPv6 server. Ticket #3029

Don't trigger an interface mismatch for lagg interfaces, they may not exist at time of config restore. Ticket #5892

Validate URL table ports aliases exist before using them in a rule. Ticket #5845

Allow user to dismiss diag_edit messages

Previously the close 'x' was displayed, but after this code was changed to use print_info_box() the close 'x' was not being displayed.

Changes for diag_edit rename

Add stddev information to the quality graphs.

Merge branch 'master' of https://github.com/pfsense/pfsense

Fixed #5911

Fix this test. Fixes #5909

Addedexec.php and edit.php (which are now diag_command.php and diag_edit.php)

Fix typo in diag_command

Renamed exec.php and edit.php

Clarify text, ticket #4463

Fix Dashboard privilege edge case and show full Help menu to users with the Help privilege. Fixes #5909

Restore infoblock functionality for now

Fixed #5908

Fix #3029

Teach system_hosts_generate() to deal with PD length != 64

Ticket #3029

Fix DHCPv6 GUI to work with PD length != 64

Ticket #3029

Teach services_dhcpdv6_configure() to deal with PD length != 64

Ticket #3029

Teach merge_ipv6_delegated_prefix() to deal with other PD sizes

Ticket #3029

Import patch from @Robert-Nelson to enable DHCPv6 Server/RA to
interfaces configured to track DHCP-PD

This patch only works for PD with length 64

Internationalize etc inc uvx

HTML Compliance - Diagnostics / Configuration History

End tag form seen, but there were open elements. Unclosed element div.
Swap places between closing div and form tag.

Clarify log, it's not really "ignoring" it.