Fix field lengths for IPv6 addresses
Make it possible to set the default gateway bit for 1 ipv4 gateway and 1 ipv6 gateway
Make the subnet check failure better readable
Merge remote branch 'upstream/master'
Conflicts: etc/inc/interfaces.inc etc/inc/system.inc
fix text
Conflicts: etc/inc/interfaces.inc etc/inc/vslb.inc usr/local/www/interfaces.php
When adding/editing a gateway, check IP alias subnets, too. Fixes #1015
Conflicts: etc/inc/filter.inc etc/inc/system.inc usr/local/www/interfaces.php usr/local/www/interfaces_gif_edit.php
Bring in XSS id fixes from m0n0wall
Verify that we validate against a ipv6 subnet properly. This should help for static route gateways
Allow for configuring a IPv6 address on the interfaces page.Add code to verify a ipv6 addressLet is_ipaddr() return true on a v4 and v6 address.Change system gateways edit to fetch the global ipv6 interface ipv6 addresses and subnetsThe current ipv6 function might need folding into filter_var() when that catches some documented corner cases....
Simplify this code so it's obvious what we're really testing for.
Should be no functional change here.
Fix intended behaviour when the default gateway changes interface.
This breaks the code because the ASSUMPTION is to reload the gateway interface that was a defaultgw previously and not the interface that just became defaultgw. Mostly for dynamic connections like dhcp/ppp*
Pointy-hat: gnhb
Revert "Update code to actually accomplish the intended behavior of NOT reloading the interface"...
Update code to actually accomplish the intended behavior of NOT reloading the interfaceif not necessary when a GW record is saved.
Do not allow a gateway to be renamed. Possibly a better solution is to rename the gateway in all pointed places!
Handle the cases to not save data on config better.
Make sure we do not overwrite the gateway stored in config with a dynamic gateway info. Correct POST var name(Found by ghnb). Also correctly reload only the defaultgw interface changed only if it is different than the present one.
Fix the problem of not saving data when most of the information is not being posted. Also do not disable any field anymore to allow people to choose static gateways for dynamic interfaces. Also do not save any information when the user Clicks save but has not posted any information not known already. Do not prevent to post a dynamic value for gateway on an interface that is configured with static ip.
We don't store monitor ip in the <interfaces> config any more.
Requested by cbuechler in ticket #919.
When a dynamic interface is up, we still need to report that it's "dynamic" to this GUI in system_gateways_edit.php.
If user edits a dynamic gateway that is up, the gateway IP address (reported by return_gateways_array) will end upin the "Gateway" field, and then the gateway will get saved as a static gateway unless user manually changes field...
Revert previous change to enter a hidden value when interface is disabled. GHNB broke this on revision 58611e3a1da07a33c6cf65401ad3edf278190e75 and it does not make sense.
Remove forgotten code.
Initialize variable properly. Handle the case when the interfaces select box is disabled and it will not be posted(Reported-by: ghnb
Fixes #919 by properly saving <gateway> field as "dynamic"
`
Oops bring back this code too.
Actually this part should not have been committed at all.
Fix gettext! Needed here?!
Bring code up to speed with latest world.
Cleanup code.
Correct my email address, adjust copyright to 2010
fix gettext
Correctly check when to actually save dynamic gateways or not.
Ensure that monitor IP stays blank when editing a system dynamic gateway.
Default to "dynamic" for a dynamic gateway.
Add status links to gateway/route pages.
Move the settings of down/latency/loss to per gateway. This allows more fine grained control on gateways.
Adding missing gettext() calls
Merge remote branch 'mainline/master'
Conflicts: usr/local/www/system_gateway_groups.php usr/local/www/system_gateway_groups_edit.php usr/local/www/system_gateways_edit.php
Save gateway data when weight changes on dynamic gateways.
Add gateways validation code before deleteing. This prevents footshooting especially with Gateway Groups.
Ticket #506. Correctly save dynamic gateways extra parameters.
Allow for each gateway a weight to be choosen if the gateway has to be used in Gateway groups. This will create that many entries in the route-to statement as the weight says.
Adding gettext() call
Adding gettext() calls
Fix gettext issues
Reviewing gettext() implementation
Implement gettext()
Ticket #517. Fix saving of monitorip in dynamic interface cases.
Correctly configure the default route addition when interfaces are configured for pppoe/pptp. Handle in system routing configure dynamic interfaces. Also when chaning or configuring the defaultgw reconfigure the underlying interface, this helps when this interfaces are dynamics one.
Correct typo in function name
Mute route delete message, regenerate resolv.conf as this also corrects static routes to the DNS servers.
Ticket #303. Correctly retain the interface in case or validation errors.
Allow editing entries that are not system/dynamic ones even though their gateway is specified as dynamic.
Ticket #303. Fix gateway address checking.
Check if the gateway if part of the interface subnet only if we can get the interface ip address.
Ticket #303. Fix very many bugs in this code. From strings that were not quoted propperly to completely broken code paths.
Ticket #305. Grey out the gateway when it is a dynamic one.
Revert "Ticket #303. The friendly interface is saved on the config and not the real one."
This reverts commit 889cb3241aa6bd192c42147316faf503c559fce2.
Revert "Ticket #303. Use the config item when editing gateways so all fields are correctly processed."
This reverts commit 9c10b00f3eb22f45e2fb704ca9f1786942d69ad8.
Ticket #303. Use the config item when editing gateways so all fields are correctly processed.
Ticket #303. The friendly interface is saved on the config and not the real one.
Do not automatically save the monitor if it is not explicitly filled in. Leave the monitor field empty when it isnot filled in. Show a configured monitor address on the system_gateways.php page.
Unbreak adding gateway #238
Partial rewrite of gateway code, now partially facilitates dynamic interfaces- Upgrade code takes different naming into account- Add gateway entries for dynamic interfaces- Rewrite status array to also support dynamic interfaces.- Always use unique localhost monitor IP addresses for down dynamic interfaces...
allow unlimited gateways to have a blank monitor IP (i.e. monitor IP == gateway IP)
Do no throw a duplicate IP address warning when creating a new entry from a existing gateway which was previously aautomatically added gateway entry.- clarify comment message
fixup text
clarify input_errors
fix input validation of gateways. Ticket #173
clarify input validation message
Fix missing ).
Remove extra ) which broke the page
Add input validation to check if the gateway IP is in the local subnet for that interface.Needs testing, no idea if this works for ppp or pppoe interfaces.
in_array() is needle, haystack. Not the othe way round which throws a wrong datatype warning.
Issue 166
Add pfSense_BUILDER_BINARIES: and pfSense_MODULE:. Adjust Copyright to include 2009 on files that I have asserted (C) on
Set default gateway correctly by checking for yes or on
Add missing include
Select lan interface correctly when editing
Revert "Call system_routing_configure after changes"
This reverts commit 80efb6d634e23c05a11e87b53bda9cbd9f598d11.
Call system_routing_configure after changes
allow a diff ip address for gateway monitor
Add input validation on the gateway groups page as well, fix the check on the gateways page.
Add input validation on the gateway name field.We apply the same input validation as we use from the aliases page as we do not want a - in the name nor spaces.
Revert "Merge IPv6 changes"
This reverts commit f193cf92b2c925a2f3f71a713d766efd1e4d81e0.
Revert "Unbreak System Gateways page. I'll just add back the changes from the old CVS repo afterwards."
This reverts commit e31534731ec7de3d2599cf669e065b1ec52281a0.
allow IPv4 gateways to be added via AJAX
Unbreak System Gateways page. I'll just add back the changes from the old CVS repo afterwards.
Merge IPv6 changes
Remove broken duplicate check
Fix system gateways editing
Do not allow duplicate gateway names
Add isAjax handle
Do not keep spawning new entries when trying to edit.
Improve duplicate check
Allow duplication of system gateways for easier adding and less typing.
Fix unable to save manual gateway entry.
Remove debugging