pfSense

Remove wrong code left from copy/paste

Use array id to delete phase2, it will simplify changes I'm working on and will commit soon

Change functions from row_toggle.js to work with different field names, keeping the old behaviour as default. This is necessary to have more than one group of fields in the same page

fix menu wrap on non-default themes

fix menu wrap on pfense_ng and pfsense_ng_fs

Improvements on IPsec GUI (Ticket #3328):

• Allow to reorder phase1 items
• Allow to remove multiple phase1 items
• Add an icon to quickly toggle enable/disable status of p1 items
• Print P1 header only once and remove space between items
• Fix table border when P2 items are expanded

Remove uneeded variables

Remove unused variables

Fix indent and whitespace

Fix subnet display for IPsec status. Ticket #3826

id changes every time ipsec tunnel disconnects and reconnect, need to use peerconfig to get correct description. Ticket #3826

Fix traffic graph widget default autoscale

so the radio buttons selection allows only 1 to be selected and the setting is then saved.
Forum: https://forum.pfsense.org/index.php?topic=81166.msg

Remove some redundancy and simplify changes made on last commit

Replace GET by POST, it fixes #3833

Fix comment in css

Do not reconfigure dhcpd twice on secondary after config sync. Fixes #3797

Merge pull request #1261 from CharlieMarshall/improveInter

Remove blank line if only an ipv6 address is in use

Merge pull request #1268 from CharlieMarshall/gatewayWidget

improve/tidy up interfaces widget

fix typo

Fix indent whitespaces

Fix phase2 removal, p2index points to unique ide and not to array index

Alias name cannot have more than 31 chars, add maxlength here just as an extra check. Ticket #3827

improve look of gateways widget

Fix #3807:

• When changing a pre existing VIP, use previous configured interface
  for checking, this fixes the issue that happens when you try to change
  a VIP to a new interface.
• Use the right interface name, only carp uses _vipN suffix

Merge pull request #1267 from CharlieMarshall/fixTrafficGraph

fix display of traffic graph

Remove 'reject' action from filter logs since reject and block are the same on logs, it should fix #3825

move if/else to switch for readability

fix typo

Fix text description for interface mismatch, fixes #3820

Revert "improve/tidy up interfaces widget"

I pushed it accidentally, will wait a fixed version of the patch

This reverts commit b75192e3bc851e80d6bfd33c12849dbc269039fb.

Merge pull request #1259 from CharlieMarshall/improveInter

improve/tidy up interfaces widget

Add missing s to solve the issue reported on https://forum.pfsense.org/index.php?topic=80722.new#new

Move the fetching of a package's config file and additional files to separate functions, and then have the "xml" package button perform these so that it is not only a redundant copy of the "pkg" reinstall button. This can help ensure a package files are in a known-good state before other actions are performed, in case the deinstall would fail or behave erratically due to other files being missing.

fix gold alignment and redirect

Revert "make gold link more visable"

This reverts commit a03943d203441a87ea9c01f383d451dfc921bdd2.

make gold link more visable

Do this check now that hash algos can be empty

Correct the ipsec status pages to show proper information as needed.

Use proper path to setkey now that ipsec-tools are not used anymore

Correct the functions for returning tunnel status to use strongswan status reports

Allow HASH algorithms to be empty for phase2 in case the encryption one is AES-GCM

Ensure this is always an array to avoid a PHP error from foreach.

Do not reset source and destination port range values when it's an associated rule created by nat port forward. It fixes #3778

Require click-through POST confirmation when restoring or deleting a configuation from the backup history page.

Do not execute DNS resolution on GET, only pre-fill Host box so the user can press the button to execute. Turn alias creation links into submit buttons for POST. While here, remove some backticks and simplify a little.

Shorten the wait at "reload" in startup wizard to 5 seconds from 60. That's more than adequate for current systems, no need to make people sit there for 1 minute. Many likely click out via the logo and miss the last screen entirely.

Change the logic of the vpn config generation to make connectivity more stable especially ipsec. Also for IKEv1 just generate the policies and only on traffic start them.

Encode interface/VIP descriptions before displaying them on the NTP daemon settings.

Encode interface/VIP descriptions before displaying them on the GRE and GIF pages also;
While here, the GRE page was missing IP aliases from its list of bind IPs, add it in.

Encode the detail field of an alias entry before displaying its contents back to the user.

Escape the individual dnsmasq advanced/custom options

Allow to add ipalias vip to lo0, it should fix #3773

Use GPS type presets only to pre-set values then user can change it. After user changes, save type always as Custom to avoid overwriting values when user attempt to edit. It fixes #3782

More non-functional changes to make code more readable

Fix indent and spaces

This if is unecessary since input_errors is unset in the line above

Fix indent and whitespaces

Make sure there are not empty options on dst select to avoid creating empty user or group. This issue was introduced by b4e9a4da

Fix select name

Fix input validation logic on diag_testport.php, escape more shell arguments for good measure

Fix #3790. Fix IPv6 Prefix ID check using interface user choose before save

Use a uniqid() to track phase2 entries to avoid confustion and various mistakes when modifying and editing them.

Add message about Gold to setup wizard and menu/link to Gold signup.

Fix #3575, do not allow user to set IPs for GRE interfaces on interface edit page.

Fix redirect after editing permissions

Disable bandwidth checks for PRIQ, it should fix #3537

Fix field name that cannot contain spaces, and use displayname

Fix scheduler field name

Fix field name that cannot contain spaces, and use displayname

Fix field name

Strict checks for number of WANs and LANs on wizard

Fix number of WAN / LAN interfaces detection for dedicated wizard

Try to guess number of WANs

Try to guess number of WANs and LANs

Fix number of WAN and LAN connections check

Just show right type of interfaces (LAN/WAN) on traffic shapper wizards, it fixes #3535

Remove 'multi lan/single wan' and 'multi wan/single lan' traffic shaper wizards, multi lan/wan can be used to replace any of them

Replace exec() and system() calls by internal functions

Fix indent and whitespaces

Fix indent and whitespaces

Fix indent and whitespaces

Use SERVER_NAME instead of HTTP_HOST env var, it doesn't have port, then it avoids wizard end point to wrong IPv6 address. It should fix #3550

System: Firmware: Settings

Updater Settings Tab
system_firmware_settings.php

Line 488, Column 43: value of attribute "type" cannot be "input"; must be one of "text", "password", "checkbox", "radio", "submit", "reset", "file", "hidden", "image", "button"...

Merge pull request #1232 from N0YB/Widget_Gateways

Merge pull request #1235 from N0YB/Mixed_Case_Hostname

Merge pull request #1236 from N0YB/Widget_Services_Status

Merge pull request #1237 from N0YB/XHTML_Compliance_System_Menu

Review all parameters on unbound main GUI, fix boolean params and add missing ones. Also make it work properly with 'apply'

Use the apply trigger for unbound acls to avoid restart unbound every time

Fix indent and whitespaces

Some GUI tweaks on unbound main screen

Improve unbound ACL edit page to use correct classes and jquery.ipv4v6ify.js

Fix acl item removal

Few GUI tweaks on unbound ACL page

Fix multiple issues on unbound advanced options GUI:

- Drop many wrong key assignments to pconfig
- Add missing keys to pconfig
- Deal fine with boolean parameters
- Mark subsystem dirty to require apply button
- Drop calls to enable_change()
- Remove unecessary js function enable_change()...

Allow hostnames in bulk import since they are valid entries in a network type alias.