pfSense

Fixed 5225

Fixed 5225
Programmer had mangled element name in if($_POST) section

Introduce read_xml_tag.sh

Create /usr/local/sbin/read_xml_tag.sh, that will read a xml tag from
config file using xmllint. Replace all direct read using cat, grep, sed,
... by this script

Fix #5220, setup PHP timezone:

- Get defined zoneinfo in the following order:
- /var/db/zoneinfo
- /cf/conf/config.xml
- /etc/inc/globals_override.inc
- /etc/inc/globals.inc

Only need to check 'vip' here.

fix comment typo Phil Davis noted

Can't use continue here as it continues the foreach, which skips the "ipfw zone" command, breaking CP for any system that doesn't have VIPs defined.

Restore item accidentaly removed on last commit

Remove timezone from default config, we have a definition in globais.inc now

Remove /usr/share/zoneinfo.tgz and use FreeBSD stock zoneinfo. It fixes #4726

One more hardcoded pfSense name

Cert fields should be used for EAP-RADIUS as well.

Removed bogus array_merge()

Fixed bogus array_merge in localid_type selector

Fixed incorrect encryption bits selectors
Hide Remote network if mobile

Fix detection of mobile IPsec P1 when editing.

time for 2.3-ALPHA

Use product_name global variable in more places

Consider globals_override.inc and replace hard coded pfSense string by product_name

Fixed #5127
Don't "foreach($config['menus'])" if there are no menus defined

Corrected page title (which was using incorect PHP format)

Create symlinks during the boot for nanobsd

Corrected logo hyperlink
Changed Jumbotron font to white so you can actually read the text

Make sure pkg db and cache is safe on nanobsd and on pfSense with /var mounted as MFS

pkg 1.6.x upgrade command called with -q is now respecting it

Remove cust_fixup_nanobsd(), similar actions are done at specific create image functions, do the same for nanobsd

Suppress progreess bar until package system revision is complete

Wizard system completed and tested agains all wizard files
Progress bar added to show progess through wizard steps

Use the appropriate parent interface with gateway groups using CARP VIPs.
Ticket #4990

Do a service reload of dyndns when changing gateways in case something has
changed. Ticket #5214

Bootstrap conversion mostly complete.
Tested with setupwizard.xml and looks good. Couple more thankgs to check so don't test yet please.

Disable DHS as a dynamic DNS provider option. It's never worked, and
fixing is more complex than just fixing the variable screw up and
disabling cert validation for their SSLLabs F-graded site. Updates made on
their site even take quite some time to be reflected, seems to be a...

Call correct script on upgrade process and obsolete the old version

Do not run pkg update between first and second step of upgrade process

Remove old references to undefined variable firmwarelock

Call exit after detect another instance is already running, otherwise it would end up deleting pid file

Detect when pkg must be upgraded and do it early, followed by a pkg update to make sure metadata is updated

Fixed #5209

Fixed #5206
Completes conversion of the pkg* files

Fixed #5212

Fil;e conversion complete. Tested against multiple packages

Replace macros by variables after install bsdinstaller

Install only bsdinstaller in install_bsdinstaller()

Add dh-parameters files to the nanobsd exclude_files as well. Ticket #4816

Use self rather than any in auto-added IPsec rules to prevent
over-matching. Ticket #5211

Make sure FreeBSD src is available to setup pkg repo

Ensure this only contains a partial name, not a path, before attempting to craft a full name and read the file. Fixes #5203.

Redmine #5200 be less aggressive about DHCP Pool Notice V2

This one will log_error() the DHCP pool message when it detects the inconsistency at the end of the setup wizard during reload all.
That way it can still be seen in the system log that this happened, and one day someone might chase down all the steps in the "reload all" process....

Merge pull request #1940 from doktornotor/patch-2

Merge pull request #1937 from heper/patch-2

Look for src and ports repo in the same git server

Set FreeBSD src and ports repo to use github or git.pfmechanics.com based on local clone of pfSense repo

Fix comment language

Remove syslog.conf entries on package uninstall (Bug #5210)

The remove_text_from_file() is not needed at all. However, system_syslogd_start() must be run after the package entries are gone from config.xml, otherwise system_syslogd_start() just re-adds the (now almost removed) package logging configuration from there.

add 'interface' column to lease_counter table

Cleanup cache and stale packages after install/delete

Add missing ;;

Initial conversion of the file. Most functions completed and tested, but more testing remains

Fix logic to set EVENT_PIPE

Add -h, to show help

Define EVENT_PIPE using a parameter, -p

Print return code when _GUI_CALL is not empty, used by GUI to check rc of a process that runs in bg

Replace direct calls to exit by _exit

Remove unnecessary :- from variables that are between quotes

Set environment var EVENT_PIPE, used by pkg to write out progress in json format

Rename functions and variables to improve readability, no functional changes

Use compare_version() for kernel_pkg checks

Add pfSense-upgrade parameters -i/-r to install or remove packages

Change usage() to use regular echo() and print to stderr

Relocate global variables definitions, no functional changes

Relocate main block and leave all functions in the beggining

Check if update needs to run inside update()

Update repository metadata hourly

Respect .gitignore when call git clean

rsync is required

Fixed #5189

If an error happened, just abort, there is no reason to ask user to press enter

Ticket #5204 a clean up pass of the jquery sections

Automatically set meta pkgs version based on timestamp for snapshots

Clarify the use of noshuntlaninterfaces and autoexcludelanaddress

The existing code here looks like it should be working correctly. Maybe it would help future maintainers if the field name used for gathering the data value in the UI and $POSTing it is changed to autoexcludelanaddress. Then the code reads a bit more easily where the logic value of noshuntlaninterfaces and autoexcludelanaddress is swapped back and forth.

Reset the value of a package field before this test in case it has no default. Fixes #5199

Fixed #5192
Element names corrected

Updated tables to responsive format
Added table style classes
Changed array keys to descriptive names
Updated indenting/style

Merge pull request #1932 from heper/patch-2

Comment typo fix

Fixed #5146
Bootstrap conversion complete and unit tested

Merge pull request #1799 from jlduran/svg-mimetype

Merge pull request #1934 from phil-davis/patch-5

service_dhcp_edit.php fixes from code inspection

To save you some time in testing and fixing, here are the bugs I noticed by code inspection.

File converted but not yet checked/tested

Add -u option to pfSense-upgrade

- New u option, to run pkg update
Move upgrade action code to upgrade()
- Rename first_step to upgrade_first_step
- Rename second_step to upgrade_second_step
- Do not call update when upgrade is called

Verify if pkg is (un)locked before (un)lock it

Disable trap on _exit()

Declare logfile earlier

Make usega() more informative

Teach _exit() to return 1st parameter, replace exit calls by _exit and move trap to start of main block

Track pfSense-upgrade pidfile to avoid running 2 instances simultaneosly

dhcp_lease_counter for master

https://redmine.pfsense.org/issues/5186

Fixed #5189

Abort when 'pkg update' fails