pfSense

Update the Copyright notice for pfSense.

routing, support use of recursive network aliases in static routes

Make is_ipaddrv6() compatible with is_ipaddrv4().

Only the IP address must be accepted, address with netmasks do not qualify.

Ticket #8024

Fix typo in function name: insterface_is_qinq -> interface_is_qinq

Fix a typo.

The members of a LAGG cannot be assigned, used in VLANs, QinQ, or PPP.

This commit removes the LAGG members from the list of available interfaces.

Do not return QinQ interfaces in the physical interface list.

Fix the QinQ support.

Bring the QinQ support to the VLAN dotted format.

To avoid breaks third party software (such as dhcpd), we silently ignore the interfaces with names bigger than the maximum size in FreeBSD.

Ticket #7942

Change the VLAN inteface names to use the 'dotted' format of FreeBSD, which is shorter and helps to keep the interface name smaller than the limit (16).

This fixes the 4 digit VLAN issues when the NIC name is 6 bytes long.

Ticket #294

Refactor get_configured_interface_list remove unused parameter

Refactor get_configured_interface_list_by_realif remove unused parameter

Refactor get_configured_interface_with_descr remove unused parameter

Merge pull request #3685 from phil-davis/sort-if-names

Merge pull request #3635 from doktornotor/patch-24

Merge pull request #3614 from doktornotor/patch-16

Add user option to sort interface names

Refactor is_port_or functions

Add underscores to is_port* function names

Provide functions for checking port range alias combinations

Merge pull request #3642 from phil-davis/icmp-type-skip-redmine-7372

Merge pull request #3529 from Chrisc-c-c/Fix-List-Sort-Order

Fix #7372 Cannot filter ICMP Type SKIP

Add QinQ interfaces to the list of interfaces not to check (Bug #4669)

Remove dummy config_lock() and config_unlock() functions

Been no-op for ages (https://github.com/pfsense/pfsense/commit/0027de0a544438f146cfc94f005fd6f4ba9f94d7).

Add a function to normalize CR and CRLF-style newlines to Unix LF

See Bug #5306.

Fix incorrect sorting for various dropdown lists.

5th try
- change $do_ping default value to 'true' (which emulates the previous default behavior) to avoid any unexpected results

4th attempt!
- Reworked based on recent comments from @rbgarga

3rd try!
- incorporate suggestions from @rbgarga with slight modification

2nd try. . .

/etc/inc/util.inc:
- arp_get_mac_by_ip() updated to support IPv6
- attempt at code streamline

/usr/local/www/services_dhcp_edit.php:
- streamline code, now just a simple call to arp_get_mac_by_ip()

Introduce is_intrange() to validate a range of integers delimited by ':' or '-'

Merge pull request #3414 from phil-davis/ipv6-compress

Remove unused variable $cfglckkeyconsumers

Force compress for where_is_ipaddr_configured

Always force compress when calling Net_IPv6

Make sure file exists before try to open it

Fix style

format_DUID array_walk

format_DUID use str_pad

format_DUID review

Helper format_duid() for DUID input

Return partial MAC address matching support to is_macaddr(). Fixes #7088

Merge pull request #3304 from marjohn56/master

Changes as requested

Fix #3560 correctly handle disabled static routes

1) util.inc - add parameter to get_staticroutes() so the caller can
choose to see all static routes or only the ones that are currently
enabled.
2) filter.inc - just process enabled static routes when making direct...

tidy

Added get_duid_from_file() function

Used in System->Advanced->Networking to display the current DUID in the placeholder for setting the DUID.

User Defined DUID

User may define a DUID to use in System->Advanced->Networking. The
entered DUID is validated for composition and length, if valid it is
stored in the config.xml. On call of wan_dhcp6_configure() the DUID is
written to file to be read by dhcp6c on launch.

validateipaddr update return value comments

validateipaddr use constants from globals.inc

validateipaddr return address family

Enhanced the return values from validateipaddr() so the caller can know if the validated address is IPv4 or IPv6 (or an alias if that check was requested). That makes it a better replacement for is_ipaddr().

Merge pull request #3281 from phil-davis/patch-7

validateipaddr enhance flexibility for translation

By using sprintf() we can allow for some language where the label text does not fit at the start of the sentence.

validateipaddr code format

Fix comment

Added a function validateipaddr() use as:
// Validate a network address
// $addr: the address to validate
// $type: IPV4|IPV6|IPV4V6
// $label: the label used by the GUI to display this value. Required to compose an error message
// $err_msg: pointer to the callers error message array so that error messages can be added to it here...

Revise update_filter_relaod_status() function to append status messages rather than overwrite the file

Check if pidfile is valid before try to send signal

Update the variable with the round() return otherwise it does not has any effect.

Found while testing Ticket #6272.

Fix is_macaddr().

Hexadecimal numbers without the '0' padding are also valid, e.g:

a:b:c:d:e:f

Fix #6828

Until 2.3.x pfSense carried a patch that changed the behavior of 'route
change' command, making it add the route when it fails to change.
On 2.4 this patch was removed and will not be added back. This change
adjust PHP code to deal with route add / change and make it work...

Add extra validations on is_inrange_v⁴⁶

Verify if addresses are valid IP address before convert them to make
numeric comparison.

While here, adjust indent.

Inspired by: @phil-davis patch at PR #3189

Make unlink_if_exists return true/false

This allows the caller to do a single "atomic" call to unlink_if_exists.
If it returns true, then they know that the file existed and that it has
been unlinked successfully.
This should help avoid race conditions where multiple code paths try...

Deprecate nanobsd platform and remove all conditionals that uses it

Retire refcount functions. They are not used anymore

Move copyright from ESF to Netgate

Ticket #3734: Add function to convert IPv6 address <-> binary

- ip6_to_bin() and bin_to_ip6() are copies obtained from pear-Net_IPv6
since the version available in the class is protected and we don't
want to add more patches to thirdy part software. If upstream accept...

Silence pgrep stderr when pidfile contains an invalid PID

Code style and comments

No functional change - just making style consistent

Move to Apache License 2.0

Review license / copyright on all files (final round)

Review license / copyright on all files (1st round)

Merge pull request #3007 from stilez/patch-34

Leave an empty file for URL Table aliases that return an empty file, and include it in the ruleset regardless so it doesn't generate any filter errors. Ticket #6181

Merge pull request #2764 from NewEraCracker/redmine-6011

bring back subnetv4_expand function used by pfblockerng

simplify subnet_size()

is_ipaddr() returns the type of IP if valid. Use this to simplify the function

Remove subnet_expand()

Function isn't used in main or packages repo, and in any case would need a complete rewrite to handle IPv6.

Fix Redmine #6011

This will add linklocal fallback where no IPv6 is otherwise configured to allow login using this IPs

Rename /etc/devd.conf -> /etc/pfSense-devd.conf and change start_devd()

This was correct already. Revert "Allow uppercase letters in is_unqualified_hostname as well."

This reverts commit 94ccdcb8a4d6f7789fd39c4b6e9876bb689de9a4.

Allow uppercase letters in is_unqualified_hostname as well.

Provide better messages for invalid alias name errors

Includes - Remove Personalizations

Remove "you" personalizations.

Move NTP access restrictions to their own tab and add the ability to craft custom restrictions for arbitrary networks. Fixes #4463

Diagnostics / Tables - URL Table Aliases

Handle URL table aliases similar to bogons tables. Suppress record remove buttons.
Update (download) only the selected URL table alias instead of all of them.
Retain full line comments in downloaded URL table files so we can view and use them....

It is not necessary check for CARP interfaces.

Don't trigger an interface mismatch for lagg interfaces, they may not exist at time of config restore. Ticket #5892

Validate URL table ports aliases exist before using them in a rule. Ticket #5845

Internationalize etc inc uvx

Quote the 1st parameter (constant name) when calling define()

Simplify logic increasing value direct in hexa, PHP is smart to do it right. Spotteb by @loos-br

Implement get_v6_ptr_zones()

This function takes an IPv6 subnet and return an array containing all
DNS PTR zones

Fix the return value if no matching VIP was found.

Implement a switch that allows get_configured_vip_list() return only the selected type of VIP addresses: CARP, IP alias or all VIPs (default).

It seems that a few packages still rely on this.

Ticket #5885

Fix style issues.

Review of CARP uniqid changes.

It turns out that current CARP implementation is not much different from an IP alias.

This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...

Use IEC KiB MiB GiB TiB units

See forum https://forum.pfsense.org/index.php?topic=106547.0 for discussion if this is wanted.

Add support for TB when reporting bytes

Forum: https://forum.pfsense.org/index.php?topic=106470.0
I believe that this should work OK on both 32 and 64 bit systems. A 32-bit system will convert big values of $bytes and big numbers like 1099511627776 to float first, then do the comparison. 64-bit systems will do (int) comparisons. Either way, in the end, the value is sprintf() into a float anyway....

Merge pull request #2435 from stilez/patch-7