pfSense

Password confirmation when exporting encrypted backup file. Issue #10301

fix incorrect encrypted backup restore error handling. Issue #10179

This is 2020. Issue #9245

Use central download function

Reduce duplicated/inconsistent code by using the new download function.

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Fix the spamming of warnings about ttyv0 not being available on ARM64 devices.

While here, use a more meaningful name for the function.

Fix output buffering when downloading config backups. Fixes #9390

Correct syntax error in diag_backup.php. Fixes #9316

Force the <enableserial> on when restoring a backup on a device with serial only console.

Affects multiple devices.

Ticket #1547

Update copyright notices to 2019. Happy New Year

Fix #9071: Make sure pkg metadata is updated when repo config changes

Remove unused variable

Simplify logic to remove packages section from backup

Avoid creating or parsing a second empty rrddata tag. Fixes #8994

Fix #8911: Keep configured pkg repository when restoring config

Fix #7604: Rework pkg reinstall on config restore

- Remove old code needed to upgrade fom < 2.3 to 2.3
- Simplify logic using a single file /conf/needs_package_sync
- Create /etc/rc.package_reinstall_all, a script used to reinstall all
packages present in config but not on pkg database...

Update the Copyright notice for pfSense.

If /boot/loader.conf is not presetn check /boot/loader.conf.local.

Merge pull request #3695 from phil-davis/refactor_if_list_functions

Refactor get_configured_interface_list remove unused parameter

Refactor update_alias_names_upon_change

Add reasons to write_config() calls

Remove useless add_base_packages_menu_items() function

Not really sure what was the idea 7+ years ago, but the code just doesn't make sense now.

Merge pull request #3486 from phil-davis/diag-backup

diag_backup do not use button text for comparisons

Remove unused restore_ver from diag_backup

I cannot see where this is used any more. The functionality seems to now be done in diag_confbak

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Breadcrumb links

Add security notes for privilege assignment pages

Suggested solution for Redmine 2247

Remove all calls to conf_mount_r* functions

Simplify icmp conversion

pprior code "converts" every icmp type - of which only 3 actually get changed (rest keep same value anyhow!). If also uses a SWITCH {} construct rather than lookup + foreach, which is longer and less efficient.

Move copyright from ESF to Netgate

Move to Apache License 2.0

Review license / copyright on all files (final round)

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Allow to restore any ares of config

If the existing config does not have a particular area in it, then the user should still be able to restore it from another config.
Redmine #6144

Fixes to linguistic issues introduced by recent commits

1) encryption vs decryption typos. 2) unnecessary sprintf.

s/encryption/decryption/

Diagnostics - Remove Personalizations

Remove "you" personalizations.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

Bring all calls of print_info_box to same standard

The call itself to print_info_box already echoes the content. There is no need of additionally using the short-open-echo tag on those calls to echo return value. The previous implementation shouldn't yell any visible issues as return is 'NULL' (undefined) which casts to an empty string when printing. But, just for the sake of conformity, this changes are advisable in my opinion.

Merge pull request #2637 from k-paulius/patch-6

Switch tabs places so that active tab is the first tab

Rename 'Backup/Restore' to 'Backup & Restore' so it does not clash with breadcrumb separator.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Renamed 'Wake on LAN' to 'Wake-on-LAN'

Synchronize page titles with tab titles. Rename some titles in order to be more consistent. Convert page title to title case.

Convert section titles to title case

HTML Compliance - Diagnostics / Backup/Restore

Duplicate ID Submit.
Suppressing unused ID Submit attributes.

Improvements to the priviledge filter functionality

add call gettext function for translate

Fix product_name syntax problem in diag_backup

Notice that the old line had $g['[product_name'] - a bonus "[" - that caused the product name to not actually appear in the output.

In fixing that, I also wrapped this in sprintf() - that makes it more flexible for translation into languages where the word order of an instruction like this does not start with the verb.

FInished password hiding logic by ensuring $_POST['password'] != DMYPWD before updating

Added new addPassword method and password == password_confirm validation where required.

Take this conditional out, it wasn't enough, and we have a script example for how to handle this properly now while respecting CSRF

Only disable CSRF on diag_backup.php for the download action where it might be scripted. Other actions need its protection.

Only enable Restore Configuration if a file is selected

If the user clicks "Choose File" and then cancels the file selection dialog, disable the "Restore Configuration" button.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Code style usr local www a-e

Rename of files to better match their position in the memory structure

Fixed #5617
Fixed #5612

Redmine #4279 Package reinstall displayed when shutting down before upgrade

Use a different flag file to indicate that a package reinstall is
required after a reboot is done first. This avoids the possibility that
the user navigates in the webGUI during the time while the shutdown is...

add option to choose number of dashboard columns

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Remove $Id stuff from comment headers

Completes cleanup of header stuff for these files

Diag review

Correction per Phil Davis

First batch of copyright updates

Remove unused call to update_status_output()

Addresses #5159 by removing hide/show/disable/enable functions to included file

Ticket #5204 a clean up pass of the jquery sections

Fixed #5187
Added multipart encoding to form

Ticket #5182 change show/hide functionality

Retire PPTP server, fixes #4226:

- Remove PPTP server and all related code
- Bump config version 12.2
- Write upgrade config code to remove pptpd section and also cleanup
firewall and NAT rules using PPTP interface or src/des

Merge with bootstrap

bootstrap usr/local/www a to e minor edits

bootstrap, use require_once for classes/Form.class.php

Merge branch 'master' into bootstrap

Move main pfSense content to src/