pfSense

Merge pull request #2265 from phil-davis/r017

Merge pull request #2266 from NOYB/HTML_Compliance_-_Dashboard_-_Widget_Config_Panel

HTML Compliance - Dashboard - Widget Config Panel

Bad value #widget-system_information .panel-footer for attribute href on element a: Illegal character in fragment: not a URL code point.
Fix the widget config/wrench icon href.
Add matching widgetname id tag to widgets configuration panel div element....

Use different var name looping through columns

There is some problem with the var $i getting reset somehow somewhere
related to the include of each widget PHP code. I found that this was
doing $i = 1, $i = 2 and then $i = 2 again and I got fatal errors
because each widget code was being included twice....

HTML Compliance - Dashboard

Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.

The .panel-footer requires mod to the widgets with config options. So will submit separate commit so it can be handled independently....

Code style index.php

Couple of little bits here.

Further refinement to widget config

Fixed the broken widget config action (again)

no longer used

fixed issue where if all widgets were in col2, no col1 was created

Reverted commit 677d8bdfebace3321da677a57a0756a27332d505, PR 2218
because it broke all of the widget configuration actions.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Code style g-i

HTML Compliance - Dashboard

HTML compliance (aside from the active widgets).

Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.

Use the _title var to make the widget title

Each widget has an include file that already has the required widget
title in a var like $dyn_dns_status_title $carp_status_title etc.
Use that var to set the displayed title of the widget, rather than the
stuff that was capitalizing the file name and then having a list of...

Added status page links to widget titles

remove comment

add option to choose number of dashboard columns

Experimental changes to Form_Section() to allow the panel to be made collapsable in the same way that dashboard widgets are.
Currently used on diag_logs_filter.php ONLY

Type up SCRIPT tags

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Completed #5499

Redmine #5492 case of acronyms in widget names

I am not sure how else to do this. If someone in future writes a widget about "Smart Carp" (an intelligent species of fish) then it will get turned into "SMART CARP". The other strings are not English words, or parts of English words, so not likely to be matched wrongly in future....

Fix widgetname variables

These were wrong. But actually I don't think any widgets use this mechanism of $config['widgets']['mywidget-config'] - they seem to do their own thing making names for the keys they use in $config['widgets'] to store their settings. So I didn't find anything actually broken because of this.

Ticket #5470 fix dashboard breadcumbs

Completed #5470

Fix icon in dashboard

DEBUG code for Redmine: 5463

Ticket #5471 another convert batch to font-awesome icons

Move the widget icons back to the right

Fixed #5463

Make the display of hardware crypto information more reliable at least for AESNI.

Issue: #4911

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Correction per Phil Davis

First batch of copyright updates

Remove unnecessary functions verify_all_package_servers() and check_package_server_ssl()

Further refinement to #5223
Prevent "Store widget configutation" button from apeparing when opening/closing the available widgets panel.

Comment fix

Fixed #5280

update widget header color and fix collapse toggle

Fixed #5236

Fixed #5234
Javascript Base64 class was MIA

improve spacing for non form panels

Use product_name global variable in more places

Corrected page title (which was using incorect PHP format)

Corrected logo hyperlink
Changed Jumbotron font to white so you can actually read the text

To not try to include files that don't exist

Fix comment style

head.inc modal notices display now calls index.php via ajax to clear any pending notices

index.php code format

Merge branch 'master' into bootstrap

Move main pfSense content to src/