pfSense

Fix #7493 only check interface IP if static

(cherry picked from commit 8c6190e82f83a7907ec2757e72d9a8eac496dd61)

Adds ability to ignore DHCP offers from multiple servers
- Forum thread: https://forum.pfsense.org/index.php?topic=124046.msg705100#msg705100
- related dhclient source:
https://github.com/pfsense/FreeBSD-src/blob/devel/sbin/dhclient/clparse.c#L945

changed files:...

Example of setting required items

(cherry picked from commit 32a85c63c9411463c98a0605772b3e2c01702971)

Revert "setHelp formatting for interfaces.php"

This reverts commit e6068596baf4307fe3eb9866072800e4c23b6840.

setHelp formatting for interfaces.php

There was a fair bit of it, so I have put this in its own pull request.
1) Gets HTML out of the strings that go for translation.
2) Line 3365 - the words here about "hexadecimal" now go in the text directly in the setHelp so the translators will get access to them....

Redmine #7173 Do not allow pkg_ for If, IfGroup, Alias

(cherry picked from commit c9d93b62b0cc559d1ed4326212b6385cae2eb398)

Required fields in Interfaces pages

(cherry picked from commit 1095b20410963e748fe13268e6fa8f35ccce2319)

Validate POSTed interface description

Copy-paste error from code that used $_REQUEST. This is more correct to use $_POST.
(cherry picked from commit b07adc116c47a2f6a27ae69c84fe0e36a5a27fbd)

Interface description should be required

I was blanking out stuff to see what input error messages came about fields that are required. I was surprised that the Interface Description would save empty. The system did not immediately explode (I was playing with a bonus interface I had created in a VM) but I don't think it is desirable to have interfaces with no description....

Interface description must be unique including case

(cherry picked from commit 3692adec74d438eedb41a7be8eae9cd58f6fe5c1)

6RD Border Relay input error message

This field is labelled "6RD Border Relay" on the main UI. It confused me for a moment when I got this message "6RD Border Gateway must be an IPv4 address." since there was no field with that label in the 6RD section of the UI....

Remove direct calls to /sbin/ifconfig destroy by pfSense_interface_destroy()

IPv6, allow DHCP6 client to use a prefix size of /59

(cherry picked from commit 260f60a9b60d42be7a274b29a8c217c2b4b53507)

PPTP Remote IP is host or V4

Now that Form_IpAddress() supports a range of types of input, this can be specified as HOSTV4.
(cherry picked from commit 4890b6ecb6e2928b4f5c7d4e485c39a9def42a0b)

Disable DHCP server on interfaces with subnet >= 31. Fixes #6930

dhcp6c no release

Script changes to allow no-release option of dhcp6c. These changes to be
used in conjunction with pfSense/FreeBSD-ports/net/dhcp6c recent change
from PR #231

(cherry picked from commit 505635302a3d555eb6f82cb552c99c7ecb813f46)

interfaces, show error message if adding duplicate gateway

(cherry picked from commit e8517c7c16b8a845333c7d0e91f552144e6b5560)

Specify the IP address family in interfaces.php

Where it is known what sort of IP address is required, we can specify it in the call to Form_IpAddress. That will make the hover text reflect what is really required as input, and make the client-side regex pattern also match only the allowed chars....

Added addrtolower() to interface pages

Move copyright from ESF to Netgate

Fix wording of the "Reject leases from" option for a DHCP interface.

Backport DHCP6 init before RA

Original PR to master was #3055

Review license / copyright on all files (final round)

Change group labels s/MAC controls/MAC Address/

Fix undefined constant

Notice: Use of undefined constant min - assumed 'min'
Notice: Use of undefined constant max - assumed 'max'

jQuery datepicker added to interfaces.php and interfaces_ppps_edit.php for setting custom expirey date

(cherry picked from commit d85d82b7686d5899948e6ec4b1587e74937820cf)

Fix redundant phrasing.

Fixed #6331

(cherry picked from commit 7e653b50c4a25b045121c026cd09ac4e567c0c42)

Miscellaneous Textual Correction - Interfaces

(cherry picked from commit a6a344d8dfad5f2b8199a0cef6c8f401f5e06db8)

Interfaces - Punctuation

(cherry picked from commit b48f9816cd34bfee40825612a33f16215989a937)

Correct input type to 'text' for RADIUS shared secret used by wireless hostap interfaces. Fixes #6067

Further text refinements for PR 2790

Merge pull request #2790 from NOYB/Interfaces_-_Word_Smithing

Remove "we" personalizations.

Interfaces - Section Title - Reserved Networks

More accurate section title.

Remove errant line.

Interfaces - Word Smithing

Word smithing to remove a bunch of personalization ("You").

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Merge pull request #2737 from NOYB/HTML_Compliance_-_Interfaces

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

HTML Compliance - Interfaces

Error: Duplicate ID btnadvppp.
<a class=btn btn-default btn-info href=interfaces_ppps_edit.php id=btnadvppp>

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

More icon/button inconsistencies. Ticket #5965

More icon and button consistency fixes. Ticket #5965

Fix some more stragglers for icon/button consistency. Ticket #5965

Correct reference for 6rd. Ticket #5967

Merge pull request #2716 from phil-davis/patch-6

Change invalid use of $iface in interfaces.php

At this point $iface is an undefined var. So the last test of this "if" statement is useless.
That code fragment was introduced in commit https://github.com/pfsense/pfsense/commit/e4d40f41aafe00353c0069b457a0b1b0d6c20987...

Improve track6-prefix-id handling

1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max
2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range....

Add track6 DHCP6 IPs back to interface when applying changes. Ticket #5945

Fix DHCPv6 server check to allow track6. Ticket #3029

Properly check the parent's MTU when changing a VLAN MTU.

Review alert wording.

Interfaces - DHCP Advanced Options Checkbox Vars

Correct the Enable Checkbox Var Names

Interfaces - DHCP Advanced Options Tweaks

Lease requirements and requests typically contain large lists of options. Set the field width to use the available section space.
Apply a few tweaks for better clarity and consistency between DHCP and DHCPv6.
Include a more information link specific to each advanced panel.

Convert section titles to title case

Cleanup some text in wireless options and fix a description.

Adding ability to run dhcp6c in debug mode.

Now that the fields on interfaces.php aren't hidden upon disabling the interface, we don't want to handle disable separately from everything else, as that discards all the changes other than disabling the interface. Everything else with handling bringing down of interfaces is still handled correctly. semi-related to Ticket #2453

Select an interface to track is mandatory

Internationalize interfaces UI code

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Remove redundant alias check and move group check to proper place, fixes #5795

Do not let interface description to have same name of an interface group. Fixes #5795

Add gettext to select option names where required

Clarify input validation output. Ticket #5778

Use current interface description for breadcrumb

If you enter invalid stuff in the interface description - e.g. "123" - and press save, then you get a warning about it, but the breadcrumb changes to "Interfaces: 123" - the wrongly entered description (that was not applied)....

Fix #5778 do not save changes if interface description matches an alias name

See https://redmine.pfsense.org/issues/5778 for details of how to reproduce the problem.

Note that similar code to make the "Sorry, an alias with the name XXX already exists" message is also at the top of interfaces.inc - it compares the current interface descr from the config with the currently existing alias names. That check would help warn the user if someone managed to add an alias name that matched the interface name. I guess it was there from some time in the past when the alias edit code did not cross-validate the alias name with the interface descriptions. I have left that check there - it does no harm to have it "just in case"....

Reverting #5771 - No longer required

Fixed #5771
EXCEPT that the link in the help text does not point to the correct place (yet)

Save adv_dhcp6_config_advanced value instread of just using it to un-hide section

Set checkboxes value to "Selected" (not "yes")

Fix typo password confirm

https://forum.pfsense.org/index.php?topic=104629.0

FInished password hiding logic by ensuring $_POST['password'] != DMYPWD before updating

Added new addPassword method and password == password_confirm validation where required.

Remove $closehead variable

Remove unused variable $closehead

Merge pull request #2287 from NOYB/Interfaces_-_DHCP_Config_File_Override

Interfaces - DHCP Config File Override

Correct section label.

Interfaces - DHCP Advanced Options - Number Attributes

Protocol timing select timeout; override system minimum number attribute to allow zero.

Merge pull request #2270 from NOYB/Interfaces_-_DHCP_Advanced_Options_-_Require_Options

Interfaces - DHCP Advanced Options - Require Options

Fix Require options form input

Interfaces - DHCP Advanced Options - Radio Buttons

Fix the Protocol Timing - Presets radio buttons.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Merge pull request #2234 from phil-davis/r007

Code style g-i

Adv DHCP Require Options text

Tidy up Boolean operators for HTML5

Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Hide dhcp when staticv4 selected

A classic 1-char fix!
Forum: https://forum.pfsense.org/index.php?topic=102940.0

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Fixed not saving spoofed MAC

Fixed #5123

Fixed #5123

Various changes in pursuit of tracking down slow page load. As yet not effective :(

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Correction per Phil Davis

First batch of copyright updates

Fixed incorrect label
https://github.com/phil-davis/pfsense/commit/d14064550e96b109544507e70780e3f1e6eeed04

Fixed #5269