pfSense

Remove "we" personalizations.

Remove errant line.

Interfaces - Word Smithing

Word smithing to remove a bunch of personalization ("You").

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Merge pull request #2737 from NOYB/HTML_Compliance_-_Interfaces

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

HTML Compliance - Interfaces

Error: Duplicate ID btnadvppp.
<a class=btn btn-default btn-info href=interfaces_ppps_edit.php id=btnadvppp>

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

More icon/button inconsistencies. Ticket #5965

More icon and button consistency fixes. Ticket #5965

Fix some more stragglers for icon/button consistency. Ticket #5965

Correct reference for 6rd. Ticket #5967

Merge pull request #2716 from phil-davis/patch-6

Change invalid use of $iface in interfaces.php

At this point $iface is an undefined var. So the last test of this "if" statement is useless.
That code fragment was introduced in commit https://github.com/pfsense/pfsense/commit/e4d40f41aafe00353c0069b457a0b1b0d6c20987...

Improve track6-prefix-id handling

1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max
2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range....

Add track6 DHCP6 IPs back to interface when applying changes. Ticket #5945

Fix DHCPv6 server check to allow track6. Ticket #3029

Properly check the parent's MTU when changing a VLAN MTU.

Review alert wording.

Interfaces - DHCP Advanced Options Checkbox Vars

Correct the Enable Checkbox Var Names

Interfaces - DHCP Advanced Options Tweaks

Lease requirements and requests typically contain large lists of options. Set the field width to use the available section space.
Apply a few tweaks for better clarity and consistency between DHCP and DHCPv6.
Include a more information link specific to each advanced panel.

Convert section titles to title case

Cleanup some text in wireless options and fix a description.

Adding ability to run dhcp6c in debug mode.

Now that the fields on interfaces.php aren't hidden upon disabling the interface, we don't want to handle disable separately from everything else, as that discards all the changes other than disabling the interface. Everything else with handling bringing down of interfaces is still handled correctly. semi-related to Ticket #2453

Select an interface to track is mandatory

Internationalize interfaces UI code

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Remove redundant alias check and move group check to proper place, fixes #5795

Do not let interface description to have same name of an interface group. Fixes #5795

Add gettext to select option names where required

Clarify input validation output. Ticket #5778

Use current interface description for breadcrumb

If you enter invalid stuff in the interface description - e.g. "123" - and press save, then you get a warning about it, but the breadcrumb changes to "Interfaces: 123" - the wrongly entered description (that was not applied)....

Fix #5778 do not save changes if interface description matches an alias name

See https://redmine.pfsense.org/issues/5778 for details of how to reproduce the problem.

Note that similar code to make the "Sorry, an alias with the name XXX already exists" message is also at the top of interfaces.inc - it compares the current interface descr from the config with the currently existing alias names. That check would help warn the user if someone managed to add an alias name that matched the interface name. I guess it was there from some time in the past when the alias edit code did not cross-validate the alias name with the interface descriptions. I have left that check there - it does no harm to have it "just in case"....

Reverting #5771 - No longer required

Fixed #5771
EXCEPT that the link in the help text does not point to the correct place (yet)

Save adv_dhcp6_config_advanced value instread of just using it to un-hide section

Set checkboxes value to "Selected" (not "yes")

Fix typo password confirm

https://forum.pfsense.org/index.php?topic=104629.0

FInished password hiding logic by ensuring $_POST['password'] != DMYPWD before updating

Added new addPassword method and password == password_confirm validation where required.

Remove $closehead variable

Remove unused variable $closehead

Merge pull request #2287 from NOYB/Interfaces_-_DHCP_Config_File_Override

Interfaces - DHCP Config File Override

Correct section label.

Interfaces - DHCP Advanced Options - Number Attributes

Protocol timing select timeout; override system minimum number attribute to allow zero.

Merge pull request #2270 from NOYB/Interfaces_-_DHCP_Advanced_Options_-_Require_Options

Interfaces - DHCP Advanced Options - Require Options

Fix Require options form input

Interfaces - DHCP Advanced Options - Radio Buttons

Fix the Protocol Timing - Presets radio buttons.

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Merge pull request #2234 from phil-davis/r007

Code style g-i

Adv DHCP Require Options text

Tidy up Boolean operators for HTML5

Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Hide dhcp when staticv4 selected

A classic 1-char fix!
Forum: https://forum.pfsense.org/index.php?topic=102940.0

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Fixed not saving spoofed MAC

Fixed #5123

Fixed #5123

Various changes in pursuit of tracking down slow page load. As yet not effective :(

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Correction per Phil Davis

First batch of copyright updates

Fixed incorrect label
https://github.com/phil-davis/pfsense/commit/d14064550e96b109544507e70780e3f1e6eeed04

Fixed #5269

Fixed #5268

Fixed #5266

Addresses #5159 by removing hide/show/disable/enable functions to included file

Ticket #5204 a clean up pass of the jquery sections

Fixed #5165

Merge pull request #1929 from phil-davis/patch-4

Don't allow configuring IPv6 link local addresses on an interface. Ticket #4062

Fix pptp_remote0 var name

I missed one of these in all the manual integration.
Commit https://github.com/pfsense/pfsense/commit/66fd7b47679187ddcfaf5852a55b2af15394f341 had this error.

Redmine #4568 Preserve MLPPP settings when saving interface settings

This is a resubmit of https://github.com/pfsense/pfsense/pull/1900 after integrating to the current master.

Fix description for 6rd prefix field

Fix 6rd input validation. Ticket #4935

fixed #5121

Fixed #5176

Fixed #5121
Antenna section removed per JimT

6rd gateway is required, and must be an IPv4 IP, where 6rd is enabled. Ticket #4935

Fixed #5164

Fixed #5147
This work was reverted then re-applied without the (accidental) tab/space screw-up

Revert "Fixed #5148"
Accidentally broke spaces/tabs
This reverts commit 910b77ad1682740e481df29fc2d9c528a13c2da4.

Fixed #5148

Merge pull request #1899 from phil-davis/patch-2

Fixed #5147
JS added to provide DHCP preset functionality

pptp_local and pptp_remote are arrays

I believe these should reference the [0] array element of pptp_local and pptp_remote. The code in interfaces.php only presents the [0] (first) array element to the user for editing.
The current code also does not preserve any additional pptp_local, pptp_subnet or pptp_remote entries in the coma-separated list in the config. That is redmine bug #4568....

fix text

Fixed #5123
WEP removed by the use of 'define("ALLOWWEP", false);' - Just in case

Fixed 5124 and #5125 (Default values)

Fixed #5121 Antennas now default to 'Default'

Corrected wpa_enable element name

Fixed Modal class issues
FInished interfaces.php (probably)
Fixed notices error in head.inc

Fix typo

PPP country/provider/plan system complted

IPv4 "add new gateway" functionality provided via modal pop-up
Basic hide/show for form setction implemented

Fixed modal.class.php so that modal forms now work
interface.php changes still WIP

Basic functionality based on types completed and tested

Numerous detail edits from Phil Davis
Thank you!