pfSense

This is 2020. Issue #9245

Update copyright notice years. Issue #9245

Validate submitted interfaces. Issue #9294

(cherry picked from commit 5cc7d21dc08be6c65a2bf7f8f4481dc13f4ae115)

Do not use gettext() on default LAN interface name

Correct QinQ interface naming

Rework how IPsec VTI interfaces and reqid specifications for same are formed. Ticket #8544

Please welcome routed IPsec using if_ipsec VTI interfaces. Implements #8544

To use, create a P1/P2 and set P2 to VTI using local/remote network as tunnel endpoint addresses, then assign the interface (enable, but IP type = none), and use like any other interface for routing.

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

re-adding changes made to fix bug#6400, includes fixes for bug#8222 and bug#8223 that were introduced with the initial commit of this code.

original pull request was #3868

Update the Copyright notice for pfSense.

Revert "Merge pull request #3868 from loonylion/master"
Caused issues reported in https://redmine.pfsense.org/issues/8223
This reverts commit 74c55258b21ada7a542965c2470fbaa45ce19689, reversing
changes made to 2acb4025ee7fef074a67d1021a5e62a0aff9fd37.

interfaces_fast.inc: removed accidental rolling 'r' from comment
removed unused parameters from definition of convert_real_interface_to_friendly_interface_name_fast()

interfaces_assign.php: removed profiling code
removed unncessary comments...

fix for broken preselection of select boxes

Improves bug#6400 further reducing page load time from my previous commit

Moved select box generation code out of interface display loop, meaning it runs once iterating over count(interfaces) rather than running count(interfaces) times iterating over count(interfaces) each time....

refactored interfaces_assign.php to to benefit people with large numbers of VLANs, as requested on the forum at https://forum.pfsense.org/index.php?topic=137391.0. Also contains a minor speedup for interfaces_vlan.php. Modified functions are contained in interfaces_fast.inc. Profiling code is still present but commented out, as is replaced code.

The members of a LAGG cannot be assigned, used in VLANs, QinQ, or PPP.

This commit removes the LAGG members from the list of available interfaces.

Fix the QinQ support.

Bring the QinQ support to the VLAN dotted format.

To avoid breaks third party software (such as dhcpd), we silently ignore the interfaces with names bigger than the maximum size in FreeBSD.

Ticket #7942

Remove newline in error msg

Spelling

Fixed #7231

This avoids the problem rather than fixing it by requiring the user to remove any queues from the if before deleting

Revisions to GET/POST conversion limiting POSTs to save, apply, and delete functions - Interfaces

GET/POST conversion interfaces_assign

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Reword/rework wireless note on assignment page. Ticket #6770

Add a note that wireless clones must be created before they can be assigned. This should fix #6770

Move copyright from ESF to Netgate

Call services_dhcpd_configure with the right parameter

Previously code segment for v4 would call both v4 and v6. Fixed to call v4 and v6 where appropriate.

Move to Apache License 2.0

Review license / copyright on all files (final round)

Fix #6613 Do not show Aply Changes button when Save needed

I got a bit carried away in the fix for #6460 https://github.com/pfsense/pfsense/commit/21c18c3df11547aba172c10f95872dbd8682f7d9
The message here at line 507 should not actually show the Apply Changes button. At this point the user needs to adjust the assigned interfaces and save. Then after saving an Apply Changes button can be used to implement the saved changes.

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Merge pull request #2906 from Chrisc-c-c/Fix-QinQ-Interfaces

Fix #6460 Interface mismatch apply changes button

Make QinQ interfaces work again

Unset dhcpdv6 for deleted interfaces on interfaces_assign.php. Ticket #6152

Interfaces (assign) - Remove Personalizations

Remove "you" personalizations.

More icon/button inconsistencies. Ticket #5965

If exist, print the friendly interface name next to device name.

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Use print_info_box() to generate alerts

Synchronize page title with tab title. Renamed GRE to GREs, GIF to GIFs and LAGG to LAGGs to match VLANs, QinQs, etc.

Standardize print_apply_box usage

1) For the translators, it should be better to do it consistently. Then
they only need to have 1 translation of "You must apply the changes in
order for them to take effect" and can translate each of the other
custom sentences individually....

Internationalize interfaces UI code

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

print_info_box success

In most situations we want the print_info_box() of $savemsg to be
'success'. If there was some problem saving, then it can be 'warning'.
These are a few places I have found so far that need this sort of fixing
up - more to come but sleep calls just now!...

HTML Compliance - Interfaces / Assign network ports

A table row was 3 columns wide and exceeded the column count established by the first row (2).

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Code style g-i

Tidy up Boolean operators for HTML5

Remove the XHTML standard Boolean operators (makes reading HTML much
simpler).

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Fixed group member creation
Nixed "I/F in button labels (by popular demand)

Cosmetic cleanups

Copyright updates Batch 2 of 3

Copyright update

Fix array index, 6 was missing

show openvpn interfaces while reassigning the interfaces for a restored config backup

Resubmit of #1769

bootstrap, use require_once for classes/Form.class.php

Merge branch 'master' into bootstrap

Move main pfSense content to src/