pfSense

Fix #6251 Brackets around Mbuf figures
(cherry picked from commit 97f930d1e3af593b20ed56ca951a2109a853a28d)

Fix Hyper-V SMART disable on widget. Ticket #6147

Fixed #6259 (Gateway widget form layout)

(cherry picked from commit f5ee7cfd7c2e3f9e7383fb41c47f77bad3507cfc)

Fix #6251 Temperature on System Information Widget

It just seems that some infrastructure for a temperature bar had been put in place, but the code never finished to actually do it. But I am a bit surprised that it has taken so long for someone to report this....

Hyper-V SMART - didn't intend to commit that part. Ticket #6147

Add Hyper-V support to system_identify_specific_platform, and disable S.M.A.R.T. actions in Hyper-V guests. Ticket #6147

Fix #6212 Really disable checks

Belts and braces here - I the setTimeout is not done then the other bits of code do not get called anyway, but I took them all out to make sure there is no way to accidentally do the update check when it is disabled.
(cherry picked from commit d3f7004d96c274f117a0264094595c9fbe85b6f7)

Convert status_services and widget to POST

Use consistent arrow colors on dashboard

Interfaces widget and IPsec widget use text-success and text-danger to
make the up and down arrows be green and red.
This change does the same thing to OpenVPN and WoL widgets for
consistency.

(cherry picked from commit fa5f513658f7f1aba530e76e01dfbc021605c3ad)

Fixed #6096

Merge pull request #2829 from phil-davis/openvpn-widget

(cherry picked from commit 1dae6c0f4184ac72c252fb934d2bfa4fd3a967fe)

Merge pull request #2828 from phil-davis/widget-personalizations

(cherry picked from commit e18fb7e8bbf8c26639d0598fa04320c5608ce660)

shorten ipsec widget refresh time

add color to icons

Add color to the CARP status icons so they are more visually distinct. Ticket #5965

HTML Compliance - Status Dashboard - System Information Widget

Error: Stray end tag spa.
Error: End tag td seen, but there were open elements.
Error: Unclosed element span.

Fix icon usage on the interfaces widget, the down icon was arrow-up. Add color to the status for clarity. Ticket #5965

HTML Compliance - CARP Status Widget

Error: th start tag in table body.
Warning: A table row was 1 columns wide, which is less than the column count established by the first row (3).

More icon and button inconsistencies. Should be the last batch. Ticket #5965

Revised disk space display to use progress bar

Upon further review, use a more clear and related set of icons for CARP status, play-circle (master) and pause-circle (backup). Ticket #5965

Slight change to CARP status icons, difference between master and backup status was not clear enough. Ticket #5965

Correct some icon usage inconsistencies. Fixes #5965

Clean up the CARP status widget. Fixes #5964

On second though, don't use this class on this particular tag in the WoL widget.

Fix up the formatting of the Wake on LAN widget and change the code style so it isn't a bunch of echos. Fixes #5960

Fix load balancer status widget uptime percentage display. Fixes #5959

Shift the values to account for the removal of the gateways one. Ticket #5905

Ticket #5905 remove unused code

HTML Compliance - Services Status Widget

The for attribute of the label element must refer to a non-hidden form control.
There is no corresponding target of this for attribute. Removing.

Minor tweaks to simplify code

Calling print(sprintf(...)) can be simplified to printf(...).

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Use print_info_box() to generate alerts

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Use print_info_box() to generate alerts

Renamed SMART to S.M.A.R.T.

Renamed 'Wake on LAN' to 'Wake-on-LAN'

Clean up another closing tag followed by opening

Cleanup

Remove closing tag followed by opening tag. Change short_open_tag to full tag and put small instructions on same line.

Further revision to service hiding system

Revised hiding

Revised service hiding

Fixed #5858
Adds an incrementing suffix to service names when there are duplicates

Use IEC MiB units on dashboard

1) physmem calculation is already in MiB
2) swapinfo -m actually reports in MiB - good
3) The code that gathers the disk space data already uses "df -h" which reports in IEC units, but the output just has the single char "M", "G" etc. We can always add "iB" here....

Return blank rather than 0ms/0% for unmonitored gateways latency and loss. Show on dashboard widget when a gateway is unmonitored. Ticket #2226

Add RFC 2136 support to the DynDNS widget

Fix up DynDNS widget to follow recent changes in DynDNS for Namecheap

HTML Compliance - Widget - Firewall Logs

Attribute (that|triggered|this|action) not allowed on element a at this point.

Widget - Firewall Log - Tweaks

Add a table row when there are no entries to prevent scroll bars after ajax update.
Add no logs to display message.
Add update interval configuration setting.
Add configuration form placeholders.
Don't include ':' when no port such as for ICMP....

Replaced jQuery to $ in same files

Merge pull request #2500 from NOYB/Firewall_Log_Widget_-_Revert_Abbreviation

Internationalize dashboard widgets

Firewall Log Widget - Revert Abbreviation

Fine to spell out 'Destination' here.
1) Field content already has column wide enough.
2) Consistent with firewall log.
3) Already translated.

Return interface abbreviation to it's original uppercase 'IF' to not look so much like the word 'If'.

Add standard deviation to gateway status and widget

Show interface description in traffic graph widget settings

Forum: https://forum.pfsense.org/index.php?topic=105448.0

Reverting change of label. It broke the display

Fix graph scale setting

Lowercase this opening tag

All simple php echo to short

Short version is far more used than long php echo. This brings all code to same standard where possible.

Merge pull request #2436 from NewEraCracker/rewording

Replace abbreviations with complete word

Return string and print

Newline is added only if both IPv4 and IPv6 addresses present

Gateways Widget Refactor init-ajax

Move table content creation into a function so initial table load can be done normally without resize flicker.
Subsequent content updates remain via ajax.

Convert remaining short_open_tag occurances. See PR #2378

Remove/recover empty space below DNS servers unordered list.

Remove blank line if version check disabled.

Use Bootstraps text alignment classes (part 2)

use Bootstraps CLASS statement instead "align" statement

Fixed #5738

HTML Compliance - Services Status Widget

Element option without attribute label must not be empty.
<option selected></option>

Add output validation here too. Ticket #5351

Encode hostname before printing; remove some related dead code.

Merge pull request #2305 from ExolonDX/branch_04

Update wake_on_lan.widget.php

Remove unused TD tag

Tidy up widgets

ipsec.widget.php
- add missing TR tags to THEAD

wake_on_lan.widget.php
- remove stray double quotes

Use Bootstraps text alignment classes

As per "http://getbootstrap.com/css/#type-alignment", use CLASS
statement instead in inline STYLE statement (much tidier)

HTML Compliance - Wake On LAN Widget

Align attribute not supported on td tag in HTML5 use css instead.
Center tag not supported in HTML5 use css instead.

Merge pull request #2283 from ExolonDX/branch_02

Tidy up "ntp_status.widget.php"

- Tidy up coding style
- Remove unnecessary DIV tab
- Update TABLE tag

Correct quotes around $ifdesc introduced in PR 2282

Tidy up "services_dyndns.php"

services_dyndns.php
- remove duplicate double quotes
- tidy up tabs/spaces

services_rfc2136.php
- remove duplicate double quotes
- tidy up tabs/spaces

dyn_dns_status.widget.php
- change echo to print
- change FONT tag to SPAN tags and use correct class...

Fixed #5650

Merge pull request #2267 from phil-davis/r018

Merge pull request #2266 from NOYB/HTML_Compliance_-_Dashboard_-_Widget_Config_Panel

Merge pull request #2263 from phil-davis/r016

Merge pull request #2262 from NOYB/HTML_Compliance_-_Traffic_Graphs_Widget

Merge pull request #2261 from NOYB/HTML_Compliance_-_Thermal_Sensors_Widget

Merge pull request #2260 from NOYB/HTML_Compliance_-_RSS_Widget

dyn_dns_status widget avoid var naming issue

This use of var $i was conflicting and interfering with a use of it in
index.php
Use a much more unique name for now to avoid future risk.
Maybe a proper final solution for var naming across dashboard and widget...

HTML Compliance - Dashboard - Widget Config Panel

Bad value #widget-system_information .panel-footer for attribute href on element a: Illegal character in fragment: not a URL code point.
Fix the widget config/wrench icon href.
Add matching widgetname id tag to widgets configuration panel div element....

Consolidate OpenVPN kill_client routine

After a gitsync just now I started getting "cannot redeclare
kill_client" error messages. Whatever it was that caused this to start
happening, the kill_client() function in these 2 places is identical.
Might as well put it in openvpn.inc

HTML Compliance - Traffic Graphs Widget

Syntax typo?
No space between attributes.
Quote " in attribute name. Probable cause: Matching quote missing somewhere earlier.
Attribute wan]" not allowed on element input at this point.

The for attribute of the label element must refer to a non-hidden form control. Add id tag.

HTML Compliance - Thermal Sensors Widget

The align attribute on the td element is obsolete. Use CSS instead.

HTML Compliance - RSS Widget

An img element must have an alt attribute, except under certain conditions. For details, consult guidance on providing text alternatives for images.
http://www.w3.org/wiki/HTML/Usage/TextAlternatives
The for attribute of the label element must refer to a non-hidden form control. Add id tag.

HTML Compliance - Picture Widget

In HTML 4.01, the width and height could be defined in pixels or in % of the containing element. In HTML5, the value must be in pixels. Use css for specifying in %.
The for attribute of the label element must refer to a non-hidden form control. Add id attribute.

Merge pull request #2248 from NOYB/HTML_Compliance_-_Log_Widget

Merge pull request #2247 from NOYB/HTML_Compliance_-_Services_Status_Widget

HTML Compliance - Log Widget

The for attribute of the label element must refer to a non-hidden form control.
Added id tag to form control.

HTML Compliance - Services Status Widget

Attribute height not allowed on element select at this point.

The for attribute of the label element must refer to a non-hidden form control.
'<label for="inputPassword3" class="col-sm-3 control-label">Hidden services</label>'...

HTML Compliance - Interfaces Widget

Replace status indicator icon alt tag with title tag.
Add space between td tag and attributes.