pfSense

Captive Portal code review

Make the capitalisation of the various heading pages consistent.
Fix various field var name errors observed.

Redmine #5386

From Router Advertisements tab, be able to select different interfaces and stay on the Router Advertisements tab.

Restored interface tabs to dhcpv6.php
Changes dhcp/advertisements tab format in dhcpv6 and router_advertisements

Fixed #5385

Fixed #5384

Fixed #5381

Fixed #5382

Fix services_unbound.php. The interfaces menus did not display the selected
interfaces, they always showed "all" selected. Made it so an "apply changes"
message shows when something changes.

Fix cosmetic infoblock issue when there is more than one info_box on a page

Convert networks section to jQuert "repeatable" scheme and remove for($x=0;$x<4999 . ." code

Move "Add P2" button to left side to facilitate use of smaller screens
Fix HTML indenting

Correction per Phil Davis

Copyright updates Batch 2 of 3

diag_nanobsd do not show reference count 0

When the user has selected "Keep media mounted read/write at all times." then the value of $refcount will be zero even though is_writable() is true. That is a normal condition.
We only want to display the (Reference count n) text when the reference count is abnormal....

First batch of copyright updates

Merge pull request #2034 from phil-davis/r2

proposed fix for Bug #5375

value passed by checkbox was "yes" when checked, instead of "Block" / "Pass"

services_unbound_acls text stuff

Various text stuff on the UI

convert system_camanager to fa

services_dhcpv6 text

and also I made the DNS 1, DNS 2, DNS 3 , DNS 4 show inside the boxes as 'placeholder' the same as NTP 1, NTP 2 is done. That saves a bit of screen real estate and makes it consistent.

change onclick delete msg toLowerCase()

Merge pull request #2029 from phil-davis/patch-3

Delete confirmation vi fa-trash automated via pfSense.js

service_dhcp.php NTP and TFTP server fields

and I used capitals for DHCP Server.
At the moment there is a mix of capitalisation of this sort of stuff - e.g. there is "DNS forwarder" in various places and "DNS Resolver" and... IMHO these can all be made consistent to have capitals on all the "big" words.

Convert system_certmanager.php to font awesome icons
Automatically add confirmation dialog to all fa-trash icons

Moved action-buttons in-line styling to pfSense.css

Merge pull request #2027 from heper/sed_inline_css

service_dhcpv6_edit dodgy-looking stuff

Noticed when reading the code.

add icon-embed-btn

replace and find for icon-embed-btn

Fix save/update messages and format

Merge pull request #2024 from heper/patch-4

Merge pull request #2017 from heper/patch-1

Buttons updated

Updated button styles

Buttons changed to new design

Buttons converted to new deisgn
'X' button suppressed in info text box

Buttons update to new design:wq

Firewall rules pages updated with new button style

AUtomatically add "info" icon where required

Remove dead code from pkg_mgr_install.php

Respect product_name and tmp_path

Revised button style on firewall_aliases.php as a model for all other table-based pages

fix tabstops v2

fix tabstops

convert services_rfc2136 to fa

please double check the added act==toggle code

convert services_dyndns to fa

i've also added a act=toggle.
please check to see if there aren't any huge mistakes in it. (seems to work)

convert services_unbound_acls to fa

convert services_unbound to fa

convert services_dnsmasq to fa

Merge pull request #2003 from brunostein/fix_button_name_upgrade_firmware

convert status_dhcpv6_leases to fa

Added automatic error recovery and ajax busy flag

Only call pfSense_ipsec_list_sa() when IPsec is enabled

Merge pull request #2023 from heper/patch-3

Make all progress bars skinier (14px)

convert status_dhcp_leases to fa

Added miniature logo for hte RSS widget

Fix widget div

Fix degree symbol

Fixed warning threshold

Don't allow IPsec mobile clients user auth source to not be a RADIUS server if
the phase1 auth method is EAP-RADIUS. Properly handle selection of multiple
RADIUS servers when using EAP-RADIUS. Fixes #5219.

Completed #5369

diag_logs_filter reduce duplicated icon code

Almost all the code in old lines 397 and 402 was the same. Make the logic a bit clearer about exactly what is the difference and hopefully reduce future code maintenance issues.

FInishing touches to move action icon to left-most column

Merge pull request #2021 from phil-davis/patch-4

diag_logs_filter_dynamic reduce duplicated icon code

Almost all the code in old lines 408 and 413 was the same. Make the logic a bit clearer about exactly what is the difference and hopefully reduce future code maintenance issues.

Actions back to the left. (By popular demand.)

Merge pull request #2018 from heper/patch-3

Dynamism restored, but etc/inc/filter_log.inc still needs work around line 455

convert diag_confbak to fa

are the icons for revert & download ok ?

convert vpn_openvpn_csc to fa

convert vpn_openvpn_client to fa

convert vpn_openvpn_server to fa

convert vpn_l2tp_users to fa

convert vpn_ipsec_keys to fa

Fix confirm on delete

Merge pull request #2015 from heper/patch-1

Fixed #5222

fix tabstops

revert back to $_POST after request from Steve_B

note:
onclick="return confirm" does not function as expected. vlan still removed when choosing "cancel"

convert interfaces_lagg to fa

convert interfaces_bridge to fa

convert interfaces_gif to fa

convert interfaces_gre to fa

Update interfaces_qinq.php

convert interfaces_ppps to fa

convert interfaces_qinq to fa

convert interfaces_vlan to fa

this page used $_POST instead on $_GET. no clue why. changed it to $_GET like every other page i've come across thus far. (it only seems to complicate things, without an actual benefit??)

convert interfaces_wireless to fa

Update interfaces_groups.php

convert interfaces_groups to fa

Make diag_logs_filter and diag_logs_filter_dynamic consistent by moving action icon to last column

Changed icons to font-awesome
Changed tooltips to Bootstrap style

Added icon-pointer class

fix block/pass icons

fix block/pass icons

icon color danger & success

Update vpn_pppoe.php