pfSense

add rule comments

add active table row css rule

clean up firewall rules tables

fix typo caught by @phil-davis

Fix more privilege text/name/page inconsistencies

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Add some missing privileges to pages

Various updates to privileges and related metadata

More privilege naming fixes.

Ignore ourselves when checking for a duplicate roll #.

Fixes the voucher editing.

comment out fixed navbar option for now

fix top padding for fixed navbar

make hover work only when navbar is horizontal

keep header from wrapping

make dropdowns work on hover

Fixes #5529

Status IPsec inconsistent Logs tab

For some reason Status->IPsec has a "Logs" tab in addition to the
"Overview", "Leases", "SAD" and "SPD" tabs. The "Logs" tab takes you off
to the logs screens, and so when you click the tab all the other tabs
are gone and are replaced by all the "Logs" interface tabs....

Page converted to Form.class framework

Form_checkbox -> Form_Checkbox

Typo fix

Merge pull request #2110 from phil-davis/patch-6

LT2p breadcrumbs

The repetition of LT2P here seemed odd. To me it seems better that the last level matches the tab name below, like it does if you click the "Users" tab.

Hide dhcp when staticv4 selected

A classic 1-char fix!
Forum: https://forum.pfsense.org/index.php?topic=102940.0

Move get_pkg_info() call to ajax request to make widget more responsive

Add cog icon while loading

Fully separate "Apply" and "Save" actions in the DNS Forwarder. Fixes #5505

Small adjustments to shortcut icons/text

Protect these two vars with htmlspecialchars

I wasn't able to exploit this but given how they are used, seems like it is only a matter of time before someone finds a way.

Comment fix

Comment fix

Adjust body top padding to match header height when top menu is pinned.

Fixed menu scroll in pconfig

Extra safety belts on the RSS widget settings

Add support for scrolling menu bar (fixed vs static)
Now required body padding to prevent page top from being hidden

Added cog icon while loading

browser supported now

clean up thermal widget

remove trash icon coloring

Fix links to logs in shortcuts

Address some security issues in diag_logs.php. While I'm here, fixup page names and shortcuts.

Change Form_TextArea to Form_Textarea
(autoload now makes the classes case sensitive)

Fixed #5505

Fixed #5521

IPSec statistis updated dynamically
Partial fix to #5520

Interface widget icon adjustments

Use some icons here that have a somewhat more relevant appearance (no exact matches, unfortunately)

Don't reuse $icon here - results should be two different icons. Fixes #5519

Completed #5407

Correct Form_TextArea -> Form_Textarea

List CSS file in alpha order

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Re-add host_uuid user-agent option lost during bootstrap import. While here, change its name to be more clear what it does

Tunable value can be zero, use isset() to validate it

Merge pull request #2101 from doktornotor/patch-5

Remove the last usage cases of $config['ipsec']['enable'].

IPSEC is always on in 2.3, where necessary (IPSEC rules, IPSEC daemon), we check the existence of phase 1 entries.

Do not allow the same interface be part of two different bridges.

This is already forbidden in OS, so just add a warning to prevent this kind of misconfiguration.

Issue: #4595

Preserve bridge name while editing bridge settings, otherwise a new bridge is created every time you edit a bridge.

Fix the interfaces widget to show the IP address of v6 only interfaces.

Always honor the required tag in package XML fields

Dunno whose idea it was to restrict this to input. WTH really.

Tidy up "services_status.widget.php"

Update code style
Close TH tags properly

Remove "orphaned" closing SPAN tag

Remove "orphaned" closing SPAN tag

Remove layer7 components. Ticket #5508

Revise System->Routing menu entry and page titles

Removed no longer needed jQuery

remove old function call

clean up interface statistics widget

clean up installed packages widget

add common background color classes for dark theme

clean up gateways widget

Fix search box icon color

NTP -> NTPD

Fixed duplicate NTP

remove inline styles

update dark theme

Merge pull request #2097 from phil-davis/timeupdateinterval

Remove unused time-update-interval

There is no longer any code for a UI field in 2.3 master.
In RELENG_2_2 system.php the code for the field display is commented
out.
The commented out code has been removed in the bootstrap conversion.
This removes the various bits of leftover processing and validation code...

Merge pull request #2096 from phil-davis/patch-1

Completes #5263

Better test for webguicss being not set

As discussed in https://github.com/pfsense/pfsense/pull/2094

Fixed #5497

Completed #5499

Fixes #5488

Move timeout value to PHP definition for easier modification

If webguicss is not yet specified then default to pfSense

On systems where webguicss (the theme) was not yet set in the config, the selection here was defaulting to other than pfSense.
Now that pfSense-dark has come along, it happened to be first in the list. When I changed something else in General Setup today, my them went to pfSense-dark because I did not notice the (accidentally) selected value that was in the field....

Redmine #5492 case of acronyms in widget names

I am not sure how else to do this. If someone in future writes a widget about "Smart Carp" (an intelligent species of fish) then it will get turned into "SMART CARP". The other strings are not English words, or parts of English words, so not likely to be matched wrongly in future....

Fix widgetname variables

These were wrong. But actually I don't think any widgets use this mechanism of $config['widgets']['mywidget-config'] - they seem to do their own thing making names for the keys they use in $config['widgets'] to store their settings. So I didn't find anything actually broken because of this.

PEAR.inc is already required by radius.inc

Cosmetic fixes

Partial fix to #5495

Fixed #5489

Fixed #5490

Work-around for #5488

Ticket #5470 fix dashboard breadcumbs

Fixed #5478 clean up title text

Make text areas fixed width font with a tabstop of 4

Merge pull request #2090 from brunostein/add_identification_form_section

add attribute 'id' for the Form_Section

Merge pull request #2089 from brunostein/fix_move_options

Fixed #5486

fix moveOption function