pfSense

move tree.css to main css files

Fixed table apeparance, headers, button placement and row drag/drop/move

clean up common colors

Corrected movable/sortble table row handling

improve firewall rules table (WIP)

Fixed #4915

Merge pull request #2252 from phil-davis/r013

Support <savehelp> package tag to allow adding help text to the save button.

Code style services dhcp dnsmasq dyndns

services_dyndns_edit requestif key name

This probably fixes forum thread https://forum.pfsense.org/index.php?topic=104076.0

Merge pull request #2250 from phil-davis/r012

Code style services captive portal

services_captiveportal text changes

Whitesapce change

Remove bogus radio button

Fixed #5617
Added ID and style to routing table

Merge pull request #2248 from NOYB/HTML_Compliance_-_Log_Widget

Merge pull request #2247 from NOYB/HTML_Compliance_-_Services_Status_Widget

Merge pull request #2246 from NOYB/HTML_Compliance_-_Interfaces_Widget

HTML Compliance - Log Widget

The for attribute of the label element must refer to a non-hidden form control.
Added id tag to form control.

HTML Compliance - Services Status Widget

Attribute height not allowed on element select at this point.

The for attribute of the label element must refer to a non-hidden form control.
'<label for="inputPassword3" class="col-sm-3 control-label">Hidden services</label>'...

HTML Compliance - Interfaces Widget

Replace status indicator icon alt tag with title tag.
Add space between td tag and attributes.

HTML Compliance - System - General Setup

Remove placeholder from dns gateway selector.
Close container div tag.

Fixed #5617
Table columns corrected

Add breadcrumb to pkg.php

Show package dependencies if they exist (on both available package list and installed package list)

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Font Awesome updated to v4.5

Remove unhelpful help text

Code style System Advanced

Update system_advanced_firewall.php

A few little code style bits
Make the State Timeouts section actually appear (add the section to the form)
The State Timeouts section was trying to do groups of fields, which spread themselves horizontally. That did not fit across a reasonable screen nicely, specially for the 6 different TCP timeouts. So the groups thing is removed and each field is its own input in the section, all vertically below each other....

Applying htmlspecialchars on form action attribute causes ampersands to multiply, and also breaks multi-parameter query strings that are delimited with ampersands.

Revised system to hide the automatically generated "Toggle all" button when not required.
Original system broke with PR to change radio button names.

Merge pull request #2237 from phil-davis/r009

Merge pull request #2236 from phil-davis/patch-2

Merge pull request #2235 from phil-davis/r008

Merge pull request #2234 from phil-davis/r007

Remove placeholder from form select (raw mode filter form).

HTML 5 complaince changes

Code style pkg

pkg_edit curlies

This looks wrong - with the way the curlies were, the custom_php_after_form_command stuff was inside the ($pkg['note'] != "") block.
It looks like these should be 2 independent if statement blocks.

Code style l

Code style g-i

Merge pull request #2233 from phil-davis/patch-4

Adv DHCP Require Options text

Merge pull request #2232 from NOYB/Status_-_System_Logs_-_Sort_Header

Merge pull request #2231 from phil-davis/r006

Merge pull request #2229 from NOYB/Status_-_System_Logs_-_Firewall_-_Sort_Header

Conditionally indent the action icon so it doesn't look so out of place in the wider column resulting to accommodate the sort button/icon.

The rule entires still need to wrap.

Status - System Logs - Sort Header

Fix header to not wrap the sort button/icon to the next row.
Add sort capability to the "raw" table.

Code style status*

Status - System Logs - Firewall - Sort Header

Fix header to not wrap the sort button/icon to the next row.
Add sort capability to the "raw" table.

status_gateways remove unused counter

$counter is incremented but never initialized or used
Code style formatting also done around here.

Merge pull request #2226 from NOYB/HTML_Compliance_-_Status_-_System_Logs_-_VPN

Moved global defines to globals.inc

HTML Compliance - Status - System Logs - VPN

Permitted content of p tag is phrasing content.
Form is not a member of phrasing content.

Add gettext() calls to title elements

Correct <th> widths

Remove duplicate defines

Fix vertical alignment of fa icons within buttons

Parse package title, splitting into an array delineated by '/'.
So if the package title is "Services/Magic" the $pgtitle will be array("Services", "Magic") and the breadcrumb display will be as expected.

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

Merge pull request #2161 from heper/patch-1

Move function to fix none existent call.

Status - System Logs - Firewall - Manage Log

Use the same methods of obtaining log file etc. and mimic much of the code that is common with status_logs.php.
(future: factor out common code into shared functions to remove duplication.)

position confirm button better

Merge pull request #2224 from phil-davis/r005

Coe style firewall *

Text with max-src-conn-rate and max-src-conn-rates fields

I fixed up the text to read the best I could think of.
Actually in 2.2.* these 2 fields were horizontally across the page - so maybe someone can reformat this to look more like on 2.2.* ?

Merge pull request #2218 from NOYB/HTML_Compliance_-_Dashboard

Merge pull request #2217 from NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF

Merge pull request #2216 from NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID

Remove debug

Merge pull request #2215 from NOYB/HTML_Compliance_-_Form_Action_Attribute

Fixed #5638

Merge pull request #2222 from phil-davis/patch-3

Fix array key typo in firewall_nat_1to1_edit

This just looks wrong.

Remove duplicated code in firewall_aliases_edit

This hidden Form_Input is duplicated and I don't see why. The system seems to work OK with the duplication and without.

Merge pull request #2220 from phil-davis/r004

Fixed #5637

Revise child icon

Add fa icon to show override is a child

Code style usr local www a-e

Comment fix

Fixed #5638

Set language early on a common place included everywhere. This fix some tar warnings 'Failed to set locale'

Fix remaining copy/paste message from last commit

Add icon on retrieving gw widget

fix traffic shaper tree font color

HTML Compliance - Dashboard

HTML compliance (aside from the active widgets).

Rename duplicate id's.
Fix available widgets collapsible section href with id.
Where obsolete replace name attribute with id.

Merge pull request #2214 from BBcan177/patch-3

Merge pull request #2209 from NOYB/Status-System_Logs-Sortable_Table

Merge pull request #2208 from ExolonDX/branch_01

HTML Compliance - Collapsible Form Section HREF

Bad value for attribute href on element a: Illegal character in fragment: not a URL code point.

<a data-toggle="collapse" href="#<id> .panel-body">
Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20....

HTML Compliance - Checkbox Display As Radio Unique ID

Ensure checkbox display as raido has unique id.
Allow an id to be passed in displayAsRadio() as argument⁰.
If no argument is passed, construct id as name_value:uniqid.

Previous behavior was id = name. So all the radio buttons of the set had same id.

HTML Compliance - Form Action Attribute

Fix Empty Form Action Attribute Violation

An empty form action attribute is an HTML4 and HTML5 specification violation.

http://www.w3.org/TR/html5/forms.html#attr-fs-action
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."...

be more concise

clean up webGUI feature help text

remove icon- color classes