pfSense

Fix indent and spaces

Remove stray '

Fix #6582 Allow import of ports

This change does:
1) Allow bulk import of a port alias. That happens when the Import
button is pressed from the Ports tab of the firewall_aliases screen.
2) Allow bulk import of an IP alias, automatically determine if the
imported data fits a host or network alias type. That happens when the...

Improve patterns to read dhcpd6.leases to prevent leases containing '}' in ia-na line not showing up. It fixes #6543

Fix #6585 Do not use [] syntax for lookups

IPv6 address plus port is displayed with the format [1:2::3]:80 - the address is in square brackets followed by colon and the port number. This is necessary to disambiguate the port from the address, a good thing. But it messes up the use of the IPv6 address for reverse lookup....

Show "cannot delete alias" message as error

If I try to delete an alias that is in use, the "cannot delete alias" message was being displayed as the "success" color.
(cherry picked from commit 04b571e836077c436d109d982be5a8e710ff8aab)

Do not check platform to decide if enableserial and primaryconsole fields will be hidden, global parameters are the rule to decide it. Fixes #6291

Fix PTR lookups on diag_dns.php. Ticket #6561

Change group labels s/MAC controls/MAC Address/

Correct spacing

(cherry picked from commit a0b0acd1540764d5221ea54ea596d569bbe2df2a)

Remove debug

Fixed #6577 - Preserve user input on error

(cherry picked from commit a654d899cd5d288501fea1ec52dba2e3f0e479ba)

Make sure resolv.conf is present during nanobsd upgrade. Fixes #6557

webgui tables, doubleclick event to perform 'edit' action, part 2

(cherry picked from commit 1c10ce9750f3702f433a91754f79e637e1c3369b)

webgui tables, doubleclick event to perform 'edit' action

(cherry picked from commit 54691fc663eae7c6e92e4eaad596906758d7ebea)

ipsec widget, check for valid array

(cherry picked from commit 658180daffe0fe5f005b6fe6b528c758309dffef)

Clarify Negate option description on firewall_nat_out.php.

Change button order on diag_dns.php so hitting enter in the field does a lookup rather than update alias. semi-related to Ticket #6561

Update system_usermanager_settings.php

Use of undefined constant min - assumed 'min'

Update system_crlmanager.php

Use of undefined constant min - assumed 'min'
Use of undefined constant max - assumed 'max'

Fix undefined constant

Notice: Use of undefined constant min - assumed 'min'
Notice: Use of undefined constant max - assumed 'max'

startsWith Polyfill

Fixes hidding of custom individual settings when not in use on user manager page.

Diag Tables Last Update

Use correct Thursday abbreviation (s/Thr/Thu/).

Allow wildcard for hostname with Namecheap DDNS. Ticket #6260

Whitespace cleanup

Make model_number customizable

Make presentation_url customizable

Feature #6388 custom GUI preference settings per user

Rationalize System Update GUI messages

At present, when doing a System Update, there is a message box that says:
"Please wait while the installation of completes.
This may take several minutes."

Between "of" and "completes" is the package name, which is blank in the case of a System Update....

Diagnostics - DNS Lookup, also query for IPv6 addresses

Omit <secret> tags from L2TP in status.php config.xml dump.

Restore 2.2.x and prior means of obtaining pfsync nodes to avoid exhausting memory on systems with large state tables. Ticket #6364

Update include() to include_once()

For safety, use include_once() when including various "side" files.
There are a couple of instances of include("guiconfig,inc") that I
changes to use require_once() to be consistent with everywhere else.
The remaining cases of include() are just (hundreds of) head.inc and...

Remove a-f from IPv4 address pattern

It seems to me that a through f should not be part of the pattern for the "V4" case.
(cherry picked from commit 1f49dd8a3a49b724ded5840c1db6c168ed466aae)

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Use the translated destination for kill_states if one exists. Ticket #6531

Correct/clarify column header. Ticket #6530

Fix style

pfSense_get_pf_states always returns source as src and dest as dst, this flipping based on direction is wrong. Ticket #6530

Fix style

Revert "Incorporated ssl changes"

It's a specific 2.4 change, only in master branch

This reverts commit 00a7688401c15015c3f43735b2b1536ebfec7e92.

Comment typo

(cherry picked from commit b069f77e0a5e355e811dd7bd4a4d17a802a3f682)

Revert "adding privileges and separating DNS Resolver overrides from general settings"

This reverts commit fc76a1e390c8ce9579df31457c74d1d0e572b78d.

Shouldn't the priv match here be set to "services_rfc2136_edit.php*"?

(cherry picked from commit 5c403f843291bdc670dcdb45e1e097f2eb7f36ab)

Load actual value of webguihostnamemenu

This is a string from a list of valid values (empty, "hostonly", "fqdn"). So it is not correct to just gather a true/false value here.
(cherry picked from commit e93242eb2ad5a45fb6ab1526f0b6ddcc716e5b96)

Restored countdown functionality and menu refresh on successful update/remove/install
Added comments to clarify operation of the page

(cherry picked from commit 18295ff2f907f638afa9f7c665cc16e4262e6899)

Clarify ports alias hint. Ticket #6523

% and / are also allowed in values

Fix Bug #6394 - Incorrect Output of Translation

Apparently gettext() does not behave correctly when passed an empty string, this commit ensures gettext() is called only with non-empty strings

(cherry picked from commit 6ae99aba5cab12440d88dd9ddaa6535c3b9b5d82)

Fix #6482 OpenVPN Redirect Gateway Option Causes GUI Issue

This fixes the GUI inconsistency reported in the referenced bug. On edit of an OpenVPN server that has tun mode, not shared key, and the gwredir checkbox checked, the local_network fields are shown, but actually they should be hidden (because that is what happens on first data entry when gwredir is checked)....

added missing div.content wrapper when reloading filters

(cherry picked from commit e8406abe627675db2c2f77a81c1bb883f5158bb6)

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)

Do not allow deleting your own user name

Currently if you delete your own user name, then the config ends up with a blank user tag in it. Rather than fix that up, it seems dangerous to be able to delete yourself anyway, because if you are the last user with admin privs for which you know the password (i.e. if you have not recorded the password for "admin" somewhere), then you can lock yourself out. That would require console access to fix, which for some people is a pain....

function name hms -> dhms

to match edit to util.inc
(cherry picked from commit c57e936a6596550619f7261e85b633ca5016cbf2)

Add "delete entry" for ARP table

Useful function in some circumstances - seems no reason not to have it.

Uses IP rather than hostname since not all ARP entries have hostnames.

Probably should also have "delete all" but not done that.
(cherry picked from commit 6ea0d41e3c094a0977e7f0d022ec74276280b8ff)

Fix NTP PPS. It had 'None' option available on 2.2.x.

(cherry picked from commit ceabd66d57f7199602d3a23cb8a60080bcfa67ea)

Fix "Unable to remove NTP GPS from configuration"

https://forum.pfsense.org/index.php?topic=112771.msg627573
(cherry picked from commit 55de528cbb177b4a1f40554ad1a567198bbeebb3)

redundant check - is_numericint() tests for >= 0
(cherry picked from commit f208e9690e2ec4089cf3d3fe5f5f03fed5a36e6f)

fix logic and replace hard coded value by global

backups should be a numeric int.
text hint for number of backups can now refer to the global value for this platform (and explains how to get that default, by leaving blank)
(cherry picked from commit 16b17c15f9fc29e9480431b5bc7bebe2bd4b6230)

Give settings section a more helpful/standard title to match other GUI settings tabs
(cherry picked from commit ca55edc39342865816feef390616be8b770c889b)

Self correcting - poor english
(cherry picked from commit b56769c30a23af9f575ee4a5f056558ef8322f95)

Accuracy

Large keys are not "slower to use" in many cases, since they are only used to validate or set up a session. An ongoing session usually transfers to a symmetric algorithm once established, and the user won't notice the short extra delay in session startup....

missed a comment I added and shouldn't have - removed
(cherry picked from commit 7c684f3b95f641134496bc1210cfb2d814468767)

Update OpenVPN Wizard to include missing key sizes

...and add some useful info to guide the user.
(cherry picked from commit 49810252681df9bd553e2221c885ceffaa2c4c7f)

Added option to System > General Setup > webConfigurator to change the title of the Help menu in the navbar to either the system hostname or fqdn.

(cherry picked from commit 1d12996755ee6fb9b9e163d292bdba160a926e64)

Make QinQ interfaces work again

(cherry picked from commit 1322ee22354f1a6e184819fb7009a2996b63de97)

Allow IGMP Proxy logging verbosity to be selected via system log settings (PR 2901)

(cherry picked from commit 2bd0585e30e5ec8fc3b79ca3f579bf9a7c1bcbc8)

adding privileges and separating DNS Resolver overrides from general settings

(cherry picked from commit fc76a1e390c8ce9579df31457c74d1d0e572b78d)

Fixed #6504 by making table sortable

(cherry picked from commit 55f67b5abd9b809807e328477779d97120908273)

jQuery datepicker added to interfaces.php and interfaces_ppps_edit.php for setting custom expirey date

(cherry picked from commit d85d82b7686d5899948e6ec4b1587e74937820cf)

Fixed #6516 by replacing HTML5 datepicker with jQuery widget

(cherry picked from commit 53c38ff16c1eb8743e69d506f69167c88cf34910)

fix rowhelper select_source empty combo

while using $config['installedpackage']{['...'] as source

update d3.js

update nvd3 files

Fixed #6514 by requiring string starts with letter ot underscore

(cherry picked from commit f0a053846d6cde2724c47b5553e1395cfd21445c)

Fixed #6498 by providing new address type argument to Form_IpAddress(). In this case it is specified as "V6".

(cherry picked from commit 3e4adb7139b4cddbb06a2aba7e0727d1762b35ee)

Incorporated ssl changes

Fix typo

Fix redundant phrasing.

Remove tab_array from interfaces_groups_edit.php to be consistent with other *_edit files

Correct value for 9600. Ticket #6416

Fix #6468 Do not allow edit of day and times

in rows of time ranges for a schedule.
The code was always intended that the user uses the calendar pad and start hour/minute stop hour/minute drop-down fields to enter days and time range. If an existing day-time-range is wrong, then the workflow is to delete the row and then enter the correct day-time-range using the calendar pad and start hour/minute stop hour/minute drop-down fields....

Validate submitted groups when editing a user. Ticket #6475

Add input validation to system_groupmanager.php to prevent invalid members from being submitted. Ticket #6475

Fix #6463 Dest net alias matching on page load

Do not set destination field to use customarray
Note: dstbeginport_cust does not exist on this page, so I got removed it here also to avoid future confusion.

Fix #6460 Interface mismatch apply changes button

Rework pkg_mgr_install.php:

- Stop using id parameter for additional packages, keep using it only
for firmware upgrades
- Created to control variables $completed and $confirmed to check all
the stages and make it easy to understand what is happening
- Stop using $pkgid and use $pkgname instead...

Fix variable name s/POST/_POST/ and also parameter name s/complete/completed/

Fix indent

Improve readability

Improve readability

Simplify mode parameter validation

Remove redundant check since pkgcancel is never set

Validate mode parameter and use sanitized variable on other places

Fix save and reset buttons on status_lb_pool.php. Ticket #6254

Fix #6440 RADIUS issued IPs

This is a checkbox - the state in the config is stored as set or not set.
This should fix the reported issue. I don;t have a system right now to test, but the bug seems obvious.

Allow - and _ in sysctl values. Ticket #6438

Don't override type so changing it is possible. Ticket #6439

Allow - in TFTP Server field. Ticket #6433

Comment typos

I can't resist fixing them when I see them.