pfSense

GET/POST conversion system_advanced_ioctl

Typo

GET/POST conversion for camanager and certmanager

Allow GET-to-POST js to handle confirmation dialogs on delete (anything)

Update translation files

Regenerate pot

Merge pull request #3512 from phil-davis/patch-3

Merge pull request #3511 from phil-davis/patch-2

Merge pull request #3508 from phil-davis/sethelp-6

Merge pull request #3519 from phil-davis/patch-6

Merge pull request #3520 from phil-davis/sethelp-9

Merge pull request #3518 from phil-davis/patch-5

Merge pull request #3516 from phil-davis/patch-4

Merge pull request #3517 from phil-davis/sethelp-8

Merge pull request #3513 from phil-davis/sethelp-7

setHelp and gettext for system*

Fix keylength.com href in system_usermanager

The literal <a href=... text was displaying here, not an actual link to keylength.com
While here, reformat to take the HTML out of the main setHelp string.
Note: the literal text keylength.com has also been taken out of the main setHelp string, because it is literally the referenced site URL text, so it would not be appropriate for it to be translated.

Fix system_gateways_edit setHelp sprintf warning

The code at line 759 emitted a warning because of the bare '%' in the string.
Other changes are to clarify and tidy up some other sprintf strings.

setHelp and getttext format for status*

status_upnp remove nested getext()

I don't think this does anything useful.

services_dyndns_edit % needs to be escaped

Automatic GET to POST functions moved to pfSenseHelpers.js so they can be used by any page

Improve comments

Experimental method to convert GET calls to POST

Merge branch 'master' into sethelp-7

setHelp strings for services*

services_dhcpv6_relay fix setHelp array parameter

same thing here

services_dhcp_relay fix setHelp array parameter

Another one using the old array format.

Rever changes escaping '%' chars in help text. No longer required.

Only use sprintf in setHelp() if more than one argument is received
This should eliminate all the issues caused by packages with embedded '%' in their text

setHelp format for services_captiveportal

Part fix #7233 keep correct staticmap_array_index

The index needs to be incremented even for entries that were skipped for display because they (for whatever reason) have no MAC or CID set. So use the key directly from the array.

Part Fix #7233 Allow deletion of empty static map entries

Merge pull request #3486 from phil-davis/diag-backup

Rather than setting the value directly, minimize exposure to eval() in update_config_field() from wizard.php by constructing a variable reference, then set the value using the reference rather than passing user input through eval(). Fixes #7230

Convert easyrule.php to use a confirmation landing page so that the parameters can be submitted via POST. Also, remove the JavaScript confirmation box since it is now redundant. Fixes #7228
The confirmation page displays the submitted parameters for an extra user sanity check. Also fixed a bunch of page formatting issues that were not apparent because users rarely if ever saw output from the page.

interfaces_ppps_edit remove embedded HTML from setHelp string

There was only one of these remaining to do.

Merge pull request #3501 from phil-davis/patch-1

Merge pull request #3503 from phil-davis/patch-3

Merge pull request #3502 from phil-davis/patch-2

Encode the contents of pkg_filter before output. Fixes #7227

Fix #7226 Package installation message is incomplete

This makes it remember pkgname after the install finishes and the form is re-submitted.

pkg_mgr_install remove embedded HTML from result strings

Encode 'from' and 'to' before output on pkg_mgr_install.php. Fixes #7225

Update translation files

Regenerate pot

Merge pull request #3494 from lukehamburg/copy-duid-patch-2

interfaces_ppps_edit fixes that will work on 2.3.3 also

1) Make "The MTU is too big" message actually come out. The code around line 300 was rubbish (maybe from before bootstrap?).
2) Show friendly description rather than 'wan' 'lan' opt1' in interface link list....

Merge pull request #3484 from phil-davis/sethelp-empty

Merge pull request #3500 from phil-davis/patch-5

Merge pull request #3499 from phil-davis/sethelp-review4

Merge pull request #3497 from phil-davis/patch-3

Merge pull request #3496 from phil-davis/patch-2

Merge pull request #3495 from phil-davis/fbegin-fend

Merge pull request #3487 from phil-davis/patch-1

Merge pull request #3473 from jxmx/7206_route53

license.php getext formats and breadcrumbs

1) I added a breadcrumb because the "?" "help on this page" icon does not display nicely without the breadcrumbs section.
2) Make various gettext() a bit nicer.

setHelp and getttext for i*.php files

interfaces_bridge_edit setHelp and input_errors formatting

This had enough things to be worth its own pull request.
1) Get embedded HTML out of setHelp etc strings.
2) Fix some array parameters to setHelp (these were causing warnings).
3) Make various input error messages display the friendly interface name, rather thn "wan", "lan", "opt1".

setHelp formatting for interfaces.php

There was a fair bit of it, so I have put this in its own pull request.
1) Gets HTML out of the strings that go for translation.
2) Line 3365 - the words here about "hexadecimal" now go in the text directly in the setHelp so the translators will get access to them....

fbegin.inc and fend.inc are no longer used

add Copy DUID convenience button
- adds `Copy DUID` convenience button/js
- no page refresh or AJAX

Merge pull request #3490 from phil-davis/sethelp-review3

Do not attempt to translate '-DIVIDER-'

'-DIVIDER-' is a keyword here. If someone does translate this, then the divider is going to go missing when in their language.

user/local/www inc file gettext improvements

Internationalization graph.php

1) A few extra strings to be translated.
2) The scale_type code values 'up' and 'follow' need to be kept as those strings in the JS scale_type variable. The text to be translated needs to be in a different variable that can be in translated form for display. Otherwise things go wrong when in a different language....

Merge pull request #3465 from phil-davis/system-widget-filter

Revert "Commit updates to the locale messages as best I can"

This reverts commit 7b25b213ee572f9d5471c29a3b3a1cff99cc55d3.

Revert "fix locale as best I can"

This reverts commit e25261e4e210376e3db382a1ac52b61b9753a79c.

Update translation files

Regenerate pot

Merge pull request #3480 from PiBa-NL/certmgr_20170206

Merge pull request #3485 from phil-davis/form-var-names

Merge pull request #3482 from phil-davis/patch-4

Merge pull request #3478 from phil-davis/sethelp-review2

Merge pull request #3477 from phil-davis/patch-2

Merge pull request #3476 from phil-davis/sethelp-review1

diag_backup do not use button text for comparisons

Use unique var names in Input.class.php

Do not pass empty string to gettext

Remove unused restore_ver from diag_backup

I cannot see where this is used any more. The functionality seems to now be done in diag_confbak

Escape '%' in help text

certificatemanager, don't show information from previous certificate if no cert or csr is present in the cert

setHelp and gettext changes for firewall* pages

Firewall Rules Edit translate Source and Destination

These bits were not translating.
Line 1406 could possibly be like:
```
$group = new Form_Group($name . ' ' . gettext('Port Range'));
```
But then that assumes that in every target language the translation of "Source" or "Destination" can be put in front of the translation of "Port Range"....

Remove HTML from strings in diags files

Merge pull request #3469 from phil-davis/fw-nat-out-edit-other-subnet

Merge pull request #3472 from phil-davis/patch-2

Merge pull request #3474 from lukehamburg/lukehamburg-patch-1

Merge pull request #3471 from phil-davis/patch-1

Add a '.' to the help text for consistency

Fixed embedded '%' that was breaking setText.

fix locale as best I can

Commit updates to the locale messages as best I can

Update help message for Zone ID for new region requirement

system_advanced_admin remove href from setHelp strings

I think that giving long strings that contain various HTML tags in-line through for translation is going to be error-prone. Actually we do not want the translators to accidentally also translate href like system_usermanager or accidentally miss out some quotes or brackets. It seems safer to substitute these in using %s formatting....

system_advanced_admin remove setHelp array

Fix firewall_nat_out_edit dependency on English

System Information widget filter gettext()

Update translation files