pfSense

Regenerate pfSense.pot

Fix #5690:

- Remove parameters from set_language()
- Add a global variable for default language
- add env var for LANG, otherwise it won't work

Fixed #5789

Merge branch 'add_call_gettext_diagnostic_menu_pages' of https://github.com/brunostein/pfsense

• 'add_call_gettext_diagnostic_menu_pages' of https://github.com/brunostein/pfsense:
  add call gettext function for translate

Merge pull request #2495 from phil-davis/gt1

Add gettext to select option names where required

Internationalization graph guiconfig head index

add call gettext function for translate

Regenerate pfSense.pot

Regenerate pfSense.pot

Change dependency icon back to a paperclip (globe seems to imply more than intendend here), fix appearance of the text.
<ul> without <li> is invalid, remove. Also move the icon to a separate i tag, putting it in an a tag changed the font in an undesirable way.

Merge pull request #2486 from NOYB/Special_Panels_-_Show/Hide

Add a close button to Edit load/save messages

Other places use more standard code for printing success/error messages.
But the Edit File page is a bit different. The standard code puts a
close button on messages so that users can dismiss them if they like....

Do not call gettext() for empty string

Fix "View content" href

Merge pull request #2490 from phil-davis/info-block1

DHCP - Decode value while validating contents

https://forum.pfsense.org/index.php?topic=105654

Remove close button from firewall_rules

Issue: https://redmine.pfsense.org/issues/5788

Merge pull request #2489 from NOYB/Status_/_System_Logs_-_Tab_Array

Merge pull request #2488 from PiBa-NL/23_rulesedit

Remove remaining PBI symlinks not registered in .pbiopt file. If should fix #5221

Make sure code reaches pbi_delete

Think the term 'associated' may be better here than 'special'.

Use icons instead of text.

Shorten titles to be more consistent with other title bar shortcuts and also match the option setting title.

Status / System Logs - Tab Array

Only call display_top_tabs function if there is a tab array to display.

The display_top_tabs function prefixes the type parameter with 'nav nav-'. So passing 'nav nav-tabs' adds a nonexistent class; 'nav-nav'. Only pass 'tabs' as the type.

firewall_rules_edit, load advanced settings flags-any and sloppy-state back into webgui

Comment fix

Remove debug

Escape HTML on re-saving separator text

Fixed #5784

Apply recommended changes.

Fixed #5781

Provide warning message onleavinghte page
Allow Esc key to cancel a new separator
Allow Enter key to save a new separator

Special Panels - Show/Hide

Add configuration option to show or hide special panels.
When a panel is hidden a button is displayed on the page title bar to toggle the panel display.

Status / System Logs / VPN / PPPoE Service - Fix Shortcut Links

Fix PPPoE Service shortcut so links show on the breadcrumb bar.

Merge pull request #2472 from dennypage/master

Changed color scheme to use existing bg-* classes
Simplfied color change mechanism
Implemented "Cancel" button

Add colors to the separator bars

Fixed #5781

Eliminate foreach for speed.

New separator text box has focus when created

Fixed issue with separator bar at very top of floating rule list

Merge pull request #2484 from phil-davis/gt9

Merge pull request #2483 from phil-davis/patch-5

Merge pull request #2482 from phil-davis/patch-3

Merge pull request #2481 from phil-davis/patch-2

Merge pull request #2480 from phil-davis/gt8

Merge pull request #2479 from phil-davis/gt7

Internationalization of remaining firewall_*.php

Firewall shaper wizards print_info_box() severity level

Completed basic #5373
May add a color option after some testing

Firewall shaper print_info_box at correct severity

Allow enable/disable rule for Firewall NAT Out

The code for it was all there, but the icon was hidden when the rule was enabled, so there was no wayto click to disable.
It all works for me with just this small change.

Firewall NAT Port Forward rule enable/disable toggle

Provide the rule enable/disable toggle like in NAT 1:1 and NAT NPt

Provide "add top" and "add bottom" buttons for NAT 1:1 and NPt

So that they are consistent with NAT Port Forward.

Merge pull request #2477 from phil-davis/gt6

Internationalize firewall_rules pages

I might have gone too far wrapping '(other)', 'any', 'default', 'none'
in gettext() but actually if translating to a language with non-Latin
script then it can be useful to translate even these sort of single
words, because there might be some people who cannot even read Latin...

Merge pull request #2473 from phil-davis/gt5

Fix browser tab text

Restore separator bar delete functionality

Add Javascript htmlchars() equivalent to dynamically created inputs
Temporarily remove function that broke action icons

Merge pull request #2475 from phil-davis/patch-2

Remove obsolete L7 text from messages

The layer7 condition in the if test for this block was removed when layer7 support was removed in master.
The text of these input error strings also needs to be modified.

Fixup firewall rules schedule status images

1) $iconfn is not the var that contains the 'type' of block or reject.
2) In the bottom if-else of the diff "times-circle" was repeated twice.
3) It seemed odd to me that wen the schedule was out of its time that the icons would always be in "text-danger" color. My suggestion, make them "text-warning" which distinguishes them from the green or red that is shown when the schedule is active.

Standardize NAT NPt

Give NAT NPt GUI the same sort of interface as NAT 1:1
1) Checkbox to select multiple mappings and then delete selected
mappings
2) Tick/cross to enable/disable a mapping
3) Ability to "Add a new mapping based on this one"
4) Double-click to edit an entry...

Clarify input validation output. Ticket #5778

classes/Form/Textarea.class.php, setNoWrap, make it work properly on FireFox and Chromium

Include the zone in link for display of login page so it shows up correctly.

Add standard deviation to gateway status and widget

Added separator delete icon

Prototype #5373

add missing space between words

Merge pull request #2467 from NewEraCracker/widget-tunes

Changed var name sine label is an HTML reserved name.

Fixed #5779
Save/restore group label on delete row

Merge pull request #2469 from phil-davis/gt4

Internationalize firewall aliases and NAT

Merge pull request #2466 from phil-davis/patch-5

Merge pull request #2468 from phil-davis/patch-6

Merge pull request #2464 from phil-davis/patch-3

Add "GoTo line #" control

firewall_nat_1to1 fix save button text

There was no text appearing when hovering over the Save button, and Save did not actually save the changed rule order.
Make the code the same sort of stuff as in firewall_nat and it works.

firewall_nat_1to1 config descr and delete button

1) The description written when the config was saved said "Outbound" but should be "1 to 1". gettext() it while here.
2) The Delete button had no text displayed when hovering over it - make it like in firewall_nat.

Use current interface description for breadcrumb

If you enter invalid stuff in the interface description - e.g. "123" - and press save, then you get a warning about it, but the breadcrumb changes to "Interfaces: 123" - the wrongly entered description (that was not applied)....

Small tunning to all aspects involving widgets

1) Perform exclusion of non .inc files while reading directory. 2) Be more strict when checking for widget title. 3) We are in the PHP 5.5 age. We can convert certain pieces to anonymous functions and overall better coding.

Fix #5778 do not save changes if interface description matches an alias name

See https://redmine.pfsense.org/issues/5778 for details of how to reproduce the problem.

Note that similar code to make the "Sorry, an alias with the name XXX already exists" message is also at the top of interfaces.inc - it compares the current interface descr from the config with the currently existing alias names. That check would help warn the user if someone managed to add an alias name that matched the interface name. I guess it was there from some time in the past when the alias edit code did not cross-validate the alias name with the interface descriptions. I have left that check there - it does no harm to have it "just in case"....

Improved widget sorting (case insensitive)

Remove tab embedded in text - firewall_aliases_edit

Internationalize firewall_aliases_edit

1) Wrap all the various arrays of text that are displayed to the user in gettext()
2) Give the possibility to translate the singular of words like "host", "network" that get substituted into message strings.
3) Where there are multiple %s in an sprintf() use %$1s %s2s to be really sure, even though it seems to be a case where the order of substitution will never be swapped.

Display existing updatefreq

when user is editing an alias type that uses the subnet CIDR field as the URL table update frequency.
Forum: https://forum.pfsense.org/index.php?topic=105457.0

Firewall / Aliases / Edit - Pattern

Address field is used for a wide variety of input types. Including URLs which require a much greater character set acceptance.

Merge pull request #2454 from phil-davis/patch-2

diag_testport change some tabs to space

diag_testport alert message logic re-factoring

as suggested by @rbgarga

Merge pull request #2456 from phil-davis/gt2

Merge pull request #2458 from phil-davis/gt3

Merge pull request #2460 from NOYB/Firewall_/_Schedules_/_Edit_-_Add_Minutes_45

Merge pull request #2461 from NewEraCracker/php-standards

fix typo

s/schedule/alias