Fix lineup of copyright lines
and module names and other bits of formatting and typos in headercomment sections.
Welcome 2015
Disable dhcp server when interface is disabled. Ticket #4119
Fix #3790:
- Do not let 2 interfaces to setup the same track6 prefix id- Show correct prefix id range for each interface
Try to not make useless entries in the config file for very rare used configuration values. Makes config file readble and with less size
validate MTU and MSS as integers, and don't allow MSS larger than pf will accept to avoid broken rulesets.
convert_real_interface_to_friendly_interface_name() goes and checks the parent and this gives wrong information 99.9 percent of the time on scenarios like when this is called for unassigned vlans etc, while its real purpose is just to check if the interface is assigned and return the intermeddiate/config name of the interface. Leave the get_parent_option there in the function but it needs to be asked specifically for.
Ticket #2786 there is an issue with convert_real_interface_to_friendly_interface which might return not expected data as in the situation checked for vlan case her ein the validation. Avoid for this case here the issue to allow properly setting mtu on vlans with not assigned parent.
Don't unset these items for PPP configurations as they're not configured here and doing so loses settings configured in interfaces_ppps_edit.php. Ticket #3727
Fixes #3727 Do not unset configuration values from ppp config if not needed.
6RD Rapid Deployment is akin to ATM Machine, PIN Number, ... read: it's redundant. let's just call it 6RD Configuration.
Don't allow interface descriptions that are strictly numbers as thatgenerates an invalid ruleset. Ticket #4005
fix variable typo
fix text
modify copyright statement to reflect reality
Fixes #3727 Do not unset ondemand for ppp type interfaces since it is controlled here only for pppoe/l2tp
Make sentence more accurate as pointed out by phil-davis
GIF interfaces MTU must be something between 1280 and 8192, make the correct check. It fixes #3927
Restore id for cancel button to fix js error
Remove almost all calls to history.back() and make Cancel button back to HTTP_REFERER, there are a couple of places I didn't touch on this commit because it requires more work
Implement a function to kill dhclient process, sometimes it takes a little time to die, so use a sleep(1) there
Fix #3790. Fix IPv6 Prefix ID check using interface user choose before save
Fix #3575, do not allow user to set IPs for GRE interfaces on interface edit page.
Replace Header() calls by lowercase
Tidy up "interfaces.php" XHTML
Tidy up Anchor tag and PHP GETTEXTSwap double quote and semi-colon in ONLICK statement
xhtml Compliancereplaced <br>, <br/> and </br> with <br />
Improve checks for params 'id', 'dup' and other similar ones to make sure they are numeric integer, also, pass them through htmlspecialchars() before print
This one too.
Element id's are to be unique. 'provider' used is elsewhere.
Better done globally here in the function.
XHTML Compliance
Interfaces
Merge pull request #945 from phildd/master
Enhance interface gateway data entry descriptions
Some tweaking to handle when switching off dhcpv6.
Add escapeshellarg() calls on exec parameters. While I'm here, replace some exec() calls by php functions like symlink, copy, unlink, mkdir
Revert "Fix #3350. Do not destroy an interface when it's being disabled"
Ermal reported issues when changes are made on VLAN parent interfacewith this patch. He did other changes and interface_configure() will nowbe able to re-create VLAN interface
This reverts commit 5bc623536d8bb3b93e68a1b1535c9de582721a09.
Make sense of interface mtu handling code. No need to do unneeded operations. This fixes slow boot times and proper handling of mtu for vlans though some work or better model is needed for other interface types. Manual merge of 53555bf2f796cd53cf649410fe1827a9a45fc4a7
Prevent network or broadcast address to be set on interface (console, GUI and wizard). It should fix #3196
Fix #3350. Do not destroy an interface when it's being disabled
Revert "Define dynamic gateway for GRE interfaces and do not user to define IP address to the interface. Fixes #3280"
Another solution will be implemented
This reverts commit 6721d6d0443bd7e697bd6ca33f470c801608df7e.
Define dynamic gateway for GRE interfaces and do not user to define IP address to the interface. Fixes #3280
Respect default gateway option when adding a gateway from interfaces page. It fixes #3230
Merge pull request #795 from razzfazz/ia-pd-hint
add option to send prefix hint for requesting desired prefix length for delegation (for master branch)
Remove call-time pass by reference for do_input_validation, helps ticket #2565
add option to send prefix hint for requesting desired prefix length for delegation
This change adds an option on the interfaces page for sending a prefix hint for the selected delegation size. If enabled, a "prefix" field requesting :: with the appropriate prefix length (64 - dhcp6-ia-pd-len) is added to the "id-assoc pd" entry in the dhcp6c config file. This hint is required for requesting prefixes shorter than /64 from Comcast.
Update interfaces.php
fix text - Capitalize sentence. s/this/This
Implement an option to allow using the IPv4 connectivity interface for sending the dhcpv6 information. Usually useful for ppp[oe] type links and some ISP
Fix editing saving dhcp6prefixonly state
Reported in redmine #3097 and forum http://forum.pfsense.org/index.php/topic,64483.msg350255.html#msg350255
Remove remaining hardcoded theme names
Remove errant double quote.
Add a checkbox that can be used to request only a IPv6 prefix without a IPv6 address. Some ISPs DHCP6 servers will fail the request if both are requested and only a Prefix is allowed.
Conflicts:
usr/local/www/interfaces.php
Merge pull request #684 from N0YB/Advanced_DHCP_Client_Options
Add show/hide to the new "Reject Leases From" row
fix typos
Show for Basic and Advanced. Hide for Config File Override.
Merge branch 'Advanced_DHCP_Client_Options' of https://github.com/N0YB/pfsense into N0YB-Advanced_DHCP_Client_Options
Conflicts: usr/local/www/interfaces.php
Add a field to allow rejecting DHCP leases from a specific upstream DHCP server.
Fix max length for wpa passphrase, it fixes #3034
Fix IPv6 Prefix ID default value
. Always initialize it to 0 when it's undefined. Remove unecessary initializations and checks. Bump config version to 9.5. Write an upgrade config function to initialize old configs properly
Add summary to TABLE tagsAdd missing opening and closing cell tags in TR tagTidy up closing FONT tagRemove duplicate closing TD tag and duplicate closing TR tagAdd missing opening TR tagRemove duplicate width statement...
Update HTML Boolean operatorsClose a couple of missed INPUT tags
Close INPUT tagsAdd closing FONT tag
Close BR and IMG tags and add ALT statement to IMG tagsChange ONCLICK and ONCHANGE to lower case.Add CDATA section to SCRIPT tags
Avoid send user to top of the page when you open add new gateway box
Add a new class called addgatewaybox to make it easier to respect custom themes. Fixes #2900
Remove functions that are not used now with once mode of rtsold
Bring down even rtsold process
Fix indent and whitespaces
Be consistent on the check
Prevent mtu bigger than 9000
Validate MTU changes for VLANs and let user change it again
You can have multiple 6rd tunnels now days
clean up text a bit, make link more apparent
Save ppp info and realif on interfaces.apply to be able to cleanup old configuration when changing interface type. Fixes #2758
Make parent interface and all VLANs use the same MTU. Fixes #2786
Fix validation of conflict between interface ip address and static routes. Fixes #2852
Reconfigure routing when a new gateway is added
Send ipprotocol parameter when adding new gateways from interfaces.php
Add section tag to v6 documentation links.
Put v4 send, request, require & modifies in lease requirements and requests section.No functional changes.
Fix response read for 'add new gateway' applet at interface configuration
Advanced DHCP Client Options & Config File Override
DHCP v4:Protocol TimingSend OptionsRequest OptionsRequire OptionsOption Modifiers
DHCP v6:Interface StatementIdentity Association StatementPrefix Interface StatementAuthentication StatementKeyinfo Statement...
Avoid conflicting interface IP address with static routes. Fixes #2039
Add missing check for IPv6 overlap on interfaces, it complements the change made for ticket #1723
Fix dhcp v6 config section name for console setup and check on interfaces.php, the correct is dhcpdv6 instead of dhcpd6. Fixes #2827
Merge pull request #426 from N0YB/Interfaces_Types_Config_Sections_Spacer_Row
Interfaces Types Config Sections Spacer Row
Fix spacer (last) row display inconsistencyMissed one
Merge pull request #425 from N0YB/Interfaces_Types_Config_Sections_Spacer_Row
Fix spacer (last) row display inconsistency
Interfaces Static IP v4 & v6 Gateway Add New
Fix mismatched table row tags
Two interfaces, carp, ip aliases might be on the same subnet as their parent. What needs to be checked is the ip itself
Check interfaces and VIP IP address overlap
- Check if interface IP overlaps other interfaces or localip from mpd based services- Check if VIPs IP overlaps interfaces or other VIPs address
It fixes #1723
Validate interface IP explicitly as v4 or v6
The IP Address fields on the Interfaces Edit page were just using is_ipaddr to validate them. I could put an IPv4 address in as the IPv6 static IP and it took it and saved it, then got my system in a knot! It even adjusted the subnet bits dropdown when I typed a valid IPv4 address format in the IPv6 filed....
For reloadall on interface_configure() called by GUI
Fix add gateway validation on interface configuration. It should fix #2791
Update usr/local/www/interfaces.php
Variables that equal FALSE are considered to be empty e.g. "0".
Actually destroy in this case
Do the right thing here
Do more strict checks. Also silence some more log_error under debug. Also do some sanity checks on rc.newwanipv6 before doing any operation
Correctly bring down an interface older configuration. Fixes #2758
Preserve "Idle timeout" parameter on interfaces gui. It fixes a problem pointed out on ticket #2641
Update PHP shorthand tag
Standardise all PHP start tags from "" to "