Make sense of interface mtu handling code. No need to do unneeded operations. This fixes slow boot times and proper handling of mtu for vlans though some work or better model is needed for other interface types.
Delete static route when monitor IP is removed, also save monitor IP even when it's disabled
When WANTIME is empty, there is nothing to do here
test only does integer comparison, use bc to compare float
Save status even if no script is executed
On first run REVIOUSSTATUS doesn't exist, so it cannot be UP or DOWN, invert the logic to fix this. While I'm here, check if file exists before cat it
Fix DHCP lease time display, strftime already convert it to local timezone, so we no need to calc offset
Remove 'deny unknown clients' option from DHCPv6 since it's not supported, it fixes #3364
Avoid dashboard divide by zero errors
Fix saving of voucher sync settings.
Fix vpn_pppoe_get_id and stop duplicating pppoeid for multiple servers, it fixes #2286
Merge pull request #860 from iamzam/RELENG_2_1
Allow setting a default scale type preference for the traffic graphs wid...
Also account for a widget being null/not defined, and not just closed/open.
added missing quotes
thx rbgarga
Allow setting a default scale type preference for the traffic graphs widget
I originally submitted this at https://redmine.pfsense.org/issues/2994but it seems that is not used for commits now so I am adding it here.It works great on my box, and I can't see these changes causing any...
Prevent network or broadcast address to be set on interface (console, GUI and wizard). It should fix #3196
Fix #3350. Do not destroy an interface when it's being disabled
One more typo on Alternative Names fill, that was setting type field with $value
Fix a (probably) copy/paste issue that is making all Alternative Names disapear when an input error is detected
Allow an "empty" CRL to be exported, since this is still a valid action.
Fix an issue that changes wrong gateway entry when items are hidden
Many fixes on privileges, ticket #3216:
- Remove unused privilege page-diagnostics-logs-wireless- Remove duplicated privileges- Fix limiter-info, pf-info and system-pftop that were using wrong name- Add privs for services-igmpproxy-edit- Fix ID for acptiveportal allowedhostnames and editallowedhostnames...
system_camanager init $input_errors so array_push works
Fixes input validation when creating an internal certificate. Reported in forum http://forum.pfsense.org/index.php/topic,68849.0.html
Simplify the code.
No need to worry about the second column, we only need to pad the first one.
Rewrite the display_host_results() function to use spaces instead oftabs. It does a much better job of aligning the fields in each columnand works in all the browsers, particularly chrome which doesn'tsupport the tab character.
It still isn't perfect due to the javascript alert() function's...
Call conf_mount_rw before delete user, a better fix for #3294
Prevent a Fall Back Pool from being selected when the DNS protocol is in use. If one is present in the config, ignore it. Fixes #3300
Update zoneinfo to 2013.h
Revert "Define dynamic gateway for GRE interfaces and do not user to define IP address to the interface. Fixes #3280"
Another solution will be implemented
This reverts commit bb6291e0204ffe2828fe9c9425bdae9c8541fe54.
Define dynamic gateway for GRE interfaces and do not user to define IP address to the interface. Fixes #3280
fix typo
Use a more accurate error message, fixes #3282
Add source address selection to syslog settings, so it can work more effectively over a VPN. Fixes #355
Fix #3235
. diag_nanobsd.php: . Since conf_mount_ro() is always being called, always call conf_mount_rw to keep refcount correct . Do not show refcount_read() return when it's -1. config.lib.inc . Increment and decrement refcount even if nanobsd_force_rw is set....
Make the RADIUS settings respect the description of the timeout field. If the timeout value is left blank, use 5 seconds, don't print an error.
Make it more explicit that 'update freq.' unit is days
Remove unused variable
Fix priv name
Optimize DHCPv4 lease display online status for static leases. Do not re-parse complete ARP table for each lease, as it can be slow with large ARP tables.
Fix #3283, use jQuery to change attributes based on id
Set id for select elements created dynamicaly created
Limit CIDR choices for IPv4 on GRE interface, fixes #3277
Fix #3273
- When you disable a interface, it destroys vlan interface from system.Do not report error when interface doesn't exist.- While I'm here, use pfSense_interface_destroy() instead of ifconfig
Actually there is no reason to set a variable just to use once
Fix #3242 and some code cleanup:
- Only explode '/' and set address_subnet when address is a subnet, it fixes issue reported at #3242- While I'm here, do some cleanup on the way addresses are treated - Remove unecessary variable $tracker, we already have $counter set...
Split SSL/TLS into separate checkboxes so that plaintext connections can be made secured by using STARTTLS. Support for SMTPS connections should probably be done away with in future. Fixes #3180
Fix #3268 - avoid pf table names conflict:
. Create a list of reserved table names for the hardcoded ones. Use this list to validate aliases and load balance pool names. Check if alias names don't conflict with LB pool names and vice-versa
added favicon to logged in pages
Replace pfSense with the rebrand
Now that doc.pfsense.org does https and redirects http to https, we may as well send the help links to the https destinations.
Fix display of pools in the LB status widget and on the LB Virtual Server status.
fix pkg_edit.php to show interface description instead of interface name
Patch applied manually. Fixes bug #3245 and old interface names
Remove redundant copies of getNasIP(), it should fix #3234
require service-utils.inc for find_service_by_openvpn_vpnid()
Add missing td
Remove use of undefined var $conn and fix some td class
Respect default gateway option when adding a gateway from interfaces page. It fixes #3230
Allow multiple valid time servers to be entered in the wizard, as they are allowed under System > General
Include the CP zone in the form parameters if one is defined. Fixes access to concurrent graph on zones other than the first/default.
Fix CP stats generation for concurrent users. Fixes #3225
Prevent assigned vlans from being changed the tag.
Fix #3218, reaload filter rules when activate or deactivate dhcpdv6
Certificate Manager, for 'Create an internal Certificate' use the correct 'Digest Algorithm'
Fix ufslabels.sh logic to avoid trying to convert slices which are already using appropriate labels. Fixes #3207
Convert mac address to lowercase when saving to avoid duplicates. It fixes #3195
Make sure to account for IP aliases on lo0 here, or they get duplicated on each CARP sync
No need to treat PHP errors as a crash on -RELEASE for now.
Test growl whether or not growl is disabled.
Do not sync DHPCv6, it must operate independetly. Ticket #3184
Remove failover peer IP settings from DHCPv6, DHCPv6 doesn't support failover the way that DHPv4 did. Fixes #3184
Fix #3127
By default htmlspecialchars does not consider single quotes, what can bea problem when value attribute is set using it. Replace value attributeset to use double quotes on places where it's obviously recieving aresult of htmlspecialchars() call.
Related to Ticket #3045 avoid races in the ntpdate_sync_one script due to killall returning without the process really exiting.
Bring back static routes to fix issues reported on Ticext #3179
Disable state killing on gateway failure by default for new configs.Clarify the text describing the option while here.
Fix issue reported on http://forum.pfsense.org/index.php/topic,66160.0.html
fix text
Merge pull request #792 from razzfazz/RELENG_2_1
add option to send prefix hint for requesting desired prefix length for ...
touch up text, s/nat/NAT/
add option to send prefix hint for requesting desired prefix length for delegation
This change adds an option on the interfaces page for sending a prefix hint for the selected delegation size. If enabled, a "prefix" field requesting :: with the appropriate prefix length (64 - dhcp6-ia-pd-len) is added to the "id-assoc pd" entry in the dhcp6c config file. This hint is required for requesting prefixes shorter than /64 from Comcast.
Show a count of the CPUs if more than one is detected, and show how those CPUs are supplied by the hardware.
Use ipprotocol to check gateway protocol, this fix a issue that allow to set more than one default gateway when it's dynamic
s/require/require_once/g for filter.inc to avoid redeclaration errors in some rare cases.
fix text to remove non-applicable copy/paste from v4 relay
Remove this particular form tag that doesn't appear to serve any purpose on this page, and breaks the drop-down zone selector. Fixes #3153
Add patch from the ticket to fix #3149
Add scope to target when it is a link-local, it helps ticket #3150
Revert "Improve sh syntax using ${} for all variables"
This was cherry-pick'd by mistake
This reverts commit 1702a838194d2f4ffaa99359f888a42b0832472a.
Merge pull request #778 from N0YB/patch-11
Update functions.inc.php
May as well remove this errant td end tag too.
Strip off scope before attempting to resolve the IPv6 IP here.
Fix gateway widget size change on first update.Inner table size changes because the table in update data does not have the same attributes as the widget. i.e. border, cellpadding & cellspacing.
Rather than doing auto-detection, fall back to a glob for now when listing potential PPP serial devices. This will allow us to push ticket #2433 back to 2.2 with a more proper long-term fix for the auto-detection.
Fix Diag > Tables AJAX fadeOut after deletion for rows with CIDR mask format.
When renaming or deleting a virtual server, clean up the old relayd anchor name. Otherwise the rules are still there and valid, and will cause problems as they will override the new VS settings. Also clear out the anchors when stopping relayd or starting fresh that way no old settings could conflict.
Improve sh syntax using ${} for all variables
Also take dhcpv6 into consideration even here.
Relax advanced options firewall rules tests
Various advanced options are now possible for any protocol since https://github.com/pfsense/pfsense/commit/653bde345e8f960de5bc745fe74e64d8ef3fd2d3So allow these through the front-end GUI validation also.Code change for 2.1 branch.
Fix double-click to edit on OpenVPN CSC entries