Added missing gettext()
And zapped some
interfaces_bridge.php Conversion complete
Ready for review
remove unused variables refs #173
Trivial formatting changes. removed unneeded script
Updated as suggested
Thanks
Add table-responsive div
diag_logs_filter.php Conversion complete
Ready for review.This conversion was fairly involved due to the in-line controls, dualfilter forms and the resolving of IP addresses within a table cell.
The filter form layout could be better.
I have left the in-line DNS lookup via table cell classes in place. It...
Removed debugging
Fixed $tab_array[]
diag_ipsec_sad.php conversion complete
Ready for review.
Merge pull request #158 from sbeaver-netgate/system_firmware_settings
Convert system_firmware_settings.php
Merge pull request #154 from sbeaver-netgate/diag_resetstate
Convert diag_resetstates.php
Merge pull request #152 from sbeaver-netgate/status_rrd_graph
Convert status_rrd_graph.php
Merge pull request #206 from sbeaver-netgate/services_captiveportal_edit
Convert services_captiveportal_edit
Remove unneeded gettext
Trivial format changes
status_rrd_graph.pgp Conversion complete
GET form converted to POST. Date/time controls revised. Tested with allgraph types and control options.
Fix but where value in Textarea wasn't processed. Fixes #216
Merge branch 'bootstrap' of ssh://github.com/SjonHortensius/pfsense into bootstrap
Revised as suggested
Thanks!
It would be very helpful to have a phpdoc to document the Formsframework.
I had not noticed the setPatter method :(
Merge pull request #204 from sbeaver-netgate/load_balancer_settings
Convert load_balancer_setting
remove deprecated align attribute #195
Merge pull request #195 from sbeaver-netgate/diag_ipsec_leases.php
Convert diag_ipsec_leases.php
proper indenting; reveals redundant </div>. Warning; gettext madness..
refs #202
Merge pull request #202 from sbeaver-netgate/license
Converted License
removed enormous form toggle, that's meant for smaller sections.
Also implemented new MultiCheckboxes. Refs #163
You are so right!
Toggle action updated
The toggles initial states were initially inconsistent after saving theform. Several js remedies were tried but the only consistent successwas obtained when manually setting the initial states of the sectionslike so:
if($pconfig['enable'])...
service_snmp.php WIP
Help required with nested toggles
Merge pull request #194 from sbeaver-netgate/diag_ipsec_spd.php
Converted diag_ipsec_spd.php
Fixup interfaces_qinq refs #187
interfaces_qinq Conversion completed
Converted diag_nanobsd.php, clean manual commit #178
Merge pull request #159 from sbeaver-netgate/system_firmware_restorefullbackup
Converted system_firmware_restorefullbackup.php
services_captiveportal_zones_edit.php Conversion complete
load_balancer_setting.php Conversion complete
license.php Conversion complete
Converted spaces to tabs, corrected indenting, added missing </p>,added panel divs, corrected missing spaces in copyright etc.
diag_ipsec_leases.php Conversion complete
diag_ipsec_spd conversion complete
Support new Form('text') too, convert existing custom buttons
+ fix html @system_firmware
Convert diag_dump_states_sources
Minor tweaks, hellip in interf_gif, typo in rss.widget
plus rewrote traffic_graphs.widget to new format
Merge pull request #191 from Bouwdie/services_dhcpv6_relay
Converted services_dhcpv6_relay
Merge pull request #190 from Bouwdie/services_dhcp_relay
Re-introduced incidentally removed interface filter.
Added panel-body
The
I experimented with several ways of presenting the “no logs to display”message. This was the cleanest.
diag_logs.vpn.php Conversion complete
In guiconfig.inc dump_clog_no_tables() now returns the number of loglines printed allowing for an information message if there are no logsto print.
Tabs fixed in that file.
Revert "Re-introduced incidentally removed interface filter."
This reverts commit e3d953d5f4eac06672d1331c6ff9fe88f88a3c51.
Copied util functions from services_dhcp_relay.php.Migrated to form class.
Append button to control group instead of control label
Refs. #142
Clean.sh
Implemented new MultiCheckbox feature, refs #142
Form - introduce MultiCheckbox(+Group) #142
Minor edits per SH
Minor edits as suggested
Make consistent #183
interface_gre.php Conversion complete
Oops, move NAV to correct location #184
Make consistent #182
interface_gif.php Conversion complete
fixed typo, correct $tab_array in interfaces_groups.php #184
cleanup interfaces_groups.php
interfaces_groups.php Conversion complete
Page updated for compatibility with the other interface_* pages
diag_patterns.pgp Conversion complete
Note: The “Browse” button has some alignment issues that should beaddressed.
guiconfig.inc updated
dump_clog_no_table() now returns the number of log lines printed sothat the caller can display a message if there were none.
print_info_box() now accepts an optional class argument allowing thecaller to specify the alert box appearance as in:...
diag_logs_filter_dynamic.php conversion complete
Table can be popularized both on initial load and at timed intervals,hence the button needed to be specified in both files.
Put something usefull in placeholder for Filter expression
Merge pull request #172 from sbeaver-netgate/diag_logs_filter_summary
Convert diag_logs_filter_summary
Merge pull request #165 from Bouwdie/services_dhcp_relay
Covnert services_dhcp_relay + bugfix in IpAddress
If a btn-danger has a title, use that instead of generic for confirm()
simplify xhr delete button
Merge pull request #155 from sbeaver-netgate/diag_dump_states
Convert diag_dump_states.php
Merge pull request #162 from sbeaver-netgate/system_hasync
Converted system_hasync
Merge pull request #151 from sbeaver-netgate/status_rrd_graph_settings
Converted status_rrd_graph_settings.php
Remove 'form-control' class from file inputs
Refs. #180
diag_logs_filter_summary improved per SH
Thanks for the suggestion. Can’t believe I didn’t see that :(
Merge pull request #161 from sbeaver-netgate/diag_logs
diag_logs - Added warning for DHCP
Merge pull request #150 from sbeaver-netgate/diag_pkglogs.php
Converted diag_pkglogs.php
Display inner tabs as tabs
- Fixed indenting- Fixed matching closing tags- Moved action buttons to separate <nav>
Refs. #22
Removed unneeded var
Converted img to btn-xs button
diag_logs_filter_summary conversion complete
The previous charing system is not compatible with JQuery (because itmakes use of its own $() macros and converting the code would behorrible. It is not responsive or attractive anyway.
The library has been removed and replaced by d3pie.js. The page has...
Make save button for widget configuration better visible
Refs. #48
Merge https://github.com/SjonHortensius/pfsense into bootstrap
Revert button>input so we can keep using $name
refs #101
Fix print_info_box_np with apply button
- Wrap message in container to float button to the right- Fix syntax error
Refs. #101
Replace td's with th's and make table responsive
Refs. #168
Combined two if($curcat . . blocks
Updated per SH suggestions
Improved as suggested
Merge pull request #157 from sbeaver-netgate/system_firmware
Convert system_firmware conversion
Rewrote xhr javascript, applied .form-inline refs #153
Merge pull request #153 from sbeaver-netgate/status_graph
Inital conversion of status_graph.php
Merge pull request #146 from sbeaver-netgate/status_ntpd
Converted status_ntpd update
Merge pull request #145 from sbeaver-netgate/status_interfaces
Converted status_interfaces.php
removed red. indenting + unused variable refs #139
Merge pull request #139 from sbeaver-netgate/status_gateway_groups
Converted status_gateway_groups