pfSense

Tweak formatting of SMTP notifications

Notification code updates

• Rework how notice queue files are setup and maintained, which should
  allow all users to send notifications now without error. Implements #14337
• Update code for PHP 8.x in frontend and backend
• Fixup repeat message detection a bit to improve chances of it catching...

Message queue handling improvements. Fixes #14031 Fixes #14061

• Do not attempt to process the message queue without sufficient
  privileges.
• Check for permission to write the message queue and for write
  failures and bail early if there is a problem.

Update copyright years to include 2023

Rector direct global g accesses

Remove unused xmlreader implementation and conditional sourcing

Rector some direct config gets with pure scalar paths.

Rector some more direct config unsets with pure scalar paths

Spelling fixes. Fix #13357

• Incorrect input validation for `dhcp6c` `keyinfo expire` `forever` keyword in `interfaces.inc`.
• Incorrect input validation for associated rule's `Source Port` in `firewall_rules_edit.php`.
• Incorrect `voucher*.` file lock reference in `status_captiveportal_voucher_rolls.php`....

Update the Copyright year of the files owned by Rubicon/Netgate.

Pushover notifications fix. Issue #12614

Slack Notifications. Feature #12291

set_curlproxy() fixes. Issue #11476

Use set_curlproxy() function for cURL proxy configuration. Issue #11476

Update the Copyright year.

A subsequent commit will deal with .po's.

Improve handling of SMTP send errors. Fixes #11063

Revert "Remove non captive-portal logs from Local4 syslog facility."

This reverts commit 6960993dc53c559619fe3f8d8ea903e7730b4fa6.

Provide option for default notification tone to play, rather than being overridden.

Correct use of sprintf

Correcting style issues

Pushover Notification Support. Implements #10495

Merge pull request #4240 from Kapmeister/master

Remove non captive-portal logs from Local4 syslog facility.
Various logs are recorded in local4 in HA situation. They should not be recorded here.
Redmine #97

Correct Indentation

if statement covering multiple lines was formatted incorrectly.

Logic & Formatting

Corrected logic not to perform API to Telegram under certain conditions.

Edited to comply with standard formatting requirements.

Update notices.inc

Formatting corrections on if statements.

Changes to Checkbox & others

Changed the approach of the option from checking box to disable to checking the box to enable.

Test return from API to ensure it's in the correct format.

Various formatting errors corrected.

Simplified some aspects of code.

Update notices.inc

Update notices.inc

Telegram Notification Support. Feature #10354

Readmine feature https://redmine.pfsense.org/issues/10354 ready for review.

Merge pull request #4218 from vktg/smtptest

Notifications page input validation. Issue #8522

Fix SMTP SSL/TLS disable validation. Issue #10317

This is 2020. Issue #9245

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Fix #8821: Deprecate Growl Notifications

Growl appears to be abandoned upstream. No updates in ~5 years, and few if
any users on pfSense

Update copyright notices to 2019. Happy New Year

Add checkbox to disable SMTP SSL cert verification. Implements #9001

The default action is to validate the certificate. If the user knows the
server does not have a valid certificate (e.g. self-signed), this option
will allow encryption to be used without validating the identity of the...

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

Update the Copyright notice for pfSense.

Pretty up the new smtp notification header.

notices, background delivery of growl messages and combined mail messages from a queue so that in case of failure the timeout period for connecting does not impact the functionality of the calling scripts themselves

1st message is delivered directly after it is queued....

Code with multiple %s in etc

Merge pull request #3317 from phil-davis/patch-1

Remove unused print_noices and print_notice_box

When looking into how the notices features work these days, I found that these functions are no longer used anywhere.
Maybe they should be deleted?

Refactor to use notify_all_remote

While looking at notices.inc I noticed (pardon the pun) that notify_all_remote did exactly the same as these 2 lines of code. notify_all_remote() might as well be used here, to save having the same code repeated.

Move copyright from ESF to Netgate

Fix typo leading to syntax error

Ticket #3734: Convert growl related code to use pear-Net_Growl port

Pass along send_smtp_message() return, otherwise message will not be shown when testing SMTP settings

Ticket #3734:

- Added timeout parameter for SMTP configuration
- Removed STARTTLS option, it's enabled automatically by pear-Mail when
server supports it

Ticket #3734: Convert notify_via_smtp() to use pear-Mail

Move to Apache License 2.0

Review license / copyright on all files (final round)

Review license / copyright on all files (1st round)

Add include of functions.inc for declaration of gettext

Store notices safely to prevent potential XSS when notices are displayed locally or by remote systems where they're shipped. Ticket #6154

Fix #6187 Handle Growl IP Address problems

Always use sprintf with log_error

I noticed this while looking at other stuff in notices.inc
If this log_error() call ever happened, it would not have done anything useful.

Internationalize etc inc i through s

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Update license on files from /etc/inc

Update smtp class to latest version, fixes #5604

- SMTP class from
http://www.phpclasses.org/package/14-PHP-Sends-e-mail-messages-via-SMTP-protocol.html
- Adapt code to current version, only change was tls parameter became
start_tls

Respect force parameter even if message is the same of last sent

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Handle multiple notices in the same second

The notices are currently keyed by the Unix time stamp second. If
file_notice() is called more than once in the same second, then the
previous notice is overwritten. Only the last notice in any second
actually ends up in /tmp/notices and thus on the webGUI flashing...

Move main pfSense content to src/