pfSense

NTP Peer mode. Implements #11496

NTP Server SHA256 authentification support. Implements #12213

Validate gpsport. Fixes #12191

NTP Authentication key input validation fix. Issue #11850

Revert copyright symbols

Add registered trdemark symbol where appropriate

Update the Copyright year.

A subsequent commit will deal with .po's.

Add product_label global variable

Introduce product_label global variable, by default with same value of
product_name. The idea is to make it easier for rebranded products to
change the name on all visual texts while internal structures are
preserved.

While here, remove deprecated $g['platform'] and also replace places...

Force NTP peers DNS resolution protocol. Implements #10322

NTP server authentication. Issue #8794

NTP disable clean config fix. Issue #3567

Merge pull request #4269 from vktg/ntpsrvnamevalidation

NTP disable checkbox fix. Issue #3567

NTP Time Server input validation. Issue #10386

Merge pull request #4245 from vktg/defntpmaxpeers

Add option to disable NTP server. Issue #3567

NTP maxpeers default value fix. Issue #10323

Merge pull request #4224 from kiokoman/master

Add localhost to NTP Interfaces. Issue #10348

Update services_ntpd.php

Reword + sprintf

Update services_ntpd.php

variable $min_candidate_peers
and break of long line

Update services_ntpd.php

forgot to change from 25 to variable ..

Update services_ntpd.php

min 4 max 25 default to 5
variable at the start of the file

Update services_ntpd.php

text correction to reflect what David suggested

Update services_ntpd.php

correction as suggested by David from https://redmine.pfsense.org/issues/10323

Update services_ntpd.php

spell correction

Feature #10323

Feature #10323

added knob for max peers min 3 max 10

NTP WebGUI checkbox fix. Issue #10276

This is 2020. Issue #9245

Fix syntax errors

Make NTP minpoll and maxpoll user-configurable. Implements #6787

Fix copyright message years to reflect BSDP -> ESF -> Netgate

Update copyright notices to 2019. Happy New Year

Fix #9121: Initialize arrays to prevent PHP 7 errors

Remove Whitespace

I'm aware this is a very large commit. Let me know if you'd rather have it broken down by file type (ie: PHP/shell scripts) so it would be easier to review.

-RJ

Update the Copyright notice for pfSense.

Add some info to HELP text (no code change otherwise)

NTP background isn't going to be widely known. So provide a bit of info so that it's done properly if someone cares.

For example, it's easy to think a small number is enough, as one might with alternative DNS servers, despite NTP website recommending 4-5 or a pool. So state the consequence of too few servers....

setHelp strings for services*

Fix indentation

Changed max repeat alert to use sprintf get text

Bug #7164 Limit NTP time source fields to the maximum number saved to configuration.

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Merge pull request #3343 from phil-davis/retval1

Breadcrumb links

Correct the method used for input validation of NTP Orphan mode. Fixes #7034

Report problems applying changes

1) Strictly keep track of the accumulating $retval from calls to various
functions that apply changes.
2) Use new function print_apply_result_box() to print a suitable message
in a suitable severity based on $retval

Fix variable name used to pre-fill the NTP orphan mode field, add placeholder with the default while I'm here. Fixes #7034

Use the ntpd "pool" command for more robust timekeeping. Attempting to automatically determine if we are using a pool, and allow it to be set optionally otherwise. Implements #5985

Move copyright from ESF to Netgate

Move to Apache License 2.0

Review license / copyright on all files (final round)

Fix #6590 NTPd Leapfile Upload

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Miscellaneous Textual Corrections

Services - Punctuation

Clean up some services menu punctuation.

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Redmine #5994 services_ntpd standardize advanced buttons

services_ntpd fix leaptext array key name

Use leaptext everywhere - some references were to leaptext and some to leaptxt, so it didn't work.

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Advanced button consistency. Ticket #5965

Icon consistency in Repeatable blocks. Ticket #5965

Move NTP access restrictions to their own tab and add the ability to craft custom restrictions for arbitrary networks. Fixes #4463

Clarify text, ticket #4463

Quote the 1st parameter (constant name) when calling define()

Rename NTP tab to Settings to be more user friendly.

Review of CARP uniqid changes.

It turns out that current CARP implementation is not much different from an IP alias.

This commit converts the IP alias to also use the CARP uniqid scheme, this simplify the code in all other places because now we have only two different cases to deal with:...

Merge pull request #2548 from phil-davis/diag-logs

Fixup old diag_logs references

Note: The shortcuts for upnp were not showing. This was because
shortcuts.inc only includes *.inc files from /usr/local/www/shortcuts
So I have renamed pkg_upnp.php to pkg_upnp.inc
I notice that some time in the past it used to be pkg_upnp.inc because...

More internationalization of servicescode

UI Consistency

1) Put the heading "Actions" at the top of all the "Actions" columns -
it was on some and not others.
2) Some more consistent capitalization of panel titles etc.
3) Most interfaces section edit pages had a section titled like "GIF
Configuration", "GRE Configuration". Make them all consistent, e.g....

Cleanup some text and fix default behavior of some NTP options to match 2.2.6 and what the text described.

Remove $closehead variable

Remove unused variable $closehead

Code style services

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Create the required number of rows for NTP time servers

depending on how many are already defined in the config, making sure to always have a minimum of 1.

Also I used the constant NUMTIMESERVERS that was defined up the top of this file to control the loop that limits the number saved to 10....

Standardize Services NTP breadcrumbs

Oops

Fixed #5535

Type up SCRIPT tags

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

Copyright updates Batch 2 of 3

Moved action-buttons in-line styling to pfSense.css

Javascript refine to hide Delete row button if there is only one row

Completes #5159
All duplicated JS removed to included file

Addresses #5159 by removing hide/show/disable/enable functions to included file

Fixed #5184

Fixed #5183 by converting to PHP table library

fix typo

services_ntpd.php - style fixes, fix typo

bootstrap, use require_once for classes/Form.class.php

Merge branch 'master' into bootstrap

Move main pfSense content to src/