pfSense

Breadcrumb links

(cherry picked from commit edcd75357f0e93b124159314d3306197d5312e6c)

Required fields for System pages

(cherry picked from commit 153c3aa61fe65c51d584a57c032a4805048e3062)

Standardize privilege name capitalization

While looking at some privilege stuff, I noticed that various
capitlization looked inconsistent down the list. This makes the list
look more consistent.

(cherry picked from commit 48157a04dde7b3a56776417cdc7b5e457a660733)

Move copyright from ESF to Netgate

Code style and comments

No functional change - just making style consistent

(cherry picked from commit 9d3e8723171c727cf43338bd8e95ab2bb7e6a66c)

Review license / copyright on all files (final round)

webgui tables, doubleclick event to perform 'edit' action, part 2

(cherry picked from commit 1c10ce9750f3702f433a91754f79e637e1c3369b)

Always use require_once

The usage of require() and require_once() throughout the system is
inconsistent, and "bugs" come up now and then when the order of
"requires" is a bit different and some require() happens after the
include file is already included/required....

Fix PHP Warning about invalid argument supplied for foreach

If _POST['members'] or _POST['groups'] is not set / none selected at GUI, it would give a warning on crash reporter (dev versions)

(cherry picked from commit 9f4722022f0e8114741e8cf1a421520fded8be1f)

Add input validation to system_groupmanager.php to prevent invalid members from being submitted. Ticket #6475

Miscellanous Textual Corrections - Add missing dots to phrases

(cherry picked from commit e4c7d45fc7a294817325354e13f4d5bc4987739e)

Add translations for group type selector

Clarify error message by including group type

Preserve group name on input error

Revised scope handling to allow user to set to remote or local, but only if it is not currently "system"

System / User Manager - Remove Personalizations

Remove "you" personalizations.

Reengineer Form_Button setAttribute

As per what was done for https://github.com/pfsense/pfsense/pull/2765 -
do it to the rest of them.
Seems to work OK.

Partially fixed #6012 by removing space from chars allowed in group names

Revert "Merge pull request #2728 from phil-davis/form_button"

This reverts commit a32bed49516f3df3d104a5026a5b2c74451f348f, reversing
changes made to 9ec9978267a5d1985d6da8ba35d52b7174239d2f.

Internationalize Form_Button text

The text of a Form_Button is not translated internally. Some Form_Button
calls already had the button text enclosed in gettext(), this does it
for the remaining ones.

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

System / User Manager / Groups / Edit

Error: th start tag in table body.

Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).

Fixed #5911

Fixed #5908

Merge pull request #2637 from k-paulius/patch-6

Review alert wording. End sentence with period, remove redundant 'Warning', 'Error', etc. prefixes, since alerts are now color coded. Remove <b> tags.

Indicate in the breadcrumb if we are editing list item.

Synchronize page title with tab title

Convert section titles to title case

Internationalize system user and group code

Fixed #5566

Redmine #5759 print_info_box style

Define the 'success' 'info' etc style of calls to print_info_box()

Code style system_*

Remove all pfSense_MODULE and pfSense_BUILDER_BINARIES definitions, whatever was the reason they were added, it was never finished and it's not being used

Standardize breadcrumbs for User Manager tabs

I think this is the way it should be to make it like everywhere else.
Even when in the "Groups" pages, it is still reached by "System" "User
Manager".

Type up SCRIPT tags

Calling all of these "Page" in the privilege name is redundant since they are all pages and the "WebCfg" prefix implies they are pages.

Added use of class autoloading (GUI stuff only)

Any GUI script that loads the guiconfig.inc file will have access to
the autoloader.

undo earlier commit

Merge pull request #2047 from heper/patch-2

Completes #5400, #3999, #5405
Mote: New ticket will be opened to provide IP address sorting

fix typo

fix Bug #5389

Fixed #5388

Copyright and license cleanup

- Remove personal copyright from people who assigned it to employer (ESF)
- Remove $Id$
- Remove extra spaces

EOL whitespace and header consistency for www

Copyright updates Batch 2 of 3

Various text stuff on the UI

Delete confirmation vi fa-trash automated via pfSense.js

Moved action-buttons in-line styling to pfSense.css

replace and find for icon-embed-btn

Updated button styles

convert system_groupmanager to font-awesome

bootstrap, use require_once for classes/Form.class.php

Fixed #5048
Changed membership dispaly to dual multi-select lists
Provided jQuery to move items to/from lists

Merge branch 'master' into bootstrap

Move main pfSense content to src/