pfSense

Required fields in diagnostics

Add a parameter to install_cron_job to stop it from performing its own write_config. Adjust base system calls to match. Ticket #7146

Packages may still need the old behavior but need tested individually. Once all function calls are confirmed to work without the write, the write_config parameter and call can be removed from this function for good.

Merge pull request #3409 from phil-davis/interfaces-required-fields

Merge pull request #3405 from NOYB/Internationalization

Example of setting required items

Refinement to #7083
Provides setRequired() Javascript function to facilitate making an input required or not dynamically

Internationalization (getttext)

Please also backport to 2.3

Merge pull request #3403 from phil-davis/no-empty-menu

Allow external links to show in menus as they will never match privileges and they are not items that need to be restricted.

Add "required field" highlighting

Merge pull request #3378 from phil-davis/patch-2

fields with <required/> set now pre-pend an asterisk to the field title, thereby causing it to be displayed as a required field (currently an underline)

Fixed #7083

When composing an element with a form.class or via XML, prepend a '*' to the title to indicate a required field. This will cause the "element-required" class to be added to the label. pfSense.css contains the style associated with that class. (Currently a custom underline)....

Do not show empty menus

Merge pull request #3397 from phil-davis/patch-3

Merge pull request #3396 from phil-davis/patch-1

Merge pull request #3390 from NOYB/Status_/_Interfaces_-_Relinquish_DHCP_Lease

Fix copy-paste of ipsec.widget.php file name

Noticed while looking in widget code, might as well fix it.

Fix #7134 Interface Stats widget ifdescrs not defined

When doing testing I had the Interfaces widget open as well as Interface Statistics. $ifdescrs was already populated as an array by the Interfaces widget, so Interface Statistics had (accidentally) gained the benefit....

Protect against forech errors if this function does not return an array. Fixes #7134

Status / Interfaces - Relinquish DHCP Lease

Send gratuitous DHCP release message to server.

Dependency:
To fully relinquish the DHCP lease, the "RELEASE" reason needs to be added to the /usr/local/sbin/pfSense-dhclient-script.
s/EXPIRE|FAIL)/EXPIRE|FAIL|RELEASE)/...

Use friendly description for RA interface name. Fixes #7133

Status / Interfaces - Match Var Names

Match Form Input and Function Parameter Names with associated Var Name.

Use "ifdescr" as form input name instead of "if" since "ifsescr" is the var being passed.
Use "ifdescr" as showDefBtn function var instead of "ifval" since "ifsescr" is the var being passed....

Add filter to SMART status widget

The confirmation checkboxes on diag_resetstate.php should not be checked by default.

Merge pull request #3392 from phil-davis/openvpn-widget

Merge pull request #3393 from doktornotor/patch-2

Do not nag people about passwords mismatch when SMTP notifications are disabled (Bug #7129)

Remove get_openvpnent_key()

Do not nag people about passwords mismatch when growl is disabled (Bug #7129)

These fields tend to get "helpfully" pre-filled with random crap by built-in browser password managers or extensions such as LastPass. No need to bother people with these when the feature is disabled.

Add Filter to OpenVPN Widget

Only show the DHCP Leases Status link if DHCP server is enabled

Does not make sense otherwise, can only contain stale data.

Merge pull request #3385 from PiBa-NL/crashreport-deleted

Fix #7126 RFC2136 links

Add filter to Dynamic DNS Status Widget

crash-reporter, change text to tell crashreport has been deleted after uploading which already happened.. but only delete it when upload is successful.

Format of username in Logout

Merge pull request #3374 from phil-davis/interfaces_widget

Merge pull request #3379 from phil-davis/iface_stats

Merge pull request #3381 from phil-davis/wol_filter

Merge pull request #3376 from phil-davis/multi_dns_servers

Merge pull request #3380 from phil-davis/patch-3

Merge pull request #3382 from ExolonDX/master

Merge pull request #3375 from phil-davis/dyndns_widget

Tidy up "<script>" tags

Tidy up <script> tags by adding TYPE attribute

(https://doc.pfsense.org/index.php/Developer_Style_Guide#HTML_Specific_Rules)

Add filter to WoL widget

Check for duplicate Wake on LAN entries

Currently it is posible to enter an interface+MAC combination that is already in the WoL list. That seems silly.

Add filter to Interface Statistics widget

Add username to logout menu and icon

I find it difficult to work out who I am logged in as. Other software often provides some indication of who is the current logged-in user. An easy way to do this is to add it to the "Log out" text. Then it can be seen either by hovering over the "Log out" icon, or in the System menu....

Display Dyn DNS type if description not found

Add IPsec to the state table interface list.

Redmine #5549 Allow variable number of DNS Servers

Remove excess loops in DynDNS Widget

Add filter to Interfaces Widget

Display client id in DHCP Mapping list

Merge pull request #3369 from phil-davis/breadcrumbs_detail

Merge pull request #3341 from phil-davis/sysprvwarn2

Merge pull request #3367 from derelict-pf/require_state_filter

Merge pull request #3370 from phil-davis/services_widget

Add protocol selection to Radius server configuration

It should fix #7111

Submitted by @ubawurinna at https://github.com/pfsense/pfsense/pull/2687

Merge branch 'master' into sysprvwarn2

Merge pull request #3343 from phil-davis/retval1

Services widget filter checkboxes

Breadcrumb links

Move checkbox styling to the beta file since it produces results that are not consistent across browsers and OS

Fix a case where the ALTQ capability warning was showing incorrectly. Fixes #7102

Further refine checkbox styling

Merge pull request #2902 from NOYB/RAM_Disk_Management

Merge pull request #3368 from phil-davis/patch-2

Merge pull request #3365 from phil-davis/format_duid

Merge pull request #3330 from stilez/patch-54

Merge pull request #3363 from phil-davis/patch-1

Crash Reporter report when no data found

The glob for $crash_files always returns an array - an empty one in the case when there are no matching crash files. So the echo at old line 115 never happened. In any case, if the echo happens, it is spat out as plain text on the GUI outside of all the nice boxes and menus....

RAM Disk Management - Update II - Restore RAM Disk Soon as it is Created and Include Logs

Restoring the RAM disk as soon as it is available will make it easier to include additional content that needs to persist across reboots for packages etc.
Include the logs in the RAM disk store so they will persist across reboots.

Breadcrumb links support

Add requirestatefilter. Implements #7069.

Helper format_duid() for DUID input

Fix typo. Ticket #7007

Rework how IPsec log settings are stored/retreived, adjust the default values. Implements #7007

Don't allow SNMP hostres module to be selected or used with VMware VMs that have a CD/DVD Drive device. Fixes #6882

clarify type of firewall rule needed

A comment on the original PR says that it's not clear if the rule for this needs to be IPv6 or IPv4 with protocol IPv6, and users get confused. I've tried to clarify it here. I've also tried to "de-mystify" it, because it's not that tunneling needs special rules, it's just that any traffic needs rules and tunneled traffic is handled as IPv6 for rules purposes, so it needs an IPv6 rule. But the user may want other rules, or selective rules, so I'[ve tried to be clear this isn't about some "special" IPv6 rule, but rather, just that any traffic desired to pass, will need one or more IPv6 rules permitting it.

Fix #7100

Remove unusued $heading in genhtmltitle()

It came into use in https://github.com/pfsense/pfsense/commit/45eebe10a93fa1e2399c6cdf133ad88dc21ee6e7 but genhtmltitle() has changed since then and no longer uses $heading

Further internationalization

Add missing internationalization

Merge pull request #3346 from scherma/reverting

Merge pull request #3359 from phil-davis/admin_notices

Revise gateway widget config form
Make non-checked checkboxes more visible by adding an outline

Fix username reference

Allow admin to clear notices

Merge branch 'master' of git.netgate.com:pfsense/pfsense

Etc/GMT timezone text using ngettext()

Merge pull request #3356 from phil-davis/gw_widget_filter

Make the emphasis stronger when encouraging use of a geographic location time zone.

Ticket #7089 Enhance Etc/GMT timezone descriptions

These work opposite to the way mere mortals expect.
Read: https://github.com/eggert/tz/blob/master/etcetera

Based on @phil-davis' patch from https://github.com/pfsense/pfsense/pull/3354

Allow hiding of gateways in Gateways Widget

Sometimes there are gateways that I do not care about, so it is handy to
be able to save some space on the dashboard by hiding them.
This uses similar code structure taken from service_status widget. I
made the Save and Clear buttons and all that stuff use the same styles...

Redmine #7089 Add extra help about timezone

We could also add some text like this to encourage users to choose the "Continent/City" time zones.

Remove redundancy, more indentation cleanup

Completes fix for #6972

Correctly report unmonitored gateway status

If an alternate monitor IP has been entered and saved, then the user
checks "Disable Gateway Monitoring" and saves, the alternate monitor IP
is retained in the config - that is handy for when unchecking "Disable...