Remove bonus comma
Fix alias import icon visibility, and change to a more relevant icon. Fixes #5963
Changed all selectoraction to"change" instead of "click"
Fixed #5962
Upon further review, use a more clear and related set of icons for CARP status, play-circle (master) and pause-circle (backup). Ticket #5965
Change shortcut bar status icon to bar-chart, the gear/cog purpose was unclear, looked too much like a settings icon. Ticket #5965
Change "internal" representation of CA on CA and CRL list to an icon, and the inuse indicator on CRLs to an icon. Ticket #5965
Add visual indication of negation on Outbound NAT list. Fix static port representation to use an icon with a helpful title. Ticket #5965
Give a visual indication when a port forward has the negation option active (no rdr). Ticket #5965
Correct the text and placement of the disable and nobinat options for 1:1 NAT rules. Fixes #5966
Slight change to CARP status icons, difference between master and backup status was not clear enough. Ticket #5965
Correct some icon usage inconsistencies. Fixes #5965
Clean up the CARP status widget. Fixes #5964
Move Save button on config history settings inside the panel with the other settings. Fixes #5961
Merge pull request #2717 from NOYB/System_/_User_Manager_/_Groups_/_Edit
Merge pull request #2716 from phil-davis/patch-6
Merge pull request #2715 from phil-davis/patch-5
Merge pull request #2714 from phil-davis/actions
Merge pull request #2713 from phil-davis/patch-3
System / User Manager / Groups / Edit
Error: th start tag in table body.
Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).
Change invalid use of $iface in interfaces.php
At this point $iface is an undefined var. So the last test of this "if" statement is useless.That code fragment was introduced in commit https://github.com/pfsense/pfsense/commit/e4d40f41aafe00353c0069b457a0b1b0d6c20987...
Improve track6-prefix-id handling
1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range....
Add Actions column heading
to other places where it was missing, for UI consistency.
Add Actions column heading for CRL Manager
To be consistent with everywhere else that has a heading for the Actions column.
System / User Manager / Users / Edit
Warning: A table row was 4 columns wide and exceeded the column count established by the first row (3).
Error: Stray end tag td.
On second though, don't use this class on this particular tag in the WoL widget.
Fix up the formatting of the Wake on LAN widget and change the code style so it isn't a bunch of echos. Fixes #5960
Fix load balancer status widget uptime percentage display. Fixes #5959
Destroy reference after foreach
As recommended at https://secure.php.net/manual/en/control-structures.foreach.php
Merge pull request #2708 from phil-davis/patch-3
Limit widget column to dashboardcolumns
Stops widgets from "going missing" when the user reduces the dashboard columns in System, General Setup.If the user just lowers dashboard columns to see what happens, then increases it again, the actual column settings are preserved in the config, so the widgets go back where they were. That seems a good thing....
Correct wording of prefer_ipv4 help text
System / User Manager / Groups / Edit / Add Privileges
Not certain that the list needs to be sorted here. Looks like it is already in order. If it does then a valid callback function will need to be accessible.
Error: Non-space characters found without seeing a doctype first. Expected e.g. <!DOCTYPE html>....
fix whitespace
Add track6 DHCP6 IPs back to interface when applying changes. Ticket #5945
clean up description
Remove help text wrongly copy/pasted from elsewhere.
fix dark theme css
Merge pull request #2705 from NOYB/HTML_Compliance_-_Diagnostics_/_States_/_States
HTML Compliance - Diagnostics / States / States
Bad character - after <. Probable cause: Unescaped <. Try escaping it as <.
Merge remote-tracking branch 'upstream/master'
A PD-obtained subnet is always a /64 on the interface, so should be shown as such here in DHCPv6 server. Ticket #3029
Revise explanation and validation of dpinger parameters.
Move NTP access restrictions to their own tab and add the ability to craft custom restrictions for arbitrary networks. Fixes #4463
Remove Status -> RRD Graphs in favor of Status -> Monitoring. Ticket #5498
HTML Compliance - Diagnostics / S.M.A.R.T. Status / Information & Tests
Remove unused/duplicate ID's; action, device, submit.
Merge pull request #2700 from al-right/master
Shift the values to account for the removal of the gateways one. Ticket #5905
Use correct variable. Ticket #5946
Fix text for OpenVPN client that was copied from server, client's second.
Ticket #5905 remove unused code
Ticket #5905 remove hardcoded colors
Update status_dhcpv6_leases.php
Fix lacking of incrementation of index when two characters have been passed.
Fix check of $n so that the octal value is checked as an octal value.
ticket #5615 fix popover hover
change hardcoded colors to classes
fix styles for bordered table on dark theme
update old styles with new css classes
Read xml files from /usr/local/share/pfSense/menu and load menu entries
Merge pull request #2696 from phil-davis/patch-1
Merge pull request #2697 from phil-davis/patch-2
Merge pull request #2699 from NOYB/HTML_Compliance_-_Diagnostics_/_Edit_File
Merge pull request #2698 from phil-davis/patch-3
HTML Compliance - Diagnostics / Edit File
Attribute width not allowed on element input at this point.<input type=number id=gotoline width=6>Width attribute is only valid on input element for type image.Changed to use size attribute.
Stray end tag input....
Fix DHCPv6 server check to allow track6. Ticket #3029
Add code to handle DHCP leases in multiple pools
1) Add code from RELENG_2_2 https://github.com/pfsense/pfsense/commit/cf3aff59edfa4b101d69ddd694a59fdc580d2299 that checks for leases that are in pools other than the ordinary first pool. This code has been missed from the bootstrap conversion....
add D3 styles
remove old files
move 3rd party files to vendor folder
Show n/a for static mappings, as prior versions did. Ticket #5942
Missed to fix all $mappings
Fix indexing of $mappings and fix column headers
Remove "$entry['iaid'] . " from $mappings[] since the IAID of the IA_NA != IAID of the IA_PD, please see note in https://redmine.pfsense.org/issues/4206#note-9
Add table header for the icon in the Delegated Prefixes section to fix alignment of the column headers.
print_callout class setting
The last test here looks not good having just a single equals sign - if the interpreter evaluates this then $class will always get set to 'info'.In practice it should work OK, because the evaluation of boolean conditions left to right should stop when any of the other tests to the left evaluates false. So $class will only be set to 'info' if it is not already 'default' 'danger' or 'warning'....
Use MiB units for memory disk size
Forum: https://forum.pfsense.org/index.php?topic=106547.0The underlying FreeBSD command seems to allocate space in MiB - e.g. https://www.freebsd.org/doc/handbook/disks-virtual.html examples show a 5m disk getting 10240 sectors (of 512 bytes) = 5120 KiB = 5 MiB. Even though the formatted space shown by df ends up being less, the underlying total allocated space is the specified size in MiB....
Merge pull request #2695 from derelict-pf/master
Merge pull request #2694 from NOYB/Diagnostics_/_Tables_-_URL_Table_Aliases
Fixed blank space caused by hidden input
Think you are saying to put the second info block on a new line. Though I could live with that. I'm not fond of the extra dedicated line. Consuming vertical space when there is plenty of unused horizontal space available in which it flows well.
Seems like maybe the the browser is not honoring something about the info block css, such as a width, or perhaps something that hasn't been specified in the css, and causing it to line wrap....
Update system_certmanager.php
Something felt off about the certificate icons. Particularly the fa-key + P12. I think this is better.
Update system_camanager.php
Something felt off about the Certificate/CA icons. Especially the fa-key and P12 being the same action. I think this is better.
Merge pull request #2693 from NOYB/Diagnostics_/_Tables_-_URL_Table_Aliases
Diagnostics / Tables - URL Table Aliases
Handle URL table aliases similar to bogons tables. Suppress record remove buttons.Update (download) only the selected URL table alias instead of all of them.Retain full line comments in downloaded URL table files so we can view and use them....
HTML Compliance - Services Status Widget
The for attribute of the label element must refer to a non-hidden form control.There is no corresponding target of this for attribute. Removing.
Update license page. Ticket #5903
Don't unnecessarily exclude IPv6 addresses here. See ticket #5931
Allow ":" in the route destination network, otherwise an IPv6 address cannot be entered.
Merge pull request #2688 from NOYB/Don't_Leave_Ancestor(s)_Selected
Remove callsto updateWidget since widget status is now saved explicitly via the save icon in hte breadcrumbbar.
Don't Leave Ancestor(s) Selected
Show correct direction for in states
Fixes the PPP interface list. List all physical interfaces + VLANs and not the assigned ports.
Ticket #5925
Hide additional bootp options when it's disabled, fixes #5914
Fix indent
Add a space between the gateway name and IP
Move the DHCPv6 apply action into a function. Capture the apply and save actions separately and only perform the required task. Fixes #5910
Do not offer the "CA" type when creating a certificate. CAs should only be made on the CAs tab. Fixes #5924
Remove unnecessary code. CARP isn't a interface anymore, radvd cannot run on CARP IPs.
Use high level functions
Check the end of range to make sure it's inside subnet too