pfSense

firewall_aliases add print_apply_box code

Fix #5794 remove print_info_box_np chackes for gettext("apply")

1) Get rid of the stristr() checks to "guess" if an apply button should
be used.
2) Change print_info_box() so it can take a button name of "close"
, "apply" or none to decide which button to show....

Only the serial enable/disable and primary console selectors should be hidden for this test, the serial speed selector must still be available.

Merge pull request #2513 from ch1c4um/replace_jQuery_to_$

Replaced jQuery to $ in same files

Relocate subnet mask drop-down to a more sensible place on the PPPoE server, add a user login count option.

Use default log file from pfSense-upgrade when it's called by GUI, this will make sure we preserve first part of upgrade after reboot

Make diag_arp info an infoblock

I might find a few of these while looking at various print_info_block calls, but this one for a start that works well as infoblock blockopen.

Merge pull request #2510 from brunostein/add_call_gettext_function_menu_vpn

Make sure LANG = C for pkg calls

Move set_language() call back to guiconfig.inc since it's causing trouble on console

replaced jQuery to $

add call 'gettext' function in the vpn menu files

Merge pull request #2502 from phil-davis/patch-6

Replace "jQuery" with "$" for consistency

add call 'gettext' function in the status menu files

Fixed #5793

Remove redundant alias check and move group check to proper place, fixes #5795

Do not let interface description to have same name of an interface group. Fixes #5795

Merge pull request #2503 from NOYB/Form_Group_-_Empty_Title_GetText

Merge pull request #2494 from phil-davis/patch-2

Merge pull request #2500 from NOYB/Firewall_Log_Widget_-_Revert_Abbreviation

Adding {} to if statement.

Merge pull request #2505 from phil-davis/patch-5

Cleanup crash_reporter Submit checks

When looking at this earlier I never paid attention to the left side of each of these conditions. It is pretty dumb to gettext($_POST['Submit']) and then compare it to gettext("Yes") !!!
This cleans it up so it does just an ordinary comparison - works fine.

Merge pull request #2504 from phil-davis/gettext-widgets

Internationalize dashboard widgets

Form Group - Empty Title GetText

Don't call gettext with an empty title.

There are undoubtedly other places that a check should be done before passing a variable only to a gettext call.

Fixes use case of form group class without a title from passing empty var to gettext....

Be more flexible on detecting the need for the Apply button

This is the quick fix part (1) for https://redmine.pfsense.org/issues/5794

Merge pull request #2501 from phil-davis/patch-5

Don't show RTT, RTTsd, Loss for unmonitored gateways

Crash Reporter compare choice with language-specific string #5792

I don't really understand why this has to be - the HTML has value="Yes" and value="No" - I thought those would be the strings sent along with "submit".
The translation of Yes and No should have been just for display purposes....

Merge pull request #2470 from al-right/master

Added some comments

Firewall Log Widget - Revert Abbreviation

Fine to spell out 'Destination' here.
1) Field content already has column wide enough.
2) Consistent with firewall log.
3) Already translated.

Return interface abbreviation to it's original uppercase 'IF' to not look so much like the word 'If'.

Merge pull request #2498 from NewEraCracker/master

Fixed #5790
I think

Fix another misplaced quote

Fix misplaced quote (resolves syntax error)

Regenerate pfSense.pot

Fix #5690:

- Remove parameters from set_language()
- Add a global variable for default language
- add env var for LANG, otherwise it won't work

Fixed #5789

Merge branch 'add_call_gettext_diagnostic_menu_pages' of https://github.com/brunostein/pfsense

• 'add_call_gettext_diagnostic_menu_pages' of https://github.com/brunostein/pfsense:
  add call gettext function for translate

Merge pull request #2495 from phil-davis/gt1

Add gettext to select option names where required

Internationalization graph guiconfig head index

xmlrpc signature and docstring

A few of the entries in this array had dodgy var references. I don't think anything would have caused an actual error.

add call gettext function for translate

Regenerate pfSense.pot

Regenerate pfSense.pot

Change dependency icon back to a paperclip (globe seems to imply more than intendend here), fix appearance of the text.
<ul> without <li> is invalid, remove. Also move the icon to a separate i tag, putting it in an a tag changed the font in an undesirable way.

Merge pull request #2486 from NOYB/Special_Panels_-_Show/Hide

Add a close button to Edit load/save messages

Other places use more standard code for printing success/error messages.
But the Edit File page is a bit different. The standard code puts a
close button on messages so that users can dismiss them if they like....

Do not call gettext() for empty string

Fix "View content" href

Merge pull request #2490 from phil-davis/info-block1

DHCP - Decode value while validating contents

https://forum.pfsense.org/index.php?topic=105654

Remove close button from firewall_rules

Issue: https://redmine.pfsense.org/issues/5788

Merge pull request #2489 from NOYB/Status_/_System_Logs_-_Tab_Array

Merge pull request #2488 from PiBa-NL/23_rulesedit

Remove remaining PBI symlinks not registered in .pbiopt file. If should fix #5221

Make sure code reaches pbi_delete

Think the term 'associated' may be better here than 'special'.

Use icons instead of text.

Shorten titles to be more consistent with other title bar shortcuts and also match the option setting title.

Status / System Logs - Tab Array

Only call display_top_tabs function if there is a tab array to display.

The display_top_tabs function prefixes the type parameter with 'nav nav-'. So passing 'nav nav-tabs' adds a nonexistent class; 'nav-nav'. Only pass 'tabs' as the type.

firewall_rules_edit, load advanced settings flags-any and sloppy-state back into webgui

Comment fix

Remove debug

Escape HTML on re-saving separator text

Fixed #5784

Apply recommended changes.

Fixed #5781

Provide warning message onleavinghte page
Allow Esc key to cancel a new separator
Allow Enter key to save a new separator

Special Panels - Show/Hide

Add configuration option to show or hide special panels.
When a panel is hidden a button is displayed on the page title bar to toggle the panel display.

Status / System Logs / VPN / PPPoE Service - Fix Shortcut Links

Fix PPPoE Service shortcut so links show on the breadcrumb bar.

Merge pull request #2472 from dennypage/master

Changed color scheme to use existing bg-* classes
Simplfied color change mechanism
Implemented "Cancel" button

Add colors to the separator bars

Fixed #5781

Eliminate foreach for speed.

New separator text box has focus when created

Fixed issue with separator bar at very top of floating rule list

Merge pull request #2484 from phil-davis/gt9

Merge pull request #2483 from phil-davis/patch-5

Merge pull request #2482 from phil-davis/patch-3

Merge pull request #2481 from phil-davis/patch-2

Merge pull request #2480 from phil-davis/gt8

Merge pull request #2479 from phil-davis/gt7

Internationalization of remaining firewall_*.php

Firewall shaper wizards print_info_box() severity level

Completed basic #5373
May add a color option after some testing

Firewall shaper print_info_box at correct severity

Allow enable/disable rule for Firewall NAT Out

The code for it was all there, but the icon was hidden when the rule was enabled, so there was no wayto click to disable.
It all works for me with just this small change.

Firewall NAT Port Forward rule enable/disable toggle

Provide the rule enable/disable toggle like in NAT 1:1 and NAT NPt

Provide "add top" and "add bottom" buttons for NAT 1:1 and NPt

So that they are consistent with NAT Port Forward.

Merge pull request #2477 from phil-davis/gt6

Internationalize firewall_rules pages

I might have gone too far wrapping '(other)', 'any', 'default', 'none'
in gettext() but actually if translating to a language with non-Latin
script then it can be useful to translate even these sort of single
words, because there might be some people who cannot even read Latin...

Merge pull request #2473 from phil-davis/gt5

Fix browser tab text

Restore separator bar delete functionality