pfSense

Update pkg_mgr.php

• Note - There are two lines previously commented out at Lines! (L127-128)

• Mods to if/else/elseif/endif statements for consistency.
• Change package dependency href link icon from "paper-clip" to "globe".
• Put package dependency links into a < ul > for a cleaner output when dependencies span over two lines....

Fixed #5714

Merge pull request #2335 from NOYB/HTML_Compliance_-_Interfaces_/_Assign_network_ports

Merge pull request #2334 from BBcan177/patch-2

Fix typo password confirm

https://forum.pfsense.org/index.php?topic=104629.0

Remove workaround to get dpinger running when interface is in tentative state

HTML Compliance - Interfaces / Assign network ports

A table row was 3 columns wide and exceeded the column count established by the first row (2).

Update pkg_mgr_installed.php

• Mods to if/else/elseif/endif statements for consistency.
• Change font red to span class.
• Change package dependency href link icon from "paper-clip" to "globe".
• Remove redundant <i> in package dependency href link
• Put package dependency links into a <ul> for a cleaner output when dependencies span over two lines....

Add output validation here too. Ticket #5351

complete breadcrumbs for each tab

Do not start dpinger processes due to rrd

No need to restart dpinger to get new rrd data, it's not like apinger that send data to rrd

Fixed #5694

Final updates in support of hidden passwords

Restore default MTU when field is cleared. Fixes #3926

Make sure source and target addresses have scope id when they are link-local. It should fix #5695

Add a seatbelt to prevent 2 dpinger instances for same GW

Merge pull request #2333 from NOYB/HTML_Compliance_-_System_/_User_Manager_/_Users

Correction to #5710

Fixed #5710

Collect dpinger processes that failed to start and try again after 1 second, this should be enough to fix #5711

No need to return 0 here

Change start_dpinger() to return dpinger return code

Do not overwrite $params

Merge pull request #2332 from dennypage/master

Follow dpinger and change default loss_interval to 4* send_interval

HTML Compliance - System / User Manager / Users

A table row was 6 columns wide and exceeded the column count established by the first row (5).
End tag div seen, but there were open elements.
Unclosed element form.
Close php tag.

Fixed saving password when the ols password needs to be retained

Merge pull request #2331 from BBcan177/patch-1

Disable unused stdout reporting thread

FInished password hiding logic by ensuring $_POST['password'] != DMYPWD before updating

Added new addPassword method and password == password_confirm validation where required.

Add href for package dependencies (pkg_mgr_installed)

• Case typo
• Change package dependency text to href link(s).

Merge pull request #2330 from ExolonDX/master

Don't display dummy password if configured pwd is empty

Experimental: Fixed #5693
Added new functionality to PHP classes, and used it ONLY in system_advanced_notifications.php -> smtp password

Update "firewall_aliases.php"

Add Bootstrap panels to "firewall_aliases.php"

Disable IPsec phase1 or phase2 using DES and inform user why they were disabled since DES is no longer supported. It should fix #5543

Revert "Delete package XML only on post-deinstall, otherwise it'll do it twice"

This reverts commit 92b3ac622cc3789ca00b625052621f0dc4262f1f.

Revert "Silent accept deinstall and pre-install on rc.packages"

This reverts commit d7c8eb30ddad2140a2790a7a8989158e52f74bc9.

Only remove config.xml items on post-deinstall, fixes #5689

Disable all IPsec P1 entries when old version has IPsec globally disabled. Fixes #5699

Fixes issue where limiter mask does not save (from forum)

Change alert box color to success

Merge pull request #2321 from ch1c4um/Fix_dns_resolver

HTML Compliance - System / Package Manager / Available Packages

Bad value #search-panel .panel-body for attribute href on element a: Illegal character in fragment: space is not allowed.
<a data-toggle="collapse" href="#search-panel .panel-body" name="search-panel">...

Replace inetd by xinetd, it should fix #5707

Fixed #5697

Merge pull request #2327 from NOYB/HTML_Compliance_-_System_/_Package_Manager_/_Available_Packages

Merge pull request #2326 from NOYB/HTML_Compliance_-_System_/_Certicate_/_CAs

Alternative to PR 2324 - Remove unneeded div

HTML Compliance - System / Package Manager / Available Packages

Stray tbody, table, and div tag ends when list empty.
Close php tag.

HTML Compliance - System / Certicate / CAs

Close div tag
Close php tag

update comment for dpinger

Update pkg_edit.php

• Incorrect variable name in pkg_edit

clarify text, might not apply to "NIC" (lagg, VLANs, etc.)

Fixed #5691

HTML Compliance - System / Advanced / Firewall and NAT

Bad value 200000↩ for attribute placeholder on element input: Line feed not allowed.
<input class="form-control" name="maximumtableentries" id="maximumtableentries" type="text" placeholder="200000↩">...

This broke things again. Revert "data sanitising: ip2long32, ip2ulong, long2ip32 (FIXED RESUBMIT of #2152)"

This reverts commit 4557e3fba627c91c37afba04681cdabf71eccf57.

Merge branch 'master' of git.pfmechanics.com:pfsense/pfsense

fix part of #5604

Added support for <width> on inouts and aliases.

Add title to add row buttone

Fixed #5668

Add pkg key fingerprint for packages from beta.pfsense.org

Fixed bug to disable dns resolver service

data sanitising: ip2long32, ip2ulong, long2ip32 (FIXED RESUBMIT of #2152)

Self explanatory. If these functions find themselves trying to convert non-int data (or an x64 int with non-zeros in any bits >32) to dotted IPv4, or non-dotted IPv4 to integer IPv4 values, something's wrong and they shouldn't return a value that looks like they succeeded....

Take this conditional out, it wasn't enough, and we have a script example for how to handle this properly now while respecting CSRF

Merge pull request #2319 from NOYB/HTML_Compliance_-_System_/_Advanced_/_Admin_Access

Merge pull request #2318 from phil-davis/patch-2

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

Bug #5527 wizard breadcrumb Concept

This would require some minor adjustments to the wizards xml , for it to make sense everywhere.

Return complete path for dpinger PID filename, it should fix #5686

Be less specific with dpinger PID filename regex, old version was not matching IPv6 addresses, with or without %ifname in case of ll

HTML Compliance - System / Advanced / Admin Access

Close div tag
Close php tag

LAGG edit fixes

1) $_POST['members'] is an array, but $pconfig['members'] should be a comma-separated list. So the general copy "$pconfig = $_POST;" needs to be followed by setting up 'members' in particular.
2) $members_array is never used - so throw it away....

Add trash can icon to rowhelper delete buttons

Remove name collision in $width attribute

Accommodate <width> XML tag in rowhelper input fields

Move width:auto style to textarea handler in pkg_edit.php

Merge pull request #2316 from phil-davis/patch-3

Merge pull request #2295 from NOYB/HTML_Compliance_-_Form_Input_-_Placeholder

Merge pull request #2311 from heper/patch-1

Adds support for <width> XML tag in rowhelper selects

HTML Compliance - Form Select 3rd try

This is a combined version of:
https://github.com/pfsense/pfsense/pull/2310
https://github.com/pfsense/pfsense/pull/2315

Default textarea width to 60 cols.
Use setCols() to override

Adds style="width: auto;" attribute to textareas to allow the "cols" attribute to take effect. Required bu pkg_edit.php and by wizards

Reverts change to Form_Selector which was breaking selectors with blank options

Modify CSS to allow caller to specify width

Bug #5527

Bug #5527

Update system_gateway_groups_edit.php

Bug #5527

Bug #5527

Bug #5527

bug #5527

Added support for rows, cols and wrap to Forms_Textarea and to pkg_edit.php