pfSense

Icon consistency in Repeatable blocks. Ticket #5965

Fix formatting on the UPnP page, fixes #5970

Bring some consistency to the way most buttons are displayed (color, icons, etc). Ticket #5965

Still need to review Advanced buttons and Repeatable block buttons.

log dhcpleases and dhcpleases6 to dhcpd.log. Ticket #5968

Correct reference for 6rd. Ticket #5967

Remove bonus comma

Fix alias import icon visibility, and change to a more relevant icon. Fixes #5963

Changed all selectoraction to"change" instead of "click"

Fixed #5962

Upon further review, use a more clear and related set of icons for CARP status, play-circle (master) and pause-circle (backup). Ticket #5965

Change shortcut bar status icon to bar-chart, the gear/cog purpose was unclear, looked too much like a settings icon. Ticket #5965

Change "internal" representation of CA on CA and CRL list to an icon, and the inuse indicator on CRLs to an icon. Ticket #5965

Add visual indication of negation on Outbound NAT list. Fix static port representation to use an icon with a helpful title. Ticket #5965

Give a visual indication when a port forward has the negation option active (no rdr). Ticket #5965

Correct the text and placement of the disable and nobinat options for 1:1 NAT rules. Fixes #5966

Slight change to CARP status icons, difference between master and backup status was not clear enough. Ticket #5965

Correct some icon usage inconsistencies. Fixes #5965

Clean up the CARP status widget. Fixes #5964

Move Save button on config history settings inside the panel with the other settings. Fixes #5961

Merge pull request #2717 from NOYB/System_/_User_Manager_/_Groups_/_Edit

Merge pull request #2716 from phil-davis/patch-6

Merge pull request #2715 from phil-davis/patch-5

Merge pull request #2714 from phil-davis/actions

Merge pull request #2713 from phil-davis/patch-3

System / User Manager / Groups / Edit

Error: th start tag in table body.

Warning: A table row was 3 columns wide and exceeded the column count established by the first row (2).

Change invalid use of $iface in interfaces.php

At this point $iface is an undefined var. So the last test of this "if" statement is useless.
That code fragment was introduced in commit https://github.com/pfsense/pfsense/commit/e4d40f41aafe00353c0069b457a0b1b0d6c20987...

Improve track6-prefix-id handling

1) The var $iface is not set at lines 2457 or 2464. It is a var that was used higher up local to build_ipv6interface_list() - it is not relevant to the single fields track6-prefix-id--hex and track6-prefix-id-max
2) When the user selects a different track6-interface then trigger update_track6_prefix() which will update the help text track6-prefix-id-range....

Add Actions column heading

to other places where it was missing, for UI consistency.

Add Actions column heading for CRL Manager

To be consistent with everywhere else that has a heading for the Actions column.

System / User Manager / Users / Edit

Warning: A table row was 4 columns wide and exceeded the column count established by the first row (3).

Error: Stray end tag td.

On second though, don't use this class on this particular tag in the WoL widget.

Fix up the formatting of the Wake on LAN widget and change the code style so it isn't a bunch of echos. Fixes #5960

Fix load balancer status widget uptime percentage display. Fixes #5959

Destroy reference after foreach

As recommended at https://secure.php.net/manual/en/control-structures.foreach.php

HTML Compliance - Login Form

Error: Duplicate attribute class.
<div class=alert alert-warning class=hidden id=no_cookies>Your browser must support cookies to login.</div>
Consolidate multiple class attributes.

Error: Attribute autocorrect not allowed on element input at this point....

When listing the network interfaces, print the link state and not the administrative state.

If you are assigning interfaces, remove the existing configuration from old interfaces if any.

This fixes the need for a reboot after changing interface assignment in console.

Merge pull request #2708 from phil-davis/patch-3

Limit widget column to dashboardcolumns

Stops widgets from "going missing" when the user reduces the dashboard columns in System, General Setup.
If the user just lowers dashboard columns to see what happens, then increases it again, the actual column settings are preserved in the config, so the widgets go back where they were. That seems a good thing....

Correct wording of prefer_ipv4 help text

System / User Manager / Groups / Edit / Add Privileges

Not certain that the list needs to be sorted here. Looks like it is already in order. If it does then a valid callback function will need to be accessible.

Error: Non-space characters found without seeing a doctype first. Expected e.g. <!DOCTYPE html>....

fix whitespace

Remove duplicated text/javascript

Add track6 DHCP6 IPs back to interface when applying changes. Ticket #5945

After recreating the VLAN interface, run interface_configure on it if it's assigned and enabled. Ticket #5951

clean up description

Remove help text wrongly copy/pasted from elsewhere.

Update nginx gzip_types. Remove text/html since it's redundant, and add a few others. Particularly useful, json, since status_monitoring.php uses it. Reduces load time on slow connections to about 1/4th of what it is without gzip on json. Ticket #5498

fix dark theme css

Always set ignore_acquire_ts = yes. No need for that in any of our use cases, and it fixes problems like Ticket #4719.

Merge pull request #2705 from NOYB/HTML_Compliance_-_Diagnostics_/_States_/_States

Merge pull request #2703 from phil-davis/patch-2

Re-generate pfSense.pot

HTML Compliance - Diagnostics / States / States

Bad character - after <. Probable cause: Unescaped <. Try escaping it as <.

Merge remote-tracking branch 'upstream/master'

Adjust default parameters to match changes in dpinger

A PD-obtained subnet is always a /64 on the interface, so should be shown as such here in DHCPv6 server. Ticket #3029

Revise explanation and validation of dpinger parameters.

pkg-utils typo in comment

Move NTP access restrictions to their own tab and add the ability to craft custom restrictions for arbitrary networks. Fixes #4463

Revert "Always send a -HUP to dhcp6c in interfaces_track6_configure for DHCP6 WAN types. Doing so isn't any more disruptive than what it's already doing, and that ensures track6 interfaces don't lose their IPv6 IPs. Ticket #5945"

This reverts commit 471b81f8f7b0a5fe22019aed955e5374e3411dbf.

IF PHP is not running, just exit silently

Detect binary packages installed but not registered in the system and do it during boot

Add an option to get_pkg_info() that makes it do not try to update metadata

Remove get_pkg_id, last calls to it was removed

Remove Status -> RRD Graphs in favor of Status -> Monitoring. Ticket #5498

HTML Compliance - Diagnostics / S.M.A.R.T. Status / Information & Tests

Remove unused/duplicate ID's; action, device, submit.

Merge pull request #2700 from al-right/master

Shift the values to account for the removal of the gateways one. Ticket #5905

Remove the code block to "fake" DHCPv6 server, now that it's unnecessary. Ticket #3029
also ref: https://forum.pfsense.org/index.php?topic=107537.msg600111#msg600111

Use correct variable. Ticket #5946

Clarify log, remove old commented out things that are unnecessary.

Fix text for OpenVPN client that was copied from server, client's second.

Always send a -HUP to dhcp6c in interfaces_track6_configure for DHCP6 WAN types. Doing so isn't any more disruptive than what it's already doing, and that ensures track6 interfaces don't lose their IPv6 IPs. Ticket #5945

Merge pull request #1 from al-right/al-right-patch-1

Al right patch 1

Ticket #5905 remove unused code

Ticket #5905 remove hardcoded colors

Update status_dhcpv6_leases.php

Fix lacking of incrementation of index when two characters have been passed.

Fix check of $n so that the octal value is checked as an octal value.

Ticket #5905 remove hardcoded colors

ticket #5615 fix popover hover

change hardcoded colors to classes

fix styles for bordered table on dark theme

update old styles with new css classes

Ensure the extensions.ini has no duplications before setting up php.ini. Fixes #5943

Read xml files from /usr/local/share/pfSense/menu and load menu entries

Merge pull request #2696 from phil-davis/patch-1

Merge pull request #2697 from phil-davis/patch-2

Merge pull request #2699 from NOYB/HTML_Compliance_-_Diagnostics_/_Edit_File

Merge pull request #2698 from phil-davis/patch-3

HTML Compliance - Diagnostics / Edit File

Attribute width not allowed on element input at this point.
<input type=number id=gotoline width=6>
Width attribute is only valid on input element for type image.
Changed to use size attribute.

Stray end tag input....

Fix DHCPv6 server check to allow track6. Ticket #3029

Add function to return the physical interface(s) for a given parent. related to Ticket #5081

Add code to handle DHCP leases in multiple pools

1) Add code from RELENG_2_2 https://github.com/pfsense/pfsense/commit/cf3aff59edfa4b101d69ddd694a59fdc580d2299 that checks for leases that are in pools other than the ordinary first pool. This code has been missed from the bootstrap conversion....

add D3 styles

remove old files

move 3rd party files to vendor folder

Check $active

Fix missing check for $active to avoid creating a route to a released lease.

Show n/a for static mappings, as prior versions did. Ticket #5942

Fix substr mistake

Made a silly mistake and overlooked an important difference between javascript substring() and php substr().
Tightened regex check for octal value.

Missed to fix all $mappings